From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C79B43829 for ; Tue, 5 Mar 2024 16:36:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37E0342E3A; Tue, 5 Mar 2024 16:36:02 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id E54FE410D3 for ; Tue, 5 Mar 2024 16:36:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709652960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pag8r480Uijzey9o9QgU3dBItJcJSXZwJnEtj3jCiLg=; b=emtKoG82l04ik08x7MRlrPUgAtdgW1D+u/kS8ZH+Wdi24xfJXXAx5ThwaKbBymkDflSpYx 4Vsu9q12wodsiNLYKmZDHnnyq9YTU/l2Xe60Q0/tci9X5Jyz9m30hjNTxWi+W0SzU2ZxPp iOVkzuwUqICocpctqKpZpyUenQGONR4= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-139-VGQLe7xmPvWa5MvbQh9_CA-1; Tue, 05 Mar 2024 10:35:57 -0500 X-MC-Unique: VGQLe7xmPvWa5MvbQh9_CA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F347C29AA3B9; Tue, 5 Mar 2024 15:35:56 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.194.197]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3A2C2200AE7F; Tue, 5 Mar 2024 15:35:56 +0000 (UTC) From: Kevin Traynor To: Chengwen Feng Cc: Jie Hai , dpdk stable Subject: patch 'net/hns3: remove QinQ insert support for VF' has been queued to stable release 21.11.7 Date: Tue, 5 Mar 2024 15:34:19 +0000 Message-ID: <20240305153449.263666-46-ktraynor@redhat.com> In-Reply-To: <20240305153449.263666-1-ktraynor@redhat.com> References: <20240305153449.263666-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/11/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/d2d6bdae86ac9b001ae269bc5c7d5583eee2de81 Thanks. Kevin --- >From d2d6bdae86ac9b001ae269bc5c7d5583eee2de81 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Thu, 28 Dec 2023 20:14:28 +0800 Subject: [PATCH] net/hns3: remove QinQ insert support for VF [ upstream commit f6e79b8d3968150736499bc225762b62fbf1b768 ] In the HIP08 platform, the PF driver will notify VF driver to update the PVID state [1], and VF will declare support QinQ insert when PVID is disabled. In the later platform (e.g. HIP09), the hardware has been improved, so the PF driver will NOT notify VF driver to update the PVID state. However, the later platform still have constraint: PVID and QinQ insert cannot be enabled at the same time, otherwise, the hardware discards packets and reports an error interrupt. Plus, as far as we known, VF driver's users don't use the QinQ insert. Therefore, we declare that the VF driver don't support QinQ insert. [1] commit b4e4d7ac9f09 ("net/hns3: support setting VF PVID by PF driver") Signed-off-by: Chengwen Feng Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_common.c b/drivers/net/hns3/hns3_common.c index ace5be01d5..02328d18bc 100644 --- a/drivers/net/hns3/hns3_common.c +++ b/drivers/net/hns3/hns3_common.c @@ -85,5 +85,5 @@ hns3_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info) RTE_ETH_TX_OFFLOAD_VLAN_INSERT); - if (!hw->port_base_vlan_cfg.state) + if (!hns->is_vf && !hw->port_base_vlan_cfg.state) info->tx_offload_capa |= RTE_ETH_TX_OFFLOAD_QINQ_INSERT; -- 2.43.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-05 14:08:55.750835490 +0000 +++ 0046-net-hns3-remove-QinQ-insert-support-for-VF.patch 2024-03-05 14:08:54.672520823 +0000 @@ -1 +1 @@ -From f6e79b8d3968150736499bc225762b62fbf1b768 Mon Sep 17 00:00:00 2001 +From d2d6bdae86ac9b001ae269bc5c7d5583eee2de81 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f6e79b8d3968150736499bc225762b62fbf1b768 ] + @@ -23,2 +24,0 @@ -Cc: stable@dpdk.org - @@ -32 +32 @@ -index 8f224aa00c..28c26b049c 100644 +index ace5be01d5..02328d18bc 100644 @@ -35 +35 @@ -@@ -86,5 +86,5 @@ hns3_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info) +@@ -85,5 +85,5 @@ hns3_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info)