From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 000EF43829 for ; Tue, 5 Mar 2024 16:36:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BFA4742E51; Tue, 5 Mar 2024 16:36:17 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 9F62342E63 for ; Tue, 5 Mar 2024 16:36:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709652975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qKMYmA+DUb7+xvRoy3xJ7C2XV68EzjsD3o4B0gg2n3w=; b=BnlgbQ2hlYD8bTDhQKBdLb4BtB0pdJh+mCM49GnUgGr2qdPzL5oRsdbp2ibNMkwHqFx0it 9a7FPOWxCDl0rvTlyO8PCEaBiX5+s+ef0ItXHRbjYKebdywt8iRb5kW3lC+duqyEXHFdPy OnPIGw8yvAToRZ+xWLYAH6s7bFj7EFM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-36-KuXawTgvPJScKjgrG97-jg-1; Tue, 05 Mar 2024 10:36:13 -0500 X-MC-Unique: KuXawTgvPJScKjgrG97-jg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 326E8101A526; Tue, 5 Mar 2024 15:36:13 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.194.197]) by smtp.corp.redhat.com (Postfix) with ESMTP id 57EE4200AE7F; Tue, 5 Mar 2024 15:36:12 +0000 (UTC) From: Kevin Traynor To: Kalesh AP Cc: Ajit Khaparde , Somnath Kotur , dpdk stable Subject: patch 'net/bnxt: fix speed change from 200G to 25G on Thor' has been queued to stable release 21.11.7 Date: Tue, 5 Mar 2024 15:34:33 +0000 Message-ID: <20240305153449.263666-60-ktraynor@redhat.com> In-Reply-To: <20240305153449.263666-1-ktraynor@redhat.com> References: <20240305153449.263666-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/11/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/c208fb7ed9631f00ce41f351247e7fd5ea6600ef Thanks. Kevin --- >From c208fb7ed9631f00ce41f351247e7fd5ea6600ef Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Sat, 4 Nov 2023 22:31:07 -0700 Subject: [PATCH] net/bnxt: fix speed change from 200G to 25G on Thor [ upstream commit 753b8ff26162ffaf118c03e47ab75cfd2229d4e8 ] While forcing speed to 200G, driver sets the structure variable "bp->link_info->link_signal_mode" value to BNXT_SIG_MODE_PAM4. After that when the user forces the speed back to 25G, this cached value is not set back to BNXT_SIG_MODE_NRZ which results in issuing the HWRM_PORT_PHY_CFG command with wrong inputs. Fixes: c23f9ded0391 ("net/bnxt: support 200G PAM4 link") Signed-off-by: Kalesh AP Signed-off-by: Ajit Khaparde Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_hwrm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 45f92ff558..098f84fbae 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -3006,4 +3006,5 @@ static uint16_t bnxt_parse_eth_link_speed(uint32_t conf_link_speed, eth_link_speed = HWRM_PORT_PHY_CFG_INPUT_AUTO_LINK_SPEED_25GB; + link_info->link_signal_mode = BNXT_SIG_MODE_NRZ; break; case RTE_ETH_LINK_SPEED_40G: -- 2.43.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-05 14:08:56.071222675 +0000 +++ 0060-net-bnxt-fix-speed-change-from-200G-to-25G-on-Thor.patch 2024-03-05 14:08:54.713520932 +0000 @@ -1 +1 @@ -From 753b8ff26162ffaf118c03e47ab75cfd2229d4e8 Mon Sep 17 00:00:00 2001 +From c208fb7ed9631f00ce41f351247e7fd5ea6600ef Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 753b8ff26162ffaf118c03e47ab75cfd2229d4e8 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index 8f37077522..441e3aef51 100644 +index 45f92ff558..098f84fbae 100644 @@ -26 +27 @@ -@@ -3192,4 +3192,5 @@ static uint16_t bnxt_parse_eth_link_speed(uint32_t conf_link_speed, +@@ -3006,4 +3006,5 @@ static uint16_t bnxt_parse_eth_link_speed(uint32_t conf_link_speed, @@ -28 +29 @@ - HWRM_PORT_PHY_CFG_INPUT_FORCE_LINK_SPEED_25GB; + HWRM_PORT_PHY_CFG_INPUT_AUTO_LINK_SPEED_25GB;