From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4A5C43C60 for ; Thu, 7 Mar 2024 02:33:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C9A9F42E64; Thu, 7 Mar 2024 02:33:53 +0100 (CET) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by mails.dpdk.org (Postfix) with ESMTP id 3781E40261 for ; Thu, 7 Mar 2024 02:33:52 +0100 (CET) Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-33e2248948bso181193f8f.0 for ; Wed, 06 Mar 2024 17:33:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709775232; x=1710380032; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WuqwDtOY1kDKH3BEaXcNLx1ieZVQ2tduwZMsH3IWGSw=; b=RwxjmA14nYt8xN8qjJHb2/QHoFUNI8EfBmXOU4iEi2wljQA01vPsaqv4JkwbDN8Xkx fVihBZxpqMBWeSQGJUbsJjCsvKalrEJujUK1bevr5u1j0b/x0cIV0iDtYdYOrvYYj1t3 tNgh4tZvAZx1QWOQ5hnZPEWS2IBYWrQvpZ36jJvdFSEI+F28sA1gRUs7EH2hFJ3AnsBb KIdgbJLFlkjiwsOzSQOyAKKyWOYIZ9I2A4CimcK5L4tL9VobIrBvKdkR9a9uxU22sdf3 PXhKs0o5VHIXKn6kTvjOlBJvXlIuZRi4ixXJWDvZp5zkSDvFL8khiTlp+omBrujaCaaA 303A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709775232; x=1710380032; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WuqwDtOY1kDKH3BEaXcNLx1ieZVQ2tduwZMsH3IWGSw=; b=RXtzi7Y8lhRVHPk3eXhFCBy8vC1KLg2Y1OXE1xV/QfPCIAJtVeds/4u1U+n+AkYQAL vRK2UoM9nZRpaZl5epZTmlzjCi0rKsacRVi2LjjKt1wTT1wa5AxmGgjU5DoAQ24koEqa ynDalQ0ukS+irUXSAqE5M6VQVbL9iQDS7BdzbF+mdE5N/r1REN2LtsADfdCYOpruRn8u VrHvYMvNiGw5A+TerNjpqv/Tx+zJVBqjEWjJdV99GVP4hgI9asuKryV4/4lQMjXbYsqF bcmUlBt2b3NWQ/tqCUsJ+U2IMpUgCNUoCGLoU0peRMyMm2UXZ8i0H2qFnGM9pM1obONE jbKQ== X-Gm-Message-State: AOJu0YyYbWjMbO7DpP/8qNrLRqu+hgScMFAJLOcB2bF/4QlNqP1OnAOi vJgPKSnZeze1M3paKOaMflVyoZsylYHXAHwohUmP+nFZCtxRi6ZK/JK70SNN X-Google-Smtp-Source: AGHT+IHjYvIt62vuO7Sfb/P5HYtgWwnBK+iLBSy99UzS5RB9wU8Hoa3P/Zmfo8Ng2gDSnsKLHUlGWg== X-Received: by 2002:a05:6000:dc8:b0:33e:363b:a7dd with SMTP id dw8-20020a0560000dc800b0033e363ba7ddmr8312035wrb.20.1709775231871; Wed, 06 Mar 2024 17:33:51 -0800 (PST) Received: from localhost ([137.220.120.171]) by smtp.gmail.com with ESMTPSA id bu28-20020a056000079c00b0033dc7e50488sm19342334wrb.96.2024.03.06.17.33.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 17:33:51 -0800 (PST) From: luca.boccassi@gmail.com To: Chengwen Feng Cc: dpdk stable Subject: patch 'net/failsafe: fix memory leak in args parsing' has been queued to stable release 22.11.5 Date: Thu, 7 Mar 2024 01:30:44 +0000 Message-Id: <20240307013159.1735343-27-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240307013159.1735343-1-luca.boccassi@gmail.com> References: <20240307013159.1735343-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/09/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/ab86b4a27a277dd7d10394f787e11fd50801f139 Thanks. Luca Boccassi --- >From ab86b4a27a277dd7d10394f787e11fd50801f139 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Fri, 10 Nov 2023 10:01:08 +0000 Subject: [PATCH] net/failsafe: fix memory leak in args parsing [ upstream commit 2ddf2d7a15deeac3585e08fd7f9ef46ad082b126 ] Should free the memory which allocated by strdup(). Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") Signed-off-by: Chengwen Feng --- drivers/net/failsafe/failsafe_args.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/failsafe/failsafe_args.c b/drivers/net/failsafe/failsafe_args.c index b203e02d9a..3b867437d7 100644 --- a/drivers/net/failsafe/failsafe_args.c +++ b/drivers/net/failsafe/failsafe_args.c @@ -248,7 +248,7 @@ fs_parse_device_param(struct rte_eth_dev *dev, const char *param, goto free_args; } else { ERROR("Unrecognized device type: %.*s", (int)b, param); - return -EINVAL; + ret = -EINVAL; } free_args: free(args); -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-07 01:05:37.353330749 +0000 +++ 0027-net-failsafe-fix-memory-leak-in-args-parsing.patch 2024-03-07 01:05:34.706938064 +0000 @@ -1 +1 @@ -From 2ddf2d7a15deeac3585e08fd7f9ef46ad082b126 Mon Sep 17 00:00:00 2001 +From ab86b4a27a277dd7d10394f787e11fd50801f139 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 2ddf2d7a15deeac3585e08fd7f9ef46ad082b126 ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org