From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4518A43C60 for ; Thu, 7 Mar 2024 02:34:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3CA6742ED9; Thu, 7 Mar 2024 02:34:10 +0100 (CET) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mails.dpdk.org (Postfix) with ESMTP id BD4DF42EE0 for ; Thu, 7 Mar 2024 02:34:08 +0100 (CET) Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-33d146737e6so194714f8f.0 for ; Wed, 06 Mar 2024 17:34:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709775248; x=1710380048; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=t56y2q0hkelXEj0qbTK4G9a6S037lTk1WMM7SzIxz+A=; b=dZFTnw6oZ4b6ZRttPsXjT7ky8kkT1XqVifgKagv8eVdjLrOp1CGYsD9GyJXZKOHKXj NnxQn2yU/nySY/fpmbPFifuFwfaMJOzp5G8LxTkTaYHyVXJNLZVVKiObM9P9xia/iGmF 7diuQaQK3UcNTQNWDg75sBR+0qFweDsFnD4RnGSDmfdld/eq5GdlY9BfOZE05yTY/Bp0 4Du7hBT0dE1sIR2eryr6I108rNG7IK3ALtdFZwQt88egWY5nKmZeKCPcIwWrUKVWqHnC si5+BhHRWVA3Kpy3APhPwIXuDTTMGWkS6vqhv2ZF6sR8JRyiZ3pUIgtq/Kj6cwDwBwLg wAyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709775248; x=1710380048; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t56y2q0hkelXEj0qbTK4G9a6S037lTk1WMM7SzIxz+A=; b=g1vLHrEa9EcoPlsiYIo4d5LXyHCH7OJQpJT0sCD7uU3DFhw/kOlfbRa6g9hPM/Aa0I 1vmVKhOUs56ZUjvX/m8ZFbF24bQ5mqlrdU5cfMatj2RwPDIwgM+BswgK5pbB+iqx04L4 tXQRhRwjzUPXRiNxmSuY+CMShEqaaLGHjQGunz/BtTVpokytEFGQzHTPL3uucB3kXMjz 8pT64F6bRmw4nTkzN1kNvismcyz24wJUSUXWUJjNW0aVxILOaHjaxZcJRx9i+QkB5Iwo xbnCRyY0X6AVpTMlZracLwkzX0GPIX3z+EfPJHATBsslOMc5TJAdnPV0oKqukPi7IGT5 SJeA== X-Forwarded-Encrypted: i=1; AJvYcCUoFWQCOCl25cM0WtfVIvnYlFStk+w5wvYZaTfFini/uf/rxqJV29cx1G4M75iehqGhDTdvGJ2RoFFnp0UR5yM= X-Gm-Message-State: AOJu0Yweib8MpTxs/vvEOhcUzVtrXLz7TnSrCJeX72ehWTrcow8CW0G6 PpImRTXScWc5UTQAWChCBBbRbWPZ17rf50CTGMoyreYZ5PwWxz+mBW3fTsTQ X-Google-Smtp-Source: AGHT+IGTpVdhTnSZoj0ySWh1gTgCqn9xmmZDHaK1JrubzNi1YgcomOBxEVN3PBwFndXUoRvzc66sTg== X-Received: by 2002:adf:e643:0:b0:33d:c5c7:4182 with SMTP id b3-20020adfe643000000b0033dc5c74182mr12050436wrn.7.1709775248407; Wed, 06 Mar 2024 17:34:08 -0800 (PST) Received: from localhost ([137.220.120.171]) by smtp.gmail.com with ESMTPSA id i8-20020adfb648000000b0033e0ed396bdsm18789426wre.106.2024.03.06.17.34.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 17:34:07 -0800 (PST) From: luca.boccassi@gmail.com To: Chengwen Feng Cc: Huisong Li , dpdk stable Subject: patch 'test: verify strdup return' has been queued to stable release 22.11.5 Date: Thu, 7 Mar 2024 01:30:49 +0000 Message-Id: <20240307013159.1735343-32-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240307013159.1735343-1-luca.boccassi@gmail.com> References: <20240307013159.1735343-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/09/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/25bcc3c5b7fe6be881512279de2ad8d553ea8784 Thanks. Luca Boccassi --- >From 25bcc3c5b7fe6be881512279de2ad8d553ea8784 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Fri, 10 Nov 2023 10:01:12 +0000 Subject: [PATCH] test: verify strdup return [ upstream commit 68edcacf428994d3088afb6f5278958cc76665da ] Add verify strdup return value logic. Fixes: af75078fece3 ("first public release") Signed-off-by: Chengwen Feng Acked-by: Huisong Li --- app/test/process.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/test/process.h b/app/test/process.h index 1f073b9c5c..abf6855aaa 100644 --- a/app/test/process.h +++ b/app/test/process.h @@ -59,8 +59,11 @@ process_dup(const char *const argv[], int numargs, const char *env_value) return -1; else if (pid == 0) { /* make a copy of the arguments to be passed to exec */ - for (i = 0; i < numargs; i++) + for (i = 0; i < numargs; i++) { argv_cpy[i] = strdup(argv[i]); + if (argv_cpy[i] == NULL) + rte_panic("Error dup args\n"); + } argv_cpy[i] = NULL; num = numargs; -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-07 01:05:37.751567752 +0000 +++ 0032-test-verify-strdup-return.patch 2024-03-07 01:05:34.738938743 +0000 @@ -1 +1 @@ -From 68edcacf428994d3088afb6f5278958cc76665da Mon Sep 17 00:00:00 2001 +From 25bcc3c5b7fe6be881512279de2ad8d553ea8784 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 68edcacf428994d3088afb6f5278958cc76665da ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index af7bc3e0de..c576c42349 100644 +index 1f073b9c5c..abf6855aaa 100644