From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85DC143C60 for ; Thu, 7 Mar 2024 02:34:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 80E6742ECF; Thu, 7 Mar 2024 02:34:28 +0100 (CET) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by mails.dpdk.org (Postfix) with ESMTP id 4917942E64 for ; Thu, 7 Mar 2024 02:34:27 +0100 (CET) Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-412e783c94fso3410925e9.1 for ; Wed, 06 Mar 2024 17:34:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709775267; x=1710380067; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ls4RCFjf28Wdsmwfvr2vs9psyt4WJ+kuILCjNqWfDPs=; b=GGAI/gQVGUAOzDA0ncOGr9pSD/W+u5ivq84EbRmbl+Fh3Pz7sjtn+MuUjb4IwrRO4F slRL/9OPH6CiVSTEKhYlj0pL8Nm5h7kPoFxZu56MOpO/zmU19aC8OFZXGSET1zjxkNFM 5SZvGe2DzOlmDTRIB59eFhe+bEAYCzBIPqB34fGK/LSLvqh6EQGwjygeAoNIvu8Y7RvF MhlhlZJs5uzqIt7POc4S7gTDT5lIf+QiGlzf7tS56ODtbTPN4bRZzni85BWiLStZNcyW pDjc+4/VOTpV1rS+jZuaLXHIJoSyoYF9uUu3pEFFJMVSky8vGY42y/z997C5FDdTMuFQ EtFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709775267; x=1710380067; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ls4RCFjf28Wdsmwfvr2vs9psyt4WJ+kuILCjNqWfDPs=; b=S3GZ9x0vcltcq+HqQD6UInY+xB2OjStWjMKRt5Z0vJIqyhMX28JWdDGV7vDc3E2vz1 UpmOz64A31MgjBOiY3g4tCwYG/eaA36gRgjT1Cs6+IHTsedrgv6GRNuMTpWluNtK9sd8 iz+vYR906Bmx8sZUC9pVnaZCkaBbDZMXNWyEGeEDF/EbqwE5Tq94SH8VJqepPO9BwPAl yr0qnoFvOXZDrOUn8le225ety+CZfseJaNJY1fGpOyckt/R/NQFGabD86J0O3J9T0rI9 t6DHnZq/f4DagO0tMZwCnRJxI/OJHafPsHNS60fEdqCb06wYwHaFXc7yQWPzPlBhEIjC Klog== X-Forwarded-Encrypted: i=1; AJvYcCUlQDHSpP3AGl/25A8+DkLP5OUt1wpili8KA0zYnNY/SauDeuzlMIZ+udrZNqzab3lI1zUEMJGGsQ4rFOdCqi0= X-Gm-Message-State: AOJu0YwLWBc+jgrDX9gdw1UadWCHQ+fFkLZMvkeslCNaRIZSI2LkT3qF eGEvJ3OUwbSoB5O5iC0FIKX/hsueBDpId9Ce2YQg0nI2Y6vfxPYeZ9r6YSeJ X-Google-Smtp-Source: AGHT+IH0ATXCKHB2pZsvh7ohmnVHnvM57cgC3C01Zld9f6e2nQaPGNK5+R25lkMDKZF8ZwjueRBqIQ== X-Received: by 2002:a05:600c:a005:b0:412:ef3c:f86e with SMTP id jg5-20020a05600ca00500b00412ef3cf86emr4006841wmb.17.1709775266933; Wed, 06 Mar 2024 17:34:26 -0800 (PST) Received: from localhost ([137.220.120.171]) by smtp.gmail.com with ESMTPSA id r18-20020adfca92000000b0033dcc0d1399sm18854228wrh.25.2024.03.06.17.34.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 17:34:26 -0800 (PST) From: luca.boccassi@gmail.com To: Ferruh Yigit Cc: =?UTF-8?q?Morten=20Br=C3=B8rup?= , Chengwen Feng , Hemant Agrawal , dpdk stable Subject: patch 'rawdev: fix calloc parameters' has been queued to stable release 22.11.5 Date: Thu, 7 Mar 2024 01:30:55 +0000 Message-Id: <20240307013159.1735343-38-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240307013159.1735343-1-luca.boccassi@gmail.com> References: <20240307013159.1735343-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/09/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/477478f17966c64992bedbff1c493b803d744ec8 Thanks. Luca Boccassi --- >From 477478f17966c64992bedbff1c493b803d744ec8 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Wed, 24 Jan 2024 18:54:00 +0000 Subject: [PATCH] rawdev: fix calloc parameters MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 37ff33833b6b8932bfbc8e149d386ef23ccdc54e ] gcc [1] generates warning [2] about calloc usage, because calloc parameter order is wrong, fixing it by replacing parameters. [1] gcc (GCC) 14.0.0 20240108 (experimental) [2] Compiling C object .../lib/librte_rawdev.a.p/rawdev_rte_rawdev.c.o ../lib/rawdev/rte_rawdev.c: In function ‘handle_dev_dump’: ../lib/rawdev/rte_rawdev.c:659:29: error: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Werror=calloc-transposed-args] 659 | buf = calloc(sizeof(char), RTE_TEL_MAX_SINGLE_STRING_LEN); | ^~~~ Fixes: e915d404eb72 ("rawdev: support telemetry dump rawdev") Signed-off-by: Ferruh Yigit Acked-by: Morten Brørup Reviewed-by: Chengwen Feng Reviewed-by: Hemant Agrawal --- lib/rawdev/rte_rawdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rawdev/rte_rawdev.c b/lib/rawdev/rte_rawdev.c index 891e79dcd7..dcebe4f653 100644 --- a/lib/rawdev/rte_rawdev.c +++ b/lib/rawdev/rte_rawdev.c @@ -656,7 +656,7 @@ handle_dev_dump(const char *cmd __rte_unused, if (!rte_rawdev_pmd_is_valid_dev(dev_id)) return -EINVAL; - buf = calloc(sizeof(char), RTE_TEL_MAX_SINGLE_STRING_LEN); + buf = calloc(RTE_TEL_MAX_SINGLE_STRING_LEN, sizeof(char)); if (buf == NULL) return -ENOMEM; -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-07 01:05:38.226169715 +0000 +++ 0038-rawdev-fix-calloc-parameters.patch 2024-03-07 01:05:34.754939082 +0000 @@ -1 +1 @@ -From 37ff33833b6b8932bfbc8e149d386ef23ccdc54e Mon Sep 17 00:00:00 2001 +From 477478f17966c64992bedbff1c493b803d744ec8 Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 37ff33833b6b8932bfbc8e149d386ef23ccdc54e ] + @@ -26 +27,0 @@ -Cc: stable@dpdk.org @@ -37 +38 @@ -index 474bdc9540..4f8897b639 100644 +index 891e79dcd7..dcebe4f653 100644