From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86F6B43C60 for ; Thu, 7 Mar 2024 02:34:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 804AB42EEB; Thu, 7 Mar 2024 02:34:44 +0100 (CET) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mails.dpdk.org (Postfix) with ESMTP id A760642E64 for ; Thu, 7 Mar 2024 02:34:42 +0100 (CET) Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-33d153254b7so166493f8f.0 for ; Wed, 06 Mar 2024 17:34:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709775282; x=1710380082; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6SOc1T3JO5FquQtpZJzTq+H4hmu/8Nc6P1epd6+0y5A=; b=XD4k3FcOLBFGtqIctL5lwRJPvuJN0jHyLBhycs1PG4q9gvPVd9pSij+8AhEFDR6HrH dRdCNNuSZI73nXyZ4Swv5hDdbqIiYN6wh5PlaVG3fvLvdrJorPctiiiqBmUSOVsDpU0q UW9EeiFDv1T146ndbEGKXQhP3JIVCKwu61NZ95Ng8+71aG0ofcuT1vAS63B9PAs7B7H6 KOZaD6T4fChtxi+qhmVFOlXdXTzV7FN0QgyrM3j3scEbdrULz4sm/aOwOqWPeRqUwYbN Dzc+lJWs+nykuSfegdxcATwUa0qwT4yUPxjE0cCBVlMlrlAGuv1tkocneFBcNpRVg7Nb F0AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709775282; x=1710380082; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6SOc1T3JO5FquQtpZJzTq+H4hmu/8Nc6P1epd6+0y5A=; b=o2a8KKm7ouYEYqOMuqq5JZLfZVy59IjXRH/c0oMAyNRoJaKu/qR2m8Dabc95+qZ7BS Z64WBQxEnk8EtJDrtvWVaA0TDpt+LIw5RCoTvhyD84Kj2IPfAE2x8EadD8eK9VjcREya KQVGd4m3FNm+JBU+ZNKFsuFEVbL6tuDwowy3sc1WMkGSLGFAvhiS6QeJFAz9N5+YH/YK vt6v4y01bNn1rlwOXGzyBRUoZ0tmAvLHwSP1/KpwlHkte7S/UZVsUARboTEMlRspnn1/ +Ymbfkd9PLOyCYkcVTUl1ETZncyiAI+TIMyWb5ujKL+6sa0dhqQOyNmCHNaeU9Rfpihs qBmA== X-Gm-Message-State: AOJu0YzYnC67Y9cBUdGnLu5nxCyDY86Q0bMVnNpSd8/GbrTNjE3dZ5qq yUPsIIlQIRI4IoFrdnYGK8mzUJjQ1PkKfaimT3JgXoBGfYtl2av1zuP5l0Gx X-Google-Smtp-Source: AGHT+IGpFURKNbJGY4/FLQhoy/J6k5GnkBkO9w+pPLEpwtpPELCBGU9esaKu/5kApu9DIFW2yX07xw== X-Received: by 2002:a5d:4ec7:0:b0:33d:3098:3ccf with SMTP id s7-20020a5d4ec7000000b0033d30983ccfmr10828744wrv.33.1709775282327; Wed, 06 Mar 2024 17:34:42 -0800 (PST) Received: from localhost ([137.220.120.171]) by smtp.gmail.com with ESMTPSA id x3-20020a5d6503000000b0033e206a0a7asm15654383wru.26.2024.03.06.17.34.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 17:34:41 -0800 (PST) From: luca.boccassi@gmail.com To: Bruce Richardson Cc: dpdk stable Subject: patch 'build: fix linker warnings about undefined symbols' has been queued to stable release 22.11.5 Date: Thu, 7 Mar 2024 01:30:59 +0000 Message-Id: <20240307013159.1735343-42-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240307013159.1735343-1-luca.boccassi@gmail.com> References: <20240307013159.1735343-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/09/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/00a4d8525cb1f28e6472d3f204ec136dada09e4b Thanks. Luca Boccassi --- >From 00a4d8525cb1f28e6472d3f204ec136dada09e4b Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Wed, 10 Jan 2024 15:01:03 +0000 Subject: [PATCH] build: fix linker warnings about undefined symbols [ upstream commit 51c9428dca9fad10bd60ca668ffdf78e4a801e2f ] The default behaviour of "ld.lld" has changed, so it now prints out warnings about entries in the version.map file which don't exist in the current build. Since we use our version.map file simply to filter out the functions we don't want made public, we include in it all functions across all OS's and builds that we want public if present. This causes these ld warnings to be emitted, e.g. on BSD, which is missing functionality found on Linux. For example: * hpet functions in EAL * regexdev enqueue and dequeue burst * eventdev event_timer functions Easiest solution, without major rework of how we use our version.map files, and without dynamically generating them per-build, is to pass the --undefined-version flag to the linker, to restore the old behaviour. Signed-off-by: Bruce Richardson --- config/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/config/meson.build b/config/meson.build index 5f6320ab19..a5445d5fc4 100644 --- a/config/meson.build +++ b/config/meson.build @@ -146,6 +146,9 @@ dpdk_conf.set('RTE_ARCH_32', cc.sizeof('void *') == 4) if not is_windows add_project_link_arguments('-Wl,--no-as-needed', language: 'c') + if cc.has_link_argument('-Wl,--undefined-version') + add_project_link_arguments('-Wl,--undefined-version', language: 'c') + endif endif # use pthreads if available for the platform -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-07 01:05:38.551707622 +0000 +++ 0042-build-fix-linker-warnings-about-undefined-symbols.patch 2024-03-07 01:05:34.774939507 +0000 @@ -1 +1 @@ -From 51c9428dca9fad10bd60ca668ffdf78e4a801e2f Mon Sep 17 00:00:00 2001 +From 00a4d8525cb1f28e6472d3f204ec136dada09e4b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 51c9428dca9fad10bd60ca668ffdf78e4a801e2f ] + @@ -23,2 +24,0 @@ -Cc: stable@dpdk.org - @@ -31 +31 @@ -index a9ccd56deb..65662c5de3 100644 +index 5f6320ab19..a5445d5fc4 100644 @@ -34 +34 @@ -@@ -188,6 +188,9 @@ dpdk_conf.set('RTE_ARCH_32', cc.sizeof('void *') == 4) +@@ -146,6 +146,9 @@ dpdk_conf.set('RTE_ARCH_32', cc.sizeof('void *') == 4)