From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B775743C60 for ; Thu, 7 Mar 2024 02:34:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B041A42EED; Thu, 7 Mar 2024 02:34:45 +0100 (CET) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mails.dpdk.org (Postfix) with ESMTP id 3740742E64 for ; Thu, 7 Mar 2024 02:34:44 +0100 (CET) Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-33e2774bdc7so265177f8f.0 for ; Wed, 06 Mar 2024 17:34:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709775284; x=1710380084; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SEUfLMNwWHFPjJwwXgMXepCDnGlewAgUVUxU+hN1c14=; b=ATHzU6SUvuIrrfsUPB+YQPTH2z8pWIH+KTbTUhavH2ioot71NAIv0GupZVbfYpmR/o IU+CsYa52abp9QT7pKxUIF3jAPb6UquQfd00ywAJDCkEFvrwKO/6C0QiPuykIqzmO3+2 OL/yjPXcXuWAefw6NLlJHxKkhOP6rQgVifyoOFfBbc58NQB3v/BtaeC7X+y6PDCzbsIs ZyeVdKy7rAgS593iSVpRgVvGbk5fumkZLzS7D5Jo4ckKO6+6UbkzyeM6kudG4yFy4xfd gXbj/8tY1JmHHOf/9oJ/JXXmCPREvQqLpg4LBX8aNrPg6GvnLL+O+VPKk1z11qF7hbij wGRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709775284; x=1710380084; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SEUfLMNwWHFPjJwwXgMXepCDnGlewAgUVUxU+hN1c14=; b=sUFG7j5/rF1VFrucJtf4yYmRhqnQGkGSXA/T8Z38bmAG9WOGI18ge8+LUdPAfRjkLQ ZrwfzgOcAX85VX4zpc5thS2sTGwbSZxLphhV6w50/W+BLsCw0f7hOne5xRyvpR+HbJ7V lgSaamCYz0a0qyFV5a+d8yA8S9D7OTYHlw19GnYBjhsrMnXrgPPkvYeK6g0u4ykvf/B8 oP50ijAvTBBHe0t3QW7gWbl9pvzX+/rRlP4Q5Cwnd2jbhuTrhgvAqk5FQYBrtxKoYneN j6ctNJMQy49w/TyrBjctustK3Cd0GVF/j9otdZvkzWdHMrq7yaDs7XjEI7Tm1DPltpIA yenA== X-Forwarded-Encrypted: i=1; AJvYcCUIbw6m3dGds7n/pYF4eEVaUmlU238cXKbOziJJnAAFgn98ixj/CgCBr0yI+QG6tZd4fOWD+CMwujDkHreJyDc= X-Gm-Message-State: AOJu0YzPNGzGKlRTeUtE3VhdFGYmKR9IxISjDaD8SD1nBbTECC653xXB 1hBskP7SNV0vUYlqZATv3KCH3KOegUTQ9tFv9cetU/ogGolXI8F45J0iRBpF X-Google-Smtp-Source: AGHT+IHZdpyb1zp5y04qph9MtZu9DpMAdfN3JAk+B3HVqCz2qJlFQU/icjo7GVettmT4Xqo1fNFyzA== X-Received: by 2002:adf:eb11:0:b0:33b:5f1d:5ef4 with SMTP id s17-20020adfeb11000000b0033b5f1d5ef4mr12099636wrn.1.1709775283804; Wed, 06 Mar 2024 17:34:43 -0800 (PST) Received: from localhost ([137.220.120.171]) by smtp.gmail.com with ESMTPSA id n13-20020a5d4c4d000000b0033cfa00e497sm18826478wrt.64.2024.03.06.17.34.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 17:34:43 -0800 (PST) From: luca.boccassi@gmail.com To: Robin Jarry Cc: David Marchand , Bruce Richardson , dpdk stable Subject: patch 'build: link static libs with whole-archive in subproject' has been queued to stable release 22.11.5 Date: Thu, 7 Mar 2024 01:31:00 +0000 Message-Id: <20240307013159.1735343-43-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240307013159.1735343-1-luca.boccassi@gmail.com> References: <20240307013159.1735343-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/09/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/0ceab70d2cd1c9c67b01825ae360a2a5bcb8ddf4 Thanks. Luca Boccassi --- >From 0ceab70d2cd1c9c67b01825ae360a2a5bcb8ddf4 Mon Sep 17 00:00:00 2001 From: Robin Jarry Date: Mon, 29 Jan 2024 13:47:17 +0100 Subject: [PATCH] build: link static libs with whole-archive in subproject [ upstream commit cafb10b3e4a73750c26b3d5e00df48caa93a997b ] When DPDK is used as a subproject, declare static libs to be linked with -Wl,--whole-archive along with the drivers. This is already done this way in pkg-config. Fixes: f93a605f2d6e ("build: add definitions for use as Meson subproject") Signed-off-by: Robin Jarry Tested-by: David Marchand Acked-by: Bruce Richardson --- buildtools/subproject/meson.build | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/buildtools/subproject/meson.build b/buildtools/subproject/meson.build index 3192efaa40..322e01c029 100644 --- a/buildtools/subproject/meson.build +++ b/buildtools/subproject/meson.build @@ -8,8 +8,7 @@ if get_option('default_library') == 'static' dependencies: dpdk_static_lib_deps, # static library deps in DPDK build don't include "link_with" parameters, # so explicitly link-in both libs and drivers - link_with: dpdk_static_libraries, - link_whole: dpdk_drivers, + link_whole: dpdk_static_libraries + dpdk_drivers, link_args: dpdk_extra_ldflags) else dpdk_dep = declare_dependency( -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-07 01:05:38.634789053 +0000 +++ 0043-build-link-static-libs-with-whole-archive-in-subproj.patch 2024-03-07 01:05:34.774939507 +0000 @@ -1 +1 @@ -From cafb10b3e4a73750c26b3d5e00df48caa93a997b Mon Sep 17 00:00:00 2001 +From 0ceab70d2cd1c9c67b01825ae360a2a5bcb8ddf4 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit cafb10b3e4a73750c26b3d5e00df48caa93a997b ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org