From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4B5C43C60 for ; Thu, 7 Mar 2024 02:36:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C682D42F01; Thu, 7 Mar 2024 02:36:59 +0100 (CET) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mails.dpdk.org (Postfix) with ESMTP id 56E5042E64 for ; Thu, 7 Mar 2024 02:36:56 +0100 (CET) Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4130e293686so2323315e9.3 for ; Wed, 06 Mar 2024 17:36:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709775416; x=1710380216; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q+I55EBJsZehv2IWGvAqFNvuKXi1waVh1cfDYtvZfFQ=; b=iq18QPTpErCWm1OyPfqZ+skwz5hKa16Moiychp8h8kM8JTA+YtzlMQQdAFZbDiqKKt QWEXlZpxMFxGDo7RCSfM++BqwUY7uGYFNkB6mvRGx5Xip4VFTcsXYgoAC7QnOiSk2X1f dYgzRvwv3cAC+EcD2GMUXciMotciKHZmcbPV4Hc2GPQZPIxuyzZZjHVZE1OxyS+TyyOQ uzl7/6bBla+zXKb7L6uqRb8q+3ys5woCFbFcUb5UIUXP8/QMZjac3pOy80kTktQ5Seju 1MSKrtK/WHlbj/29Oow2Og61x9M6Fn6pOiS2iifWjXthsy5ig1j9dtyruU+nCEeUmxYo DIAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709775416; x=1710380216; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q+I55EBJsZehv2IWGvAqFNvuKXi1waVh1cfDYtvZfFQ=; b=TTCF+NBBoMzoA/bKiFsYpT2Ym5jY9JSKrCf9B0iyUZEh5P9ZUgI1i7sWB7p7/aQumm xDNE5s0I5QVuHoLJR/mr8vPDvYAXODd+Tn6UxjPYakL+KNd0ebM6/3AQmGaH8gPsxrXG GbBaKMLtRuupCRp7v8lV7pIeh9fweNQqzSTSYC9hQfm84SJQ0JvrixK0AlW9HNZW3wj5 l4JVQezYtL4kd0TgytVBWE25UTBTP4U985uoEeW6qjNeQQq88CVa7TAc5zcrbJNmoK04 OXkhwJCo0ERl3RGCqlZe6i2EBhy40sF9jKA//Lb1tFXLW+GSf9D3eYt5Pl1GDOapx10G wlzQ== X-Forwarded-Encrypted: i=1; AJvYcCVdKxtmfbMbAob7Dl7dsffZaFeywbxyAsKOheY/4KyOyTwOy1b4+fPe7M7Wrlt8e4twfOOauwEZCANDUVEFYqo= X-Gm-Message-State: AOJu0Ywrlk7Pno/G1xF6X8B70Y1ifUxkuogv0Eh0n7HoQXPv+mJ5U4C7 +CDGwWAL8SanfyKI2F4PLfYNsD+J+aaxO8/WxDP0kkBU3jkDyA11fjdD6pp3074= X-Google-Smtp-Source: AGHT+IH012ScgEHDZ8VSjReh2LyVkgAlRriukSjp3GEzvwwlfda7vXjGr5iTzSB9S5bozf/thmL0Kg== X-Received: by 2002:a05:600c:3582:b0:412:ee8e:2f1c with SMTP id p2-20020a05600c358200b00412ee8e2f1cmr4204725wmq.1.1709775415904; Wed, 06 Mar 2024 17:36:55 -0800 (PST) Received: from localhost ([137.220.120.171]) by smtp.gmail.com with ESMTPSA id x6-20020a05600c21c600b00412c8117a34sm847649wmj.47.2024.03.06.17.36.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 17:36:55 -0800 (PST) From: luca.boccassi@gmail.com To: Wathsala Vithanage Cc: Liangxing Wang , Ruifeng Wang , Ferruh Yigit , dpdk stable Subject: patch 'net/memif: fix extra mbuf refcnt update in zero copy Tx' has been queued to stable release 22.11.5 Date: Thu, 7 Mar 2024 01:31:39 +0000 Message-Id: <20240307013159.1735343-82-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240307013159.1735343-1-luca.boccassi@gmail.com> References: <20240307013159.1735343-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/09/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/8603dea8c566f2f18f6381cc908269f699aa2e64 Thanks. Luca Boccassi --- >From 8603dea8c566f2f18f6381cc908269f699aa2e64 Mon Sep 17 00:00:00 2001 From: Wathsala Vithanage Date: Wed, 14 Feb 2024 00:36:16 +0000 Subject: [PATCH] net/memif: fix extra mbuf refcnt update in zero copy Tx [ upstream commit aa3e97fcb55d7b68fef864aa76078bdae375ad3d ] The refcnt update of stored mbufs in memif driver is redundant since those mbufs are only freed in eth_memif_tx_zc(). No other place can free those stored mbufs quietly. By removing this redundant update single core dpdk memif performance can be improved by 7.5%. testpmd stats on Arm Neoverse N1 (Ampere Altra) +-----------------------------+-----------------------+ | | With refcnt update | Without refcnt update | +--------+--------------------+-----------------------+ | Rx-pps | 2748851 | 2955487 | +--------+--------------------+-----------------------+ | Tx-pps | 2748812 | 2955436 | +--------+--------------------+-----------------------+ Fixes: 43b815d88188 ("net/memif: support zero-copy slave") Signed-off-by: Liangxing Wang Signed-off-by: Wathsala Vithanage Reviewed-by: Ruifeng Wang Acked-by: Ferruh Yigit --- .mailmap | 1 + drivers/net/memif/rte_eth_memif.c | 6 ------ 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/.mailmap b/.mailmap index 1d72c6c754..e4c3ff0024 100644 --- a/.mailmap +++ b/.mailmap @@ -1451,6 +1451,7 @@ Walter Heymans Wang Sheng-Hui Wangyu (Eric) Waterman Cao +Wathsala Vithanage Weichun Chen Wei Dai Weifeng Li diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c index 3b83a5a8bb..86b821ac5c 100644 --- a/drivers/net/memif/rte_eth_memif.c +++ b/drivers/net/memif/rte_eth_memif.c @@ -261,8 +261,6 @@ memif_free_stored_mbufs(struct pmd_process_private *proc_private, struct memif_q cur_tail = __atomic_load_n(&ring->tail, __ATOMIC_ACQUIRE); while (mq->last_tail != cur_tail) { RTE_MBUF_PREFETCH_TO_FREE(mq->buffers[(mq->last_tail + 1) & mask]); - /* Decrement refcnt and free mbuf. (current segment) */ - rte_mbuf_refcnt_update(mq->buffers[mq->last_tail & mask], -1); rte_pktmbuf_free_seg(mq->buffers[mq->last_tail & mask]); mq->last_tail++; } @@ -707,10 +705,6 @@ memif_tx_one_zc(struct pmd_process_private *proc_private, struct memif_queue *mq next_in_chain: /* store pointer to mbuf to free it later */ mq->buffers[slot & mask] = mbuf; - /* Increment refcnt to make sure the buffer is not freed before server - * receives it. (current segment) - */ - rte_mbuf_refcnt_update(mbuf, 1); /* populate descriptor */ d0 = &ring->desc[slot & mask]; d0->length = rte_pktmbuf_data_len(mbuf); -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-07 01:05:41.720731803 +0000 +++ 0082-net-memif-fix-extra-mbuf-refcnt-update-in-zero-copy-.patch 2024-03-07 01:05:34.946943157 +0000 @@ -1 +1 @@ -From aa3e97fcb55d7b68fef864aa76078bdae375ad3d Mon Sep 17 00:00:00 2001 +From 8603dea8c566f2f18f6381cc908269f699aa2e64 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit aa3e97fcb55d7b68fef864aa76078bdae375ad3d ] + @@ -21 +22,0 @@ -Cc: stable@dpdk.org @@ -33 +34 @@ -index e040e2219b..b2d0fc0729 100644 +index 1d72c6c754..e4c3ff0024 100644 @@ -36 +37 @@ -@@ -1518,6 +1518,7 @@ Walter Heymans +@@ -1451,6 +1451,7 @@ Walter Heymans @@ -45 +46 @@ -index 6f45a00172..18377d9caf 100644 +index 3b83a5a8bb..86b821ac5c 100644 @@ -48 +49 @@ -@@ -265,8 +265,6 @@ memif_free_stored_mbufs(struct pmd_process_private *proc_private, struct memif_q +@@ -261,8 +261,6 @@ memif_free_stored_mbufs(struct pmd_process_private *proc_private, struct memif_q @@ -57 +58 @@ -@@ -825,10 +823,6 @@ memif_tx_one_zc(struct pmd_process_private *proc_private, struct memif_queue *mq +@@ -707,10 +705,6 @@ memif_tx_one_zc(struct pmd_process_private *proc_private, struct memif_queue *mq