From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90F2D43C60 for ; Thu, 7 Mar 2024 02:37:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 02DB442F2F; Thu, 7 Mar 2024 02:37:35 +0100 (CET) Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mails.dpdk.org (Postfix) with ESMTP id 3B00D42F2D for ; Thu, 7 Mar 2024 02:37:33 +0100 (CET) Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-33d568fbf62so132699f8f.3 for ; Wed, 06 Mar 2024 17:37:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709775453; x=1710380253; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bY7LpeHNTLD8RkSlVBt6OrXJ/PWYZ4BJfEEK0MCBZ9g=; b=GTsLWOEiG/ihum/OAl5f/TCdKVTiIS8hjt0QE3SS981v9cEVJkhuw0YJ2fCqBhFalV JdtZChJrP4851k3hm0DKyiWqtczG/yZDVo94iXsNE9G7tHrpxcWnf49h8VJZoS1OueXG cFfBpNkyKWYY/fXlSTzCMBCzfwq8HgdnLms5rN5Te4YJ9ukQ1bhdQNIK+JPaWq++RmIr yhZhf5ECwS869iVvYCZLwD/7+czQpj3ydcahzI8Y3oYcNHOylQ6ECanu0Q4X+wTS3KzS O4doHGFw3qu2sgrg7wc6l9OpO8xXOe0ewEOHyqTsIWbtbTm3nkLTpMvF49I8ptmoANtI YF4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709775453; x=1710380253; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bY7LpeHNTLD8RkSlVBt6OrXJ/PWYZ4BJfEEK0MCBZ9g=; b=nU5XqRaZy4SUaGey3dKPvnY4H3tBBl+qduMkSCdoUs9bMHoJXLurDf0lIqJmS/8eiv yTy9DL0wqmYCNJqROuA+4VNS1dmo38ET9Kq0CYVGcmv1+WRXHd75cG/XUvXRmf1p+S3W Ggo0190c8Mt7iMG/dbzBrdUyXduaStNALsfoNIGUCsmM3sxkHWleDVX65r1wSTw2BvL6 cpAniYiQqt2lrlwvb77p6LeCO/yE1P1//QhmDqzoHV2qDYbu3qJIfUHRg/H+6I4XCl7r xt1aUmlMe5BRcJ/+B1KAOqoJ91v1z+YdwqWg8ixB99ZaYbeihly/3Nu9emAQltaPNcN/ EvDQ== X-Forwarded-Encrypted: i=1; AJvYcCWhpZhWRlojSrZ3GhdYSFp5HpKvUE+cr/CLsarvIXVir81Dq7HiZyKQmHrUfGbaPBUjgYX7LxpplCd9Ps39FjU= X-Gm-Message-State: AOJu0Yx45wIkWj94IZMfwS5qaKyy+1P+6AmG1CKQCPFwNOuYuQg4jhP1 ephb/qNfHRnoDXOb8zk/P0slYyLZr9ycNDwRv5WBS4FqRhM2BeCt X-Google-Smtp-Source: AGHT+IE3xe9KI7h0fRUfG4LSaLpDeDMmkmktPK7svf+S2aQVVw4AvqNO+tluJk2B+T96kpvkmkvfuw== X-Received: by 2002:adf:9ccb:0:b0:33e:1ee1:ef92 with SMTP id h11-20020adf9ccb000000b0033e1ee1ef92mr12674089wre.67.1709775453021; Wed, 06 Mar 2024 17:37:33 -0800 (PST) Received: from localhost ([137.220.120.171]) by smtp.gmail.com with ESMTPSA id ck4-20020a5d5e84000000b0033e2b9f647asm13244303wrb.31.2024.03.06.17.37.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 17:37:32 -0800 (PST) From: luca.boccassi@gmail.com To: Michael Baum Cc: Matan Azrad , dpdk stable Subject: patch 'net/mlx5: fix jump action validation' has been queued to stable release 22.11.5 Date: Thu, 7 Mar 2024 01:31:52 +0000 Message-Id: <20240307013159.1735343-95-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240307013159.1735343-1-luca.boccassi@gmail.com> References: <20240307013159.1735343-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/09/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/53008878773f18149eefcabe3d3eb8f442c4b11c Thanks. Luca Boccassi --- >From 53008878773f18149eefcabe3d3eb8f442c4b11c Mon Sep 17 00:00:00 2001 From: Michael Baum Date: Mon, 27 Nov 2023 14:42:59 +0200 Subject: [PATCH] net/mlx5: fix jump action validation [ upstream commit 9c289272ae692bd03d1dc9726ef19785beedd313 ] Currently PMD doesn't allow to jump to the same group in order to avoid dead loop. But this also prevent experienced user to create flow with less Hops in order to have better performance. For example, rules in [1] should have better performance then [2]. Furthermore, this protection will not really prevent dead loop, i.e [3]. So just remove this protection and user should take the responsibility to avoid dead loop. This patch enables jumping to the same group. [1]: flow create 0 group 1 priority 1 pattern eth / ipv4 / udp / gtp / end actions raw_decap / raw_encap / jump group 1 / end flow create 0 group 1 priority 0 pattern eth / ipv4 src is 1.0.0.1 / tcp / end actions queues index 1 / end [2]: flow create 0 group 1 priority 0 pattern eth / ipv4 / udp / gtp / end actions raw_decap / raw_encap / jump group 2 / end flow create 0 group 2 priority 0 pattern eth / ipv4 src is 1.0.0.1 / tcp / end actions queues index 1 / end [3]: flow create 0 group 1 pattern eth / end actions jump group 2 / end flow create 0 group 2 pattern eth / end actions jump group 1 / end Fixes: f78f747f41d0 ("net/mlx5: allow jump to group lower than current") Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_flow_dv.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 5c2af50fe5..077306f048 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -5207,13 +5207,6 @@ flow_dv_validate_action_jump(struct rte_eth_dev *dev, &grp_info, error); if (ret) return ret; - if (attributes->group == target_group && - !(action_flags & (MLX5_FLOW_ACTION_TUNNEL_SET | - MLX5_FLOW_ACTION_TUNNEL_MATCH))) - return rte_flow_error_set(error, EINVAL, - RTE_FLOW_ERROR_TYPE_ACTION, NULL, - "target group must be other than" - " the current flow group"); if (table == 0) return rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION_CONF, -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-07 01:05:42.756808229 +0000 +++ 0095-net-mlx5-fix-jump-action-validation.patch 2024-03-07 01:05:35.030944940 +0000 @@ -1 +1 @@ -From 9c289272ae692bd03d1dc9726ef19785beedd313 Mon Sep 17 00:00:00 2001 +From 53008878773f18149eefcabe3d3eb8f442c4b11c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 9c289272ae692bd03d1dc9726ef19785beedd313 ] + @@ -35 +36,0 @@ -Cc: stable@dpdk.org @@ -44 +45 @@ -index 52620be262..f881dae6e8 100644 +index 5c2af50fe5..077306f048 100644 @@ -47 +48 @@ -@@ -5484,13 +5484,6 @@ flow_dv_validate_action_jump(struct rte_eth_dev *dev, +@@ -5207,13 +5207,6 @@ flow_dv_validate_action_jump(struct rte_eth_dev *dev,