patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Chaoyong He <chaoyong.he@corigine.com>
To: stable@dpdk.org
Cc: oss-drivers@corigine.com, Chaoyong He <chaoyong.he@corigine.com>
Subject: [PATCH 22.11 1/7] net/nfp: fix resource leak for CoreNIC firmware
Date: Thu,  7 Mar 2024 13:56:33 +0800	[thread overview]
Message-ID: <20240307055639.1626192-2-chaoyong.he@corigine.com> (raw)
In-Reply-To: <20240307055639.1626192-1-chaoyong.he@corigine.com>

[ upstream commit 8b8f116b199e31795ecd5cedb12302f10c0ae5a4 ]

Fix the resource leak problem in the logic of CoreNIC firmware
application.

Fixes: 646ea79ce481 ("net/nfp: move PF functions into its own file")

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
---
 drivers/net/nfp/nfp_ethdev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
index 3b70f5c..77f573c 100644
--- a/drivers/net/nfp/nfp_ethdev.c
+++ b/drivers/net/nfp/nfp_ethdev.c
@@ -920,10 +920,9 @@ nfp_init_app_fw_nic(struct nfp_pf_dev *pf_dev)
 			struct rte_eth_dev *tmp_dev;
 			tmp_dev = app_fw_nic->ports[i]->eth_dev;
 			rte_eth_dev_release_port(tmp_dev);
-			app_fw_nic->ports[i] = NULL;
 		}
 	}
-	nfp_cpp_area_free(pf_dev->ctrl_area);
+	nfp_cpp_area_release_free(pf_dev->ctrl_area);
 app_cleanup:
 	rte_free(app_fw_nic);
 
-- 
2.39.1


  reply	other threads:[~2024-03-07  5:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-07  5:56 [PATCH 22.11 0/7] backport patch series from NFP PMD Chaoyong He
2024-03-07  5:56 ` Chaoyong He [this message]
2024-03-07  5:56 ` [PATCH 22.11 2/7] net/nfp: fix resource leak for flower firmware Chaoyong He
2024-03-07  9:35   ` Luca Boccassi
2024-03-07 11:00     ` Chaoyong He
2024-03-07 11:03       ` Chaoyong He
2024-03-07  5:56 ` [PATCH 22.11 3/7] net/nfp: fix resource leak for exit of CoreNIC firmware Chaoyong He
2024-03-07  5:56 ` [PATCH 22.11 4/7] net/nfp: fix resource leak for exit of flower firmware Chaoyong He
2024-03-07  5:56 ` [PATCH 22.11 5/7] net/nfp: fix device close Chaoyong He
2024-03-07  5:56 ` [PATCH 22.11 6/7] net/nfp: fix device resource freeing Chaoyong He
2024-03-07  5:56 ` [PATCH 22.11 7/7] net/nfp: free switch domain ID on close Chaoyong He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240307055639.1626192-2-chaoyong.he@corigine.com \
    --to=chaoyong.he@corigine.com \
    --cc=oss-drivers@corigine.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).