From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87F0043B74 for ; Thu, 7 Mar 2024 06:57:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 82A3C42D96; Thu, 7 Mar 2024 06:57:07 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2127.outbound.protection.outlook.com [40.107.244.127]) by mails.dpdk.org (Postfix) with ESMTP id A438E402F2 for ; Thu, 7 Mar 2024 06:57:05 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mZTV/IzznAwFs31xqEj8KE8KyADHCYj6MaQfMaR5UYENMiDlaeocTa5PPtt8KSUwiSxx2m7qazZsNqDW+zjDfaPnq4JiwABUPjv7NmFTgG4gwIUsdVWihBnXUcTZ9dmCiOQt/54kFZ4QUIPPJZx05+rJQrCkgE0/7BHyFyWu+RpMZYZ5J7c6379hUP+9+IMFzob7zJNJeBGWO6NWm4+5EMwsEKaaVa5NIxpjOzOGN44HLOEHVvxcOb6+G6N6ALzvWvqu0T00sjjDJJuNH3oPI/z9cVq/yEXcgIRVVC3kowyflKDmBqbd/HUpzGON2duD9xe/XJ34MUJVTJCpvAr2yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ScMCXWQUKlUYclUyVFVAneYNbCClzQsztuHt78x12VQ=; b=OU+dJ9sjZN/E6jDclf76TWLqkvgvXRIqG41R5/HegfHZQNH7ymxNokOKnK2U+xcVEQUev2y5qnwYN7OswkDwibHzlzL3MzSGo/i+eB8HukRwxJNSqQAoSynbbUICsuvIG+ewIbWqDp3/BmDfBL9MqzfrQzozwwPiEi0/ZmVsQYwUR2aL1j53G1ndsQwENs2hMLHAswuZRCobTqsmyw6ncGMwWJKwr2/YbBpYLe2sjNlWMlik8GDt42JqU+OxKqLbu0/PP78tapS3jYRCXDU9Kd2DzwftEmod7adxvhefAv/UT04i/ohos54XGbBmD2Rq5+oehkhWOhnuuwcuskhHRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ScMCXWQUKlUYclUyVFVAneYNbCClzQsztuHt78x12VQ=; b=Hg4OBhhXyBrBXNplGOwbHj1fGiQ8zurdH+RpBdOLGHFAf/n++2MKVd1+2g9AMnpOnga5Up6fvUJ76JMlO+EfV7+9fiUaO5zywtkl4DSH8A04xZ/3vrW0UPXum1hbUnpVqf9hn8sr0DhJXv07iwsPAR0Cfx+jMdA/vSc+mt496tg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by BN0PR13MB4648.namprd13.prod.outlook.com (2603:10b6:408:116::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.26; Thu, 7 Mar 2024 05:57:03 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e%5]) with mapi id 15.20.7339.035; Thu, 7 Mar 2024 05:57:03 +0000 From: Chaoyong He To: stable@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He Subject: [PATCH 22.11 1/7] net/nfp: fix resource leak for CoreNIC firmware Date: Thu, 7 Mar 2024 13:56:33 +0800 Message-Id: <20240307055639.1626192-2-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20240307055639.1626192-1-chaoyong.he@corigine.com> References: <20240307055639.1626192-1-chaoyong.he@corigine.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SJ0PR05CA0097.namprd05.prod.outlook.com (2603:10b6:a03:334::12) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|BN0PR13MB4648:EE_ X-MS-Office365-Filtering-Correlation-Id: ce35ce5c-4f04-4999-b6aa-08dc3e6b6992 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b8eIycjIarsZdBmoYrBalnb5JSh1cfON3YYjmmZ9qcUk9QAt/C/wtGuwNLzIb6ZmrwFucXVLAAkrPekmi0UtgYe8mVSDuwjwsO4T4EHtvyGOcmkVMuvhJkC4pqXpNEFsIzS4zKJebSKdqfqO3S6xpcya5GDE4LVNT+eq6yzljTZe0Z8Bv+GInIr1oXYtZZ7HBenX6lP+bHFNL3QWdAtfYoxvvRUGZZ+GuROjmNzf2NIbj8E9X9GcjmmOk5dqjSRTlXI0yNNLWCdepGDbTHiU0AR1hKyxsZbQIs/hHd1eHV98RDDZ9jWXrVi3DHH8MP08LEdiMJ6wbMYZWSF64pE+QRk+zf1oG4mmHSk5pEWoFGPXJ8PX+jVTgrryeNp7pHuOhSlVjryQVxAEa4mqEwpNRlSBIr/CwIXBVmUnfmkSjEJopwgTpRMGFPCw53HNaLoHgqj3Dq2OufSYtJyTXnDoyODKlYooMqxMpN01rYJlsK6HusT07vLELw2EAB4WGMbrWDkv8fkctXgfIW/nvSOmyEk4bvDZ3pN01VzxQIKakrtluQMmXWMdOXq54z8Tojpb2hqquRRvAa+7mwgfIaxTF/39t/yHR/d4pxuyALcduugQE+5xrWLBQeYPCouBOFdyNo0mvxofrNcZ/3w/p4NAzhjie/5pqDMHqxl54ZyVe23zGVEfwFEEvNce9of4VcK8be0Z38W8peI56wmckWdcZg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(38350700005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Xwo0SHDskD4cuG/Qpd2HN1KcdfHrgDymURwXAhG5akAgoA6h35IlfdCYO1v0?= =?us-ascii?Q?PeLM2nGURe7XlbH/8AJe2e8tsGHiz3fHAO2awQyD1o+NwBqMBjVHT+iNLlX1?= =?us-ascii?Q?BP9c5YbAfJFsKxZunAmSvkHOs/TCOWgsswgC6A08JcAX8QRmvjxgg0G+dQcY?= =?us-ascii?Q?NItN1Csv8qzxTyd6lj8uaNGXXvgwWO1w9OTTXLHqDzWnxOXvPK4YJQRXsOFD?= =?us-ascii?Q?+pyCjWeYPQA2bnKEYXUmmg+Mdj2dKXDPjM7bxguCJOE+B3DWKFpaXlRNGB2v?= =?us-ascii?Q?bhRYbeiTjav7/lYbSi1Q+O9/hFjZuL+FPf49fedHn7oDggs7LPXdV8ylNJva?= =?us-ascii?Q?4qvDT10fEPQpfWjwMMmvMGVqHLmvXTkiNrYOJz8kdeIy3ZDebjRv7kIPrjjt?= =?us-ascii?Q?WPA1NeqO8Sa3sRm6AyL4wzmIE1WFgrH5abIsELmzMYLlkNh3UgzJEExQgxc8?= =?us-ascii?Q?Mphlagp07Pjhw6YoO1J7e0g2hO6qPIQcne+D1HZsAF8YHqfWuXC0A/7V/fPG?= =?us-ascii?Q?uyRlbzvsDR9bWQkvcSOXj8TjR6sYppxHHHB2x1rM2O11zejywutrBqB5RT1s?= =?us-ascii?Q?NG/hy4WmfG9Tct9Hyltx4kuGt/qWaAGV83QjwmyI9goPtJ5jZHHXuInuZsMs?= =?us-ascii?Q?6Otx0Zi5WbrUKYP+JpAfwhqCpF+FR7zZ67ChlBtmw4TtqFyPLsTo/4TO+p2G?= =?us-ascii?Q?WFVT6C8CUp6+ZdA37ZcDy1UGT5XgyXVG8Puh336Z7CmGOy84V9djgEj5Smlm?= =?us-ascii?Q?PjWOYsK8rKAOMlkV3lRQ/Eg3XeM62qS5dSb+4LQL6BjVHqgkptS5oRLwSuHe?= =?us-ascii?Q?/MHOux6p7ZhHWfoual+4EXRXoPoTIq+yzpNSLgtP5Iy48UuhrtsGrimeqtcK?= =?us-ascii?Q?EZP6iQ88ieBLCdPezYcXIl/tCb6sXLzR786GCxIHexUbDO4xhnkJisuL/hkv?= =?us-ascii?Q?Cqpm6El3h98w00MXD+VWrTPeWZ8DCXsbPFNl7rUuzyWbAVrRVJwkSAsLTasZ?= =?us-ascii?Q?j4zQtt5/NlSJDTXNRlcj8xSyKJjKyADNTm/GhgoMGrWC4kg1gZ3bdkpfRQoq?= =?us-ascii?Q?kexPmiqkc9eqtuHCL1fDN/uTil90p+rJLyyuYh/TRONBSREXeyeRLfw3nPEb?= =?us-ascii?Q?WtR1+LwljRL8zbxV8Jn7XPk+SbcbWB6xPz6GDwIZMavas/wZiZRLnisEiR65?= =?us-ascii?Q?C1l3qZOa5xSfiIgH637Nb+ysKO7cGirx2ZFV2DXFl4b8BneFEboSKO/qBK7n?= =?us-ascii?Q?1ZrqjGj6ggJmx1KdlbdLaTYUIJTXGRkM251vniD+yIFht40Ch+m3Ag1qYU8T?= =?us-ascii?Q?R6xmRz21KeCgveEgsrEJC1fUJ45tDRvoR0kZOauzkAFB05D9cdsD7J6PFkz6?= =?us-ascii?Q?9KfMtTbedNE5ziGN+LHtOwyOIU4liisVrSUNKwSKepzaOoC9tomQbqrAoAhe?= =?us-ascii?Q?/qs8336xNgGEcJRPCCTqQGGama/HIoNIyGNEK1skidaKBmJ4PF1eVK8LbGQ6?= =?us-ascii?Q?GlqLe/FdJWk1YKi0vwus9/vzFX6Cs2rgj+Pds0x06/ojsCmXUiSrgW8GIQbX?= =?us-ascii?Q?f0FroS68eLXnzEQw6hARMqKxTSXD2Aq/s9GXFS06LOxnBaRg50KwjRm2XApG?= =?us-ascii?Q?fA=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce35ce5c-4f04-4999-b6aa-08dc3e6b6992 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 05:57:03.7184 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Xaz67/kFSikaZ5keWrFJnSMHDdu4TF6C+jBOK9YRKLw64Us2pTa8sP/tfRzDSd4WIlp3GeDhwFJf8cOoAu/bWf7KUlU79ioTZAPDEdl3744= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR13MB4648 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org [ upstream commit 8b8f116b199e31795ecd5cedb12302f10c0ae5a4 ] Fix the resource leak problem in the logic of CoreNIC firmware application. Fixes: 646ea79ce481 ("net/nfp: move PF functions into its own file") Signed-off-by: Chaoyong He --- drivers/net/nfp/nfp_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c index 3b70f5c..77f573c 100644 --- a/drivers/net/nfp/nfp_ethdev.c +++ b/drivers/net/nfp/nfp_ethdev.c @@ -920,10 +920,9 @@ nfp_init_app_fw_nic(struct nfp_pf_dev *pf_dev) struct rte_eth_dev *tmp_dev; tmp_dev = app_fw_nic->ports[i]->eth_dev; rte_eth_dev_release_port(tmp_dev); - app_fw_nic->ports[i] = NULL; } } - nfp_cpp_area_free(pf_dev->ctrl_area); + nfp_cpp_area_release_free(pf_dev->ctrl_area); app_cleanup: rte_free(app_fw_nic); -- 2.39.1