From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46E6943B79 for ; Thu, 7 Mar 2024 06:57:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 40C9C42E02; Thu, 7 Mar 2024 06:57:13 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2106.outbound.protection.outlook.com [40.107.244.106]) by mails.dpdk.org (Postfix) with ESMTP id 3B85C402F2 for ; Thu, 7 Mar 2024 06:57:11 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FLdNWUHz7pzBigRTwp2kARMDJ0iUY38Wy6UUpia/sMDo5SMeAIkUpe3wnJOx+FkHcxEKlF0xkcRk3bMrb1/C15NTu2rVfH9YQl1ycGwJYZZLy+Q7KHsx6nedp96reQ3mSS0AX+tDqa+vTgqc/GnjoOtkHRDoDlmhA8j+ACy5PK2BeNw+yIeVQ07vSyxy8smLJTwfMph3S+q+DxLhtj7Py9GAiJGtfk85RaqeqQ/SakTQ0cGYW9bnI9q+t2OUUmJbB8vQsl3P8ngF1KLT0+RbV3LWkXm7Te5YmBRzS082oXamkRrK5YlfYMd+Ahs7nSEHeT5pZlgDMj8Ro51qwryiRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eji601Ni7Jn/fduULNh7qGa6JdUwlGQ/U9svxapR4A0=; b=B7q2UnI1GH2mBa/sbekRafySH2rY3O1da24/ZZ98szreh3cMESH9+uKgadUaL05uhYXvwy7JMD1Sdlj29+ItcLFCVCTJyA5iU8lWuPmRUYOQiqF8WmqvtVxa8FCltvLLak8qw0+iaVdSG7SmKxkWP389d77/xL61h+MvXDbFSH8l1ytfYLJdP4eAzF4b6QVnT7r7mOf2Mtg7NANWw767/fCA4yhgOmDZf1gUti90fYIt0yhlKi57NNDmVrpOsglrPKRYdoWNkDq5lmvtv4DL+4/J2+g+c2LcoWXudEC9A4ZPjedSWJfAFTKjqAtLD59uOkBcmN+misgecEPLTvUrbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eji601Ni7Jn/fduULNh7qGa6JdUwlGQ/U9svxapR4A0=; b=Fn7YuGOFeq7mC787xNLlVxaJpk1T1XK97EdCHs5VxgrgXpUD3W2eEbUVQYcJ2rea9kLF/mUJsTaXk+iJ83QTFu73LkMpcazKJXSaE6aeaJDrBRFwYgKlE9g8uDU09LpweGc+bAZQLIyCL8KPEmv3s7ql+mACwO64GePKsGiWaRY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by BN0PR13MB4648.namprd13.prod.outlook.com (2603:10b6:408:116::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.26; Thu, 7 Mar 2024 05:57:09 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e%5]) with mapi id 15.20.7339.035; Thu, 7 Mar 2024 05:57:09 +0000 From: Chaoyong He To: stable@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He Subject: [PATCH 22.11 5/7] net/nfp: fix device close Date: Thu, 7 Mar 2024 13:56:37 +0800 Message-Id: <20240307055639.1626192-6-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20240307055639.1626192-1-chaoyong.he@corigine.com> References: <20240307055639.1626192-1-chaoyong.he@corigine.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SJ0PR05CA0097.namprd05.prod.outlook.com (2603:10b6:a03:334::12) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|BN0PR13MB4648:EE_ X-MS-Office365-Filtering-Correlation-Id: 6b059fdc-77b3-4a70-30c5-08dc3e6b6d33 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IYkPjjDxiCuTuYksvdINne0zpxeYYGR8jPwKY+ykMAaFvyASMhOB2AdCCrGEDqdVDImWbBpy1AZfJATZdzVnxCvaGbkcKcPMvVI1J4BRRdN6QAB791CQuBZSa/4W8HRdDbCzlfvQdXTogBa5Kbb+TnBZOOOxk9x4URt6u9VBMhyzGoA4TeOyZG7zeHGpWkUv59p8B5mgyLUxYr1znvgLLQ03QWQXvbeYf/BWd7VUMCe8KkwDjvXoDov6gt3tQshCp+24ATf6YRsAJOCT5hWuGGgf23mdVgG2gp1uG1TS7+IbIfkeV2PAoTEMBCMTVcC6c8KkbfEWBNv9EGF4dNESHa5ic7/R7DX0u2K1/rtSHx77auPG3mnv/4doPhXYg08RotiJz3r/nolrLmOKqvJEnG3yfQSeEMRdM3tbe1kB+7BiP1qyGdzFJAf9oMQ5v+7mKI0ec6lr8ZHRNxCKweCIhip4vHCFIMe8zC6RWcW9QYHTo07kppQ7CJcK5MaH/o1hJJdUOBMWWCZmiOLc5R7XP0tbZg67kv5SAUYSExD8sDOdXMcPB2oM3hz3WB2ZYBeoqWmDja8mDpdnqxeebiSbkZDjCJn+gQvXm2i+5y4tAEe2Bjn4xX3Kva7bdsOcTv0JbUOiCjldQqyjPLsYa3uE/WDd9IVX/OhemfxknAQXHDA6jyY3xD2maInYjsY9Uy2c1NPl19bT749l1kLsPFPXRg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(38350700005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?S3e+qLbl1rB/FEsXX/N5D1V8xkCpNYm57/su1V5gpmmZR7joNg32VvLTOczb?= =?us-ascii?Q?UGbDa1Okjic9yH8rwuaJPMHf5G3dnqa8MNUwZ+5SvqGk8/ygbJcfK64+Hzvb?= =?us-ascii?Q?fdN8HaRtqzsbpmeN675Wv7Lnoo01bxDg5FmzZGiWU3v5yOyIP830GVkaZEg8?= =?us-ascii?Q?rNOlANBq8+EKa83b3crzRvwaGeh96lGhnErB90Ua/H5fCTIL7B+D9v89rkBg?= =?us-ascii?Q?04K5flrygeHw6aUJQbaIbTOyNJWHPLl73H9YP7no6cac4+lPA9L35rl0hN6Q?= =?us-ascii?Q?fPW3FCVBBFJJcpuFW/OizQD452huNO2yCCd5bNdCj1czW4KvvVsOoysK0n5h?= =?us-ascii?Q?ufy93+274m82Wes6mF96jF1JX0cMT7O1XcYHbqqSamGyJqEVWZj/Qb3Blfs4?= =?us-ascii?Q?LXRtgw8W0u/ktxsPfeyBu87jiRrEPCyurZcMVgt1C/HvwKWQl2C+7RX9X3Gb?= =?us-ascii?Q?KUB6ASzxBIN0fk8N6ADyjr+RyUDHrecsUTEke3sbo/8qy3n+6y2kBRX9mySd?= =?us-ascii?Q?uTWC7E+UIhSqmkMzjT5IJbL5FRR+vOnxBTjGs+XJ+tI6bYNulP8Y1KxHCUAV?= =?us-ascii?Q?nxpVFjoRqZgfILYJyvdVfS1zNwiUYPseVAOi+gPJYj9o8jos5dDd1dnEW93O?= =?us-ascii?Q?ImHVRWO26I+z2Cuie/7Nys0sqjQq5FSolUNx+7SHiCYmRNIObXgDDgPkJDas?= =?us-ascii?Q?NfLeNcr4V0TmiqQ7LUQRQcuEv74pBPEU+JMyagDOm+CzKd0odS51nlwaxSAd?= =?us-ascii?Q?xEnNwJPvHGxFy48vsKWQEfdIeicGnXOLNle4a8QydeHexar/t5bdl5XTLPu8?= =?us-ascii?Q?IYXNvMEjdrEPrjRFZUEbV3Q1Owd9vnEDpEoFk64I3h8J+UzRbgW/1dE0wAqL?= =?us-ascii?Q?AnK4Pi/ZlY7069mW2LGeh3fGPmEy8Ev0kRNiP6E9ZF+0xNIv1LT/H84hz6RL?= =?us-ascii?Q?tS92EAnImY+NUzauM+qHSzAG4RPbWgPw4LwUK76dDYxlw9RY9DO2k4taSNXo?= =?us-ascii?Q?fiDgBB2+62d44P+aNQXyEleylVHdWy/RQhK3g3CJdmGsu3Y+p+AvDRXulS4t?= =?us-ascii?Q?ApYj4GHAiK0/QnlT9gGUqR1QpuGWgy48Qgr0GpkmMeQ8Uhcf90mYSfDliK5o?= =?us-ascii?Q?1TijKrJXkUiXaCz2qjZ4Mh18yutz/to1mKo/yKeaxJRHd3GzX92bmRBsEjKE?= =?us-ascii?Q?t0oM4gTpG95qNwfI4AIOrmX5qZ28Qo4+3G92N3GIv+WzeaShlwY8WcQa+YVi?= =?us-ascii?Q?RapFopL5kPjz/PLwlDtpc0y/7ArHjbBmZc1B7lESBNnhz0uUouQ3wvOZfwj3?= =?us-ascii?Q?FBLd0XKJP9WhiC3V1pAHfDOn4cznh/6yIGnTfDmTRcJqPTkuW1IIp0VQsxGT?= =?us-ascii?Q?41Vfgm4ZMtxDASvJsFVyeicuA6SlRZlQpwDg/K5OKSeyePpSebSQUobvNnM8?= =?us-ascii?Q?Ejzx6Ll6AFm5Yiy8HuojDLBs0ra0JQXQeBNDERpSFQxZza79bR7DjwaykV5Z?= =?us-ascii?Q?iLWU+SdzjgW5STJZnVDn5R0I8NyshD4nf3vhsCfgA/wutBFd4AtmxBxLv9aF?= =?us-ascii?Q?K/ESIgqbwMThF3stTeI4jJsJlFXRVMcB+4Qf0nce0SYdFXkwuGvBK5C61gkR?= =?us-ascii?Q?FQ=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b059fdc-77b3-4a70-30c5-08dc3e6b6d33 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 05:57:09.6887 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mMW0KG2JUG75+2JCl05rKxP3ANBVMDCvF5yo2gEY/txXQETX/r7W6XYaNzyiZ5gFMj6iMeEVCybSV/D8VNrWtdcS0x/j/mWSccQFsE14nY8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR13MB4648 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org [ upstream commit 243bbfa0f92f57851ae9369133256a622c79a2a0 ] Close interface use "rte_eth_dev_destroy()" to destroy representor. The "rte_eth_dev_destroy()" will call "rte_eth_dev_release_port()" but the "rte_eth_dev_close()" also calls "rte_eth_dev_release_port()". This will cause Segmentation fault. Remove the "rte_eth_dev_destroy()" in nfp representor close interface. Fixes: 7c596721ae5f ("net/nfp: fix resource leak for flower firmware") Signed-off-by: Chaoyong He --- drivers/net/nfp/flower/nfp_flower_representor.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c index f615f02..61638c8 100644 --- a/drivers/net/nfp/flower/nfp_flower_representor.c +++ b/drivers/net/nfp/flower/nfp_flower_representor.c @@ -547,13 +547,13 @@ nfp_flower_repr_free(struct nfp_flower_representor *repr, { switch (repr_type) { case NFP_REPR_TYPE_PHYS_PORT: - rte_eth_dev_destroy(repr->eth_dev, nfp_flower_repr_uninit); + nfp_flower_repr_uninit(repr->eth_dev); break; case NFP_REPR_TYPE_PF: - rte_eth_dev_destroy(repr->eth_dev, nfp_flower_pf_repr_uninit); + nfp_flower_pf_repr_uninit(repr->eth_dev); break; case NFP_REPR_TYPE_VF: - rte_eth_dev_destroy(repr->eth_dev, nfp_flower_repr_uninit); + nfp_flower_repr_uninit(repr->eth_dev); break; default: PMD_DRV_LOG(ERR, "Unsupported repr port type."); -- 2.39.1