From: David Marchand <david.marchand@redhat.com>
To: stable@dpdk.org
Cc: luca.boccassi@gmail.com, Eelco Chaudron <echaudro@redhat.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: [PATCH 22.11] vhost: fix virtqueue access check in vhost-user setup
Date: Thu, 7 Mar 2024 09:06:04 +0100 [thread overview]
Message-ID: <20240307080604.4028280-1-david.marchand@redhat.com> (raw)
[ upstream commit b3e42d92362bcc75df21c5b86ba7c0685b40a3bf ]
Calling vring_invalidate must be done with a (write) lock taken on the
virtqueue.
Fixes: 72d002b3ebda ("vhost: fix vring address handling during live migration")
Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Eelco Chaudron <echaudro@redhat.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
lib/vhost/vhost_user.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
index 8df66e68b3..66ab68fa56 100644
--- a/lib/vhost/vhost_user.c
+++ b/lib/vhost/vhost_user.c
@@ -2144,7 +2144,9 @@ vhost_user_get_vring_base(struct virtio_net **pdev,
vhost_user_iotlb_flush_all(vq);
+ rte_spinlock_lock(&vq->access_lock);
vring_invalidate(dev, vq);
+ rte_spinlock_unlock(&vq->access_lock);
return RTE_VHOST_MSG_RESULT_REPLY;
}
--
2.43.0
next reply other threads:[~2024-03-07 8:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 8:06 David Marchand [this message]
2024-03-07 12:45 ` Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240307080604.4028280-1-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=echaudro@redhat.com \
--cc=luca.boccassi@gmail.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).