From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86E9F43B67 for ; Fri, 8 Mar 2024 15:31:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7ECD542FEF; Fri, 8 Mar 2024 15:31:28 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id B5655432C4 for ; Fri, 8 Mar 2024 15:31:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709908286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uT2/R4QVAS+bFOF8sxq+KTJGIqGxJ7c6JLj0v/V0lNs=; b=WJYgAON5RegIuGWdToIkQd+bgXhj6UQEm9lxh+Sc1V0VRD0yK2Kvriq76+LUNc4Dt2uBre J5kDK9rHCBoPVDKpPu8drM2NMC8YjkVHEDeBwb7carpBOr97+w/O3YmYUihbm0tfVpO/gA aYfdkj73C3VnU1ISpGZ4O4eHGGU1T7k= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-433-RrS61rwgNSGrlnwBfyjgvg-1; Fri, 08 Mar 2024 09:31:22 -0500 X-MC-Unique: RrS61rwgNSGrlnwBfyjgvg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7E8A885A58B; Fri, 8 Mar 2024 14:31:22 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.194.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id B816137F6; Fri, 8 Mar 2024 14:31:21 +0000 (UTC) From: Kevin Traynor To: Edwin Brossette Cc: Vladimir Medvedkin , dpdk stable Subject: patch 'net/ixgbevf: fix RSS init for x550 NICs' has been queued to stable release 21.11.7 Date: Fri, 8 Mar 2024 14:28:00 +0000 Message-ID: <20240308142824.528417-12-ktraynor@redhat.com> In-Reply-To: <20240308142824.528417-1-ktraynor@redhat.com> References: <20240308142824.528417-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/13/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/153ce28fcff59b6cf80b94c45811244cdb847f7e Thanks. Kevin --- >From 153ce28fcff59b6cf80b94c45811244cdb847f7e Mon Sep 17 00:00:00 2001 From: Edwin Brossette Date: Thu, 15 Feb 2024 14:31:45 +0100 Subject: [PATCH] net/ixgbevf: fix RSS init for x550 NICs [ upstream commit 3a53577d5f390e8635a672b79616e54c59b330ab ] Different Intel NICs with the igxbe PMD do not handle RSS in the same way when working with virtualization. While some NICs like Intel 82599ES only have a single RSS table in the device and leave all RSS features to be handled by the PF, some other NICs like x550 let the VF handle RSS features. This can lead to different behavior when RSS is enabled depending on the model of nic used. In particular, ixgbevf_dev_rx_init() does not configure RSS parameters at device init, even if the multi-queue mode option is set in the device configuration (ie. RTE_ETH_MQ_RX_RSS is set). Note that this issue went unnoticed until now, probably because some NICs do not really have support for RSS in virtualization mode. Thus, depending on the NIC used, we can we find ourselves in a situation where RSS is not configured despite being enabled. This will cause serious performance issues because the RSS RETA table will be fully zeroed, causing all packets to go only to the first queue, leaving all other queues empty. By looking at ixgbe_reta_size_get(), we can see that only X550 NIC models have a non zero RETA size set in VF mode. Therefore, add a call to ixgbe_rss_configure() for these cards in ixgbevf_dev_rx_init() if the option to enable RSS is set. Fixes: f4d1598ee14f ("ixgbevf: support RSS config on x550") Signed-off-by: Edwin Brossette Acked-by: Vladimir Medvedkin --- drivers/net/ixgbe/ixgbe_rxtx.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index c137707869..e3c611a40f 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -5742,4 +5742,23 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev) IXGBE_WRITE_REG(hw, IXGBE_VFPSRTYPE, psrtype); + /* Initialize the rss for x550_vf cards if enabled */ + switch (hw->mac.type) { + case ixgbe_mac_X550_vf: + case ixgbe_mac_X550EM_x_vf: + case ixgbe_mac_X550EM_a_vf: + switch (dev->data->dev_conf.rxmode.mq_mode) { + case RTE_ETH_MQ_RX_RSS: + case RTE_ETH_MQ_RX_DCB_RSS: + case RTE_ETH_MQ_RX_VMDQ_RSS: + ixgbe_rss_configure(dev); + break; + default: + break; + } + break; + default: + break; + } + ixgbe_set_rx_function(dev); -- 2.43.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-08 13:47:49.407409035 +0000 +++ 0012-net-ixgbevf-fix-RSS-init-for-x550-NICs.patch 2024-03-08 13:47:49.003686619 +0000 @@ -1 +1 @@ -From 3a53577d5f390e8635a672b79616e54c59b330ab Mon Sep 17 00:00:00 2001 +From 153ce28fcff59b6cf80b94c45811244cdb847f7e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 3a53577d5f390e8635a672b79616e54c59b330ab ] + @@ -31 +32,0 @@ -Cc: stable@dpdk.org @@ -40 +41 @@ -index 90b0a7004f..f6c17d4efb 100644 +index c137707869..e3c611a40f 100644 @@ -43 +44 @@ -@@ -5845,4 +5845,23 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev) +@@ -5742,4 +5742,23 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev)