From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B50E643B67 for ; Fri, 8 Mar 2024 15:31:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AFAC14336C; Fri, 8 Mar 2024 15:31:32 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C779042F0D for ; Fri, 8 Mar 2024 15:31:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709908290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p4DGMxjh5BZlMes+lhK4OcDmk/VFUnmNLg8P2AKXunw=; b=Mj9iAr8QyvyMmPzUHQMllMnGbq3/riITJGbw4GOcwNk0vINedmJoFYdI7pIVIqIpuR72Ls qdM6ot4C9VPY0Qs56vksCmhImHpYvlT3KQN5M60kthha6Fld4IwiTI9Hk9Kcov5YuN8daZ 6WFgpgJwVbbM5S82IqKC/dSaA33sPpE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-104-N7CGcaReM5iaMYRwFjcYiA-1; Fri, 08 Mar 2024 09:31:26 -0500 X-MC-Unique: N7CGcaReM5iaMYRwFjcYiA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1AEFA84B163; Fri, 8 Mar 2024 14:31:26 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.194.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0958437F6; Fri, 8 Mar 2024 14:31:22 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Bruce Richardson , dpdk stable Subject: patch 'net/iavf: remove error logs for VLAN offloading' has been queued to stable release 21.11.7 Date: Fri, 8 Mar 2024 14:28:01 +0000 Message-ID: <20240308142824.528417-13-ktraynor@redhat.com> In-Reply-To: <20240308142824.528417-1-ktraynor@redhat.com> References: <20240308142824.528417-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/13/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/22e7e531ce15b67a31fb150882d9689b6b029afc Thanks. Kevin --- >From 22e7e531ce15b67a31fb150882d9689b6b029afc Mon Sep 17 00:00:00 2001 From: David Marchand Date: Tue, 6 Feb 2024 11:34:20 +0100 Subject: [PATCH] net/iavf: remove error logs for VLAN offloading [ upstream commit 325764b3a20a16a7a997a324cc0b93367eb7f3e1 ] This was reported by RH QE. When a vlan is enforced on a VF via an administrative configuration on the PF side, the net/iavf driver logs two error messages. Those error messages have no consequence on the rest of the port initialisation and packet processing works fine. [root@toto ~] # ip l set enp94s0 vf 0 vlan 2 [root@toto ~] # dpdk-testpmd -a 0000:5e:02.0 -- -i ... Configuring Port 0 (socket 0) iavf_dev_init_vlan(): Failed to update vlan offload iavf_dev_configure(): configure VLAN failed: -95 iavf_set_rx_function(): request RXDID[1] in Queue[0] is legacy, set rx_pkt_burst as legacy for all queues The first change is to remove the error log in iavf_dev_init_vlan(). This log is unneeded since all error path are covered by dedicated log messages already. Then, in iavf_dev_init_vlan(), requesting all possible VLAN offloading must not trigger an ERROR level log message. This is simply confusing, as the application may not have requested such vlan offloading. The reason why the driver requests all offloading is unclear so keep it as is. Instead, rephrase the log message and lower its level to INFO. Fixes: 1c301e8c3cff ("net/iavf: support new VLAN capabilities") Signed-off-by: David Marchand Acked-by: Bruce Richardson --- drivers/net/iavf/iavf_ethdev.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index 8f4c6de0ac..4885a86ad3 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -604,5 +604,6 @@ iavf_dev_init_vlan(struct rte_eth_dev *dev) RTE_ETH_VLAN_EXTEND_MASK); if (err) { - PMD_DRV_LOG(ERR, "Failed to update vlan offload"); + PMD_DRV_LOG(INFO, + "VLAN offloading is not supported, or offloading was refused by the PF"); return err; } @@ -680,7 +681,5 @@ iavf_dev_configure(struct rte_eth_dev *dev) } - ret = iavf_dev_init_vlan(dev); - if (ret) - PMD_DRV_LOG(ERR, "configure VLAN failed: %d", ret); + iavf_dev_init_vlan(dev); if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_RSS_PF) { -- 2.43.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-08 13:47:49.437812888 +0000 +++ 0013-net-iavf-remove-error-logs-for-VLAN-offloading.patch 2024-03-08 13:47:49.006686628 +0000 @@ -1 +1 @@ -From 325764b3a20a16a7a997a324cc0b93367eb7f3e1 Mon Sep 17 00:00:00 2001 +From 22e7e531ce15b67a31fb150882d9689b6b029afc Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 325764b3a20a16a7a997a324cc0b93367eb7f3e1 ] + @@ -33 +34,0 @@ -Cc: stable@dpdk.org @@ -42 +43 @@ -index b5f6049a91..2cb602a358 100644 +index 8f4c6de0ac..4885a86ad3 100644 @@ -45 +46 @@ -@@ -634,5 +634,6 @@ iavf_dev_init_vlan(struct rte_eth_dev *dev) +@@ -604,5 +604,6 @@ iavf_dev_init_vlan(struct rte_eth_dev *dev) @@ -53 +54 @@ -@@ -710,7 +711,5 @@ iavf_dev_configure(struct rte_eth_dev *dev) +@@ -680,7 +681,5 @@ iavf_dev_configure(struct rte_eth_dev *dev)