From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59B7F43829 for ; Fri, 8 Mar 2024 15:32:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 543454337C; Fri, 8 Mar 2024 15:32:10 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 703B440E2D for ; Fri, 8 Mar 2024 15:32:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709908328; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vXXoRyjYsi2beez8Yt12vXXC/rpohgSpOOO387jufCQ=; b=M7eBqAH4iHZSj1HFIRXagfwJJfab5iVXKwTWly9FNIRFTzWvck+PpZdkzFf9P2vEHI7b5q USCkl8EZPty17YyzSP5ADJAr9Rry75LSTWbJ4/Z7vvsFvZ/dMwnY9obHLZP69fyfVEuYXV XQ2jlIAERMd1wjX+LYKLTIsh7/418xk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657-xhv_eNX3O1CrpeiUmIsQZA-1; Fri, 08 Mar 2024 09:32:04 -0500 X-MC-Unique: xhv_eNX3O1CrpeiUmIsQZA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 34F97185A786; Fri, 8 Mar 2024 14:32:04 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.194.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1E38B37F6; Fri, 8 Mar 2024 14:32:02 +0000 (UTC) From: Kevin Traynor To: Nithin Dabilpuram Cc: dpdk stable Subject: patch 'common/cnxk: fix mbox struct attributes' has been queued to stable release 21.11.7 Date: Fri, 8 Mar 2024 14:28:10 +0000 Message-ID: <20240308142824.528417-22-ktraynor@redhat.com> In-Reply-To: <20240308142824.528417-1-ktraynor@redhat.com> References: <20240308142824.528417-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/13/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/22c015d09d61a6d70101fc3cbf68a3a99adefa46 Thanks. Kevin --- >From 22c015d09d61a6d70101fc3cbf68a3a99adefa46 Mon Sep 17 00:00:00 2001 From: Nithin Dabilpuram Date: Mon, 26 Feb 2024 19:05:34 +0530 Subject: [PATCH] common/cnxk: fix mbox struct attributes [ upstream commit c9dca1c5e352008bda8d0edeab8fbcf328437282 ] IO attribute is needed to mbox structs to avoid unaligned or pair access causing by compiler optimization. Add them to structs where it is missing. Fixes: 503b82de2cbf ("common/cnxk: add mbox request and response definitions") Fixes: ddf955d3917e ("common/cnxk: support CPT second pass") Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_mbox.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/common/cnxk/roc_mbox.h b/drivers/common/cnxk/roc_mbox.h index 564bf29bc2..16e39ac6cf 100644 --- a/drivers/common/cnxk/roc_mbox.h +++ b/drivers/common/cnxk/roc_mbox.h @@ -825,10 +825,10 @@ struct nix_cn10k_aq_enq_rsp { struct mbox_msghdr hdr; union { - struct nix_cn10k_rq_ctx_s rq; - struct nix_cn10k_sq_ctx_s sq; - struct nix_cq_ctx_s cq; - struct nix_rsse_s rss; - struct nix_rx_mce_s mce; - struct nix_band_prof_s prof; + __io struct nix_cn10k_rq_ctx_s rq; + __io struct nix_cn10k_sq_ctx_s sq; + __io struct nix_cq_ctx_s cq; + __io struct nix_rsse_s rss; + __io struct nix_rx_mce_s mce; + __io struct nix_band_prof_s prof; }; }; -- 2.43.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-08 13:47:49.685458474 +0000 +++ 0022-common-cnxk-fix-mbox-struct-attributes.patch 2024-03-08 13:47:49.020686669 +0000 @@ -1 +1 @@ -From c9dca1c5e352008bda8d0edeab8fbcf328437282 Mon Sep 17 00:00:00 2001 +From 22c015d09d61a6d70101fc3cbf68a3a99adefa46 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c9dca1c5e352008bda8d0edeab8fbcf328437282 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -16,2 +17,2 @@ - drivers/common/cnxk/roc_mbox.h | 16 ++++++++-------- - 1 file changed, 8 insertions(+), 8 deletions(-) + drivers/common/cnxk/roc_mbox.h | 12 ++++++------ + 1 file changed, 6 insertions(+), 6 deletions(-) @@ -20 +21 @@ -index 4b4f48e372..d8a8494ac4 100644 +index 564bf29bc2..16e39ac6cf 100644 @@ -23 +24 @@ -@@ -1428,10 +1428,10 @@ struct nix_cn10k_aq_enq_rsp { +@@ -825,10 +825,10 @@ struct nix_cn10k_aq_enq_rsp { @@ -40,12 +40,0 @@ -@@ -1669,9 +1669,9 @@ struct nix_rq_cpt_field_mask_cfg_req { - union { - uint64_t __io rq_ctx_word_set[RQ_CTX_MASK_MAX]; -- struct nix_cn10k_rq_ctx_s rq_set; -+ __io struct nix_cn10k_rq_ctx_s rq_set; - }; - union { - uint64_t __io rq_ctx_word_mask[RQ_CTX_MASK_MAX]; -- struct nix_cn10k_rq_ctx_s rq_mask; -+ __io struct nix_cn10k_rq_ctx_s rq_mask; - }; - struct nix_lf_rx_ipec_cfg1_req {