From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 932B843B67 for ; Fri, 8 Mar 2024 15:29:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8CCF042FFD; Fri, 8 Mar 2024 15:29:29 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3B7BA42F3F for ; Fri, 8 Mar 2024 15:29:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709908167; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iqibEDC9747XO+2P+uCx9D/ztOyoXApsw0I2xHHLCpo=; b=bnmOdWyR7LmG0Tbpcncsj5gHus4OhVCMEhsVPeCmp2eopXvv7ofJenOJMb2EkTMddMHOBY VnVSVPlzJIzxaW4mTgkNSFamrjTUxWkdFkyHY/f7ub5Vdq9Z8OVczev7Jet2Ql2tTep5LY BZ6GMjjUzGXbfnL3+8xr9mdyId5pkLM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-507-2ckk46YzO1KroR04W24orA-1; Fri, 08 Mar 2024 09:29:24 -0500 X-MC-Unique: 2ckk46YzO1KroR04W24orA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 42F0A8007A6; Fri, 8 Mar 2024 14:29:24 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.194.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8B6D637FC; Fri, 8 Mar 2024 14:29:16 +0000 (UTC) From: Kevin Traynor To: Ganapati Kundapura Cc: Pavan Nikhilesh , dpdk stable Subject: patch 'test/event: fix crash in Tx adapter freeing' has been queued to stable release 21.11.7 Date: Fri, 8 Mar 2024 14:27:51 +0000 Message-ID: <20240308142824.528417-3-ktraynor@redhat.com> In-Reply-To: <20240308142824.528417-1-ktraynor@redhat.com> References: <20240308142824.528417-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/13/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/34342122cdc25539473b94c82075f95fc7c11494 Thanks. Kevin --- >From 34342122cdc25539473b94c82075f95fc7c11494 Mon Sep 17 00:00:00 2001 From: Ganapati Kundapura Date: Mon, 26 Feb 2024 02:30:03 -0600 Subject: [PATCH] test/event: fix crash in Tx adapter freeing [ upstream commit 1f85467fcaf03c6b0d879614ee18f9a98fe9e9e6 ] Uninitialized mbufs are enqueued to eventdev which causes segfault on freeing the mbuf in Tx adapter. Fixed by initializing mbufs before enqueuing to eventdev. Fixes: 46cf97e4bbfa ("eventdev: add test for eth Tx adapter") Signed-off-by: Ganapati Kundapura Acked-by: Pavan Nikhilesh --- app/test/test_event_eth_tx_adapter.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/test/test_event_eth_tx_adapter.c b/app/test/test_event_eth_tx_adapter.c index cfcc784351..a75f1bb51f 100644 --- a/app/test/test_event_eth_tx_adapter.c +++ b/app/test/test_event_eth_tx_adapter.c @@ -472,4 +472,8 @@ tx_adapter_service(void) uint32_t cap; + /* Initialize mbufs */ + for (i = 0; i < RING_SIZE; i++) + rte_pktmbuf_reset(&bufs[i]); + memset(&dev_conf, 0, sizeof(dev_conf)); err = rte_event_eth_tx_adapter_caps_get(TEST_DEV_ID, TEST_ETHDEV_ID, -- 2.43.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-08 13:47:49.165938846 +0000 +++ 0003-test-event-fix-crash-in-Tx-adapter-freeing.patch 2024-03-08 13:47:48.978686544 +0000 @@ -1 +1 @@ -From 1f85467fcaf03c6b0d879614ee18f9a98fe9e9e6 Mon Sep 17 00:00:00 2001 +From 34342122cdc25539473b94c82075f95fc7c11494 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 1f85467fcaf03c6b0d879614ee18f9a98fe9e9e6 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index dbd22f6800..482b8e69e3 100644 +index cfcc784351..a75f1bb51f 100644 @@ -23 +24 @@ -@@ -485,4 +485,8 @@ tx_adapter_service(void) +@@ -472,4 +472,8 @@ tx_adapter_service(void)