From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E3DC43829 for ; Fri, 8 Mar 2024 15:33:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4944842F0D; Fri, 8 Mar 2024 15:33:13 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 783B540E2D for ; Fri, 8 Mar 2024 15:33:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709908392; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oD34913eJjwjDoogYoLv4aXoGAZL0tTyGyitR6JnKuk=; b=FhIvKTNklU/BYIbBMRfyW036xk3sxB4AGZCix0vn0H37gIsZx48L3Y+zWFRSpzJCv7zc1Z xSOsvGctu3qej3g17stzSsNflpRmCYEwXVtWE7wqMR/m4CflIIDePChcvnFIy/1C8vn4Zm KtrxJ2742xXelffmsQLHE0pNqiVcjy4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-459-KZWamtJzOJ2HQ0dBfLXc0Q-1; Fri, 08 Mar 2024 09:33:08 -0500 X-MC-Unique: KZWamtJzOJ2HQ0dBfLXc0Q-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 24D5E800267; Fri, 8 Mar 2024 14:33:07 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.194.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1611937FC; Fri, 8 Mar 2024 14:33:05 +0000 (UTC) From: Kevin Traynor To: Konstantin Ananyev Cc: Konstantin Ananyev , Pavan Nikhilesh , dpdk stable Subject: patch 'examples/l3fwd: fix Rx over not ready port' has been queued to stable release 21.11.7 Date: Fri, 8 Mar 2024 14:28:22 +0000 Message-ID: <20240308142824.528417-34-ktraynor@redhat.com> In-Reply-To: <20240308142824.528417-1-ktraynor@redhat.com> References: <20240308142824.528417-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/13/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/1e1f6d551be99b66b7d2e0a937a6e8a7aa8f1f1d Thanks. Kevin --- >From 1e1f6d551be99b66b7d2e0a937a6e8a7aa8f1f1d Mon Sep 17 00:00:00 2001 From: Konstantin Ananyev Date: Fri, 1 Mar 2024 16:39:31 +0000 Subject: [PATCH] examples/l3fwd: fix Rx over not ready port [ upstream commit 495709d32be87cb962c55917b19ad7d4489cde3e ] Running l3fwd in event mode with SW eventdev, service cores can start RX before main thread is finished with PMD installation. to reproduce: ./dpdk-l3fwd --lcores=49,51 -n 6 -a ca:00.0 -s 0x8000000000000 \ --vdev event_sw0 -- \ -L -P -p 1 --mode eventdev --eventq-sched=ordered \ --rule_ipv4=test/l3fwd_lpm_v4_u1.cfg --rule_ipv6=test/l3fwd_lpm_v6_u1.cfg \ --no-numa At init stage user will most likely see the error message like that: ETHDEV: lcore 51 called rx_pkt_burst for not ready port 0 0: ./dpdk-l3fwd (rte_dump_stack+0x1f) [15de723] ... 9: ./dpdk-l3fwd (eal_thread_loop+0x5a2) [15c1324] ... And then all depends how luck/unlucky you are. If there are some actual packet in HW RX queue, then the app will most likely crash, otherwise it might survive. As error message suggests, the problem is that services are started before main thread finished with NIC setup and initialization. The suggested fix moves services startup after NIC setup phase. Bugzilla ID: 1390 Fixes: 8bd537e9c6cf ("examples/l3fwd: add service core setup based on caps") Signed-off-by: Konstantin Ananyev Signed-off-by: Konstantin Ananyev Acked-by: Pavan Nikhilesh --- examples/l3fwd/main.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index 59436bb589..32cc45647e 100644 --- a/examples/l3fwd/main.c +++ b/examples/l3fwd/main.c @@ -1460,5 +1460,4 @@ main(int argc, char **argv) else l3fwd_lkp.main_loop = evt_rsrc->ops.lpm_event_loop; - l3fwd_event_service_setup(); } else l3fwd_poll_resource_setup(); @@ -1491,4 +1490,9 @@ main(int argc, char **argv) } +#ifdef RTE_LIB_EVENTDEV + if (evt_rsrc->enabled) + l3fwd_event_service_setup(); +#endif + printf("\n"); -- 2.43.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-08 13:47:50.001070998 +0000 +++ 0034-examples-l3fwd-fix-Rx-over-not-ready-port.patch 2024-03-08 13:47:49.043686738 +0000 @@ -1 +1 @@ -From 495709d32be87cb962c55917b19ad7d4489cde3e Mon Sep 17 00:00:00 2001 +From 1e1f6d551be99b66b7d2e0a937a6e8a7aa8f1f1d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 495709d32be87cb962c55917b19ad7d4489cde3e ] + @@ -31 +32,0 @@ -Cc: stable@dpdk.org @@ -41 +42 @@ -index 3bf28aec0c..d4fb5d1971 100644 +index 59436bb589..32cc45647e 100644 @@ -44 +45 @@ -@@ -1578,5 +1578,4 @@ main(int argc, char **argv) +@@ -1460,5 +1460,4 @@ main(int argc, char **argv) @@ -49,2 +50,2 @@ - #endif -@@ -1610,4 +1609,9 @@ main(int argc, char **argv) + l3fwd_poll_resource_setup(); +@@ -1491,4 +1490,9 @@ main(int argc, char **argv)