From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6BC0243B67 for ; Fri, 8 Mar 2024 15:30:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C2DF42F3F; Fri, 8 Mar 2024 15:30:01 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7A3CE40E2D for ; Fri, 8 Mar 2024 15:29:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709908199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TvQIHJQ/Wm4oeKcbxvFoqn/G9vXrqHXyoL7Bczx5a6c=; b=H2Zb/7HXMrP5wSV143dXadtuh5b1lkqNFpBRFpTM++JzfXwCuSqjJHUYKN6V2TqZybQpZ3 km8wcR2GOK9HrUk3bhNiyWnFEcUZTJhwHJguGzk3Xw19jihnX3JtRoWbfGYWAdbPECrqbl RynHzaazb/WpKBnIs/mSAnlcFatcdX8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-12-JqelgvfPNimqtiMHFvJoEQ-1; Fri, 08 Mar 2024 09:29:54 -0500 X-MC-Unique: JqelgvfPNimqtiMHFvJoEQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8E0C088F566; Fri, 8 Mar 2024 14:29:54 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.194.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id F0BAF37FC; Fri, 8 Mar 2024 14:29:50 +0000 (UTC) From: Kevin Traynor To: Suanming Mou Cc: Anoob Joseph , dpdk stable Subject: patch 'app/crypto-perf: add missing op resubmission' has been queued to stable release 21.11.7 Date: Fri, 8 Mar 2024 14:27:55 +0000 Message-ID: <20240308142824.528417-7-ktraynor@redhat.com> In-Reply-To: <20240308142824.528417-1-ktraynor@redhat.com> References: <20240308142824.528417-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/13/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/c5d16ff345f9fd418026d25db0495643e3671e83 Thanks. Kevin --- >From c5d16ff345f9fd418026d25db0495643e3671e83 Mon Sep 17 00:00:00 2001 From: Suanming Mou Date: Mon, 15 Jan 2024 16:08:30 +0800 Subject: [PATCH] app/crypto-perf: add missing op resubmission [ upstream commit 74d7c028ecf478f18cf9623210bab459d5992d7a ] Currently, after enqueue_burst, there may be ops_unused ops left for next round enqueue. And in next round preparation, only ops_needed ops will be added. But if in the final round the left ops is less than ops_needed, there will be invalid ops between the new needed ops and previous unused ops. The previous unused ops should be moved front after the needed ops. In the commit[1], an resubmission fix was added to throughput test, and the fix was missed for verify. This commit adds the missed resubmission fix for verify. [1] commit 44e2980b70d1 ("app/crypto-perf: fix crypto operation resubmission") Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Suanming Mou Acked-by: Anoob Joseph --- app/test-crypto-perf/cperf_test_verify.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/app/test-crypto-perf/cperf_test_verify.c b/app/test-crypto-perf/cperf_test_verify.c index 5574429196..30f66618ed 100644 --- a/app/test-crypto-perf/cperf_test_verify.c +++ b/app/test-crypto-perf/cperf_test_verify.c @@ -301,5 +301,4 @@ cperf_verify_test_runner(void *test_ctx) ctx->test_vector, iv_offset, &imix_idx, NULL); - /* Populate the mbuf with the test vector, for verification */ for (i = 0; i < ops_needed; i++) @@ -319,4 +318,15 @@ cperf_verify_test_runner(void *test_ctx) #endif /* CPERF_LINEARIZATION_ENABLE */ + /** + * When ops_needed is smaller than ops_enqd, the + * unused ops need to be moved to the front for + * next round use. + */ + if (unlikely(ops_enqd > ops_needed)) { + size_t nb_b_to_mov = ops_unused * sizeof(struct rte_crypto_op *); + + memmove(&ops[ops_needed], &ops[ops_enqd], nb_b_to_mov); + } + /* Enqueue burst of ops on crypto device */ ops_enqd = rte_cryptodev_enqueue_burst(ctx->dev_id, ctx->qp_id, -- 2.43.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-08 13:47:49.274747158 +0000 +++ 0007-app-crypto-perf-add-missing-op-resubmission.patch 2024-03-08 13:47:48.989686576 +0000 @@ -1 +1 @@ -From 74d7c028ecf478f18cf9623210bab459d5992d7a Mon Sep 17 00:00:00 2001 +From c5d16ff345f9fd418026d25db0495643e3671e83 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 74d7c028ecf478f18cf9623210bab459d5992d7a ] + @@ -23 +24,0 @@ -Cc: stable@dpdk.org @@ -32 +33 @@ -index 2b0d3f142b..10172a53a0 100644 +index 5574429196..30f66618ed 100644 @@ -35 +36 @@ -@@ -276,5 +276,4 @@ cperf_verify_test_runner(void *test_ctx) +@@ -301,5 +301,4 @@ cperf_verify_test_runner(void *test_ctx) @@ -41 +42 @@ -@@ -294,4 +293,15 @@ cperf_verify_test_runner(void *test_ctx) +@@ -319,4 +318,15 @@ cperf_verify_test_runner(void *test_ctx)