From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5954D43CAD for ; Thu, 14 Mar 2024 01:10:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51E0442E36; Thu, 14 Mar 2024 01:10:36 +0100 (CET) Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by mails.dpdk.org (Postfix) with ESMTP id 244B342E36 for ; Thu, 14 Mar 2024 01:10:35 +0100 (CET) Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-413f04aab2cso1762755e9.2 for ; Wed, 13 Mar 2024 17:10:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710375035; x=1710979835; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lyZkPO4ziIfbg2kcTYN6DoGwf5ozDCpusFdaxCyqgIM=; b=LgNdOEGPqIXE0iH19WOXRcNnTuJh+91W5elZyc85ZsL+OIbZe0yfGIRd41SKBTznvX u1NYxTBlWv6GNnp4gweDYdkxWnRnTZksPaG9lYB6YmIv+i1ivQo5kt/tP3KE/cHfcpKa TSfU6k1oJYbYpVMXTdms6LBxYkB/dEbB7FtiCngw5yqE5JQf5otqij8dzUy2ehPD0AGS hCY7ScncxpqZWc29CtMAyAqxGR5tWwIb8gKGsgxnX8yiDzWC92IyHt+WDLdXvaKg8W5B Oh+T3luNV9lDj42vIJcgA0VvLerdIw1GZ+j3L/JEpXIYp1YEWCCi0CYID71DRpKBO2Jg FU1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710375035; x=1710979835; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lyZkPO4ziIfbg2kcTYN6DoGwf5ozDCpusFdaxCyqgIM=; b=L5N/UK8L8XMktMDCD45yBs6UXIhk1YEpRIhZ9ZUCzYxYOrwdpQHvRCqam+5jV3oTNX BVo8IHURlWQHgCdCrTECpsKDa6IMHFC83vCNRayIG2yt6h+kWj/5J52p+ctt8aFtMhBb Oc4/9WRZv80ppeYqZlA3IdEwYGwM44gp8cNwjfwUsyCO33j/m59Z7lQqF14e8caDL0WT GyyxahEQvbta/HJfjTVW0mCEwKPghWAH9Md1jQD1hRoDLuY1bSKVjho5LSb08IfNm7/x vDvpDEP+8fIMc34Krl/4gtCUTa610S5POLBlqwOj6pyo6e4HJNOzNbbqkFFlvcZTfvLA RoVw== X-Forwarded-Encrypted: i=1; AJvYcCUD4i+LHixyHrLycpJy7+6AsY3QDUgqI+pv7I0C4nfnlEw48NFZkKqgmNt7Nmw28KaG/PR/UOmVIIyXy6ShA4c= X-Gm-Message-State: AOJu0YxRQldLAIen+01bOpHdoF6zkxengHoH5Bq/k5+i+xILBiXhFv6P Wiz48896uoTNatkTaM9L+Lv5YSiFdx7xz9i/oOBgm9x3IX7NFAJUlOjgRE/h X-Google-Smtp-Source: AGHT+IEy4mJS/lBP2dl04jEhwhBLY/GbeQsxyX8piG73KJA5kwuC69kcGSGNeKTHsrgY1rv6Oz7wjg== X-Received: by 2002:a05:600c:1990:b0:413:e97b:11b4 with SMTP id t16-20020a05600c199000b00413e97b11b4mr196883wmq.34.1710375034800; Wed, 13 Mar 2024 17:10:34 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:7aef:1aaa:3dff:d546]) by smtp.gmail.com with ESMTPSA id h10-20020a05600c350a00b00412ee8e2f2asm3803708wmq.9.2024.03.13.17.10.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 17:10:34 -0700 (PDT) From: luca.boccassi@gmail.com To: Suanming Mou Cc: Anoob Joseph , dpdk stable Subject: patch 'app/crypto-perf: add missing op resubmission' has been queued to stable release 22.11.5 Date: Thu, 14 Mar 2024 00:09:08 +0000 Message-Id: <20240314000957.2810803-12-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240314000957.2810803-1-luca.boccassi@gmail.com> References: <20240307013159.1735343-102-luca.boccassi@gmail.com> <20240314000957.2810803-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/16/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/3ebfe5050759f0f1e8e5f4e167d5e6cff58bc515 Thanks. Luca Boccassi --- >From 3ebfe5050759f0f1e8e5f4e167d5e6cff58bc515 Mon Sep 17 00:00:00 2001 From: Suanming Mou Date: Mon, 15 Jan 2024 16:08:30 +0800 Subject: [PATCH] app/crypto-perf: add missing op resubmission [ upstream commit 74d7c028ecf478f18cf9623210bab459d5992d7a ] Currently, after enqueue_burst, there may be ops_unused ops left for next round enqueue. And in next round preparation, only ops_needed ops will be added. But if in the final round the left ops is less than ops_needed, there will be invalid ops between the new needed ops and previous unused ops. The previous unused ops should be moved front after the needed ops. In the commit[1], an resubmission fix was added to throughput test, and the fix was missed for verify. This commit adds the missed resubmission fix for verify. [1] commit 44e2980b70d1 ("app/crypto-perf: fix crypto operation resubmission") Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Suanming Mou Acked-by: Anoob Joseph --- app/test-crypto-perf/cperf_test_verify.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/app/test-crypto-perf/cperf_test_verify.c b/app/test-crypto-perf/cperf_test_verify.c index 5a963fa3cc..2249c46694 100644 --- a/app/test-crypto-perf/cperf_test_verify.c +++ b/app/test-crypto-perf/cperf_test_verify.c @@ -275,7 +275,6 @@ cperf_verify_test_runner(void *test_ctx) ops_needed, ctx->sess, ctx->options, ctx->test_vector, iv_offset, &imix_idx, NULL); - /* Populate the mbuf with the test vector, for verification */ for (i = 0; i < ops_needed; i++) cperf_mbuf_set(ops[i]->sym->m_src, @@ -293,6 +292,17 @@ cperf_verify_test_runner(void *test_ctx) } #endif /* CPERF_LINEARIZATION_ENABLE */ + /** + * When ops_needed is smaller than ops_enqd, the + * unused ops need to be moved to the front for + * next round use. + */ + if (unlikely(ops_enqd > ops_needed)) { + size_t nb_b_to_mov = ops_unused * sizeof(struct rte_crypto_op *); + + memmove(&ops[ops_needed], &ops[ops_enqd], nb_b_to_mov); + } + /* Enqueue burst of ops on crypto device */ ops_enqd = rte_cryptodev_enqueue_burst(ctx->dev_id, ctx->qp_id, ops, burst_size); -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-14 00:09:21.339329614 +0000 +++ 0012-app-crypto-perf-add-missing-op-resubmission.patch 2024-03-14 00:09:20.573614427 +0000 @@ -1 +1 @@ -From 74d7c028ecf478f18cf9623210bab459d5992d7a Mon Sep 17 00:00:00 2001 +From 3ebfe5050759f0f1e8e5f4e167d5e6cff58bc515 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 74d7c028ecf478f18cf9623210bab459d5992d7a ] + @@ -23 +24,0 @@ -Cc: stable@dpdk.org @@ -32 +33 @@ -index 2b0d3f142b..10172a53a0 100644 +index 5a963fa3cc..2249c46694 100644