From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0ECC743CAD for ; Thu, 14 Mar 2024 01:10:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 07FB042E57; Thu, 14 Mar 2024 01:10:57 +0100 (CET) Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mails.dpdk.org (Postfix) with ESMTP id D559842E50 for ; Thu, 14 Mar 2024 01:10:55 +0100 (CET) Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-33e6aca1ca9so239150f8f.2 for ; Wed, 13 Mar 2024 17:10:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710375055; x=1710979855; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PN+HAXf8+vTogtPNqnzjJoVa040e7665lW5q5+TwyDU=; b=Y5YInUKZGUH6AscxpVoLARWkuJl/pVKEa424VRf7VHedgTbd4D3CHaHMAsl1ueuFHm Fvx43NIEaIz2JQa5+gtr5ShM+KHdrnFlpGHcAfvLwJ+I9unWIop/d/VrA5k1PxLsEBWu EevPx3DWgeyhcrtpl1nSea+Ou7hccqVI88sb2WrV5ck6c2ncXRc2RA3k7fI6FBWzIc0A WlIAHF/djvWAFkHHS/+PIy69/Ei5u/CGb4PTFXzEkvM2RaPBYjhDe4bqtNMEP3Z9l8n8 lP7kszI6u5oUdLbVTK0FEls3fXDu2BK4RtJjL9Leszlqmvvg+fBUWf7fzLr0TJdtvp9c rtBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710375055; x=1710979855; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PN+HAXf8+vTogtPNqnzjJoVa040e7665lW5q5+TwyDU=; b=Gq+QX7QRXRKv71VMQ5GUGpifvvgn/jl5M0cCFfqt7PIx8hJCA5gZGxWaVFsT7IBnO8 lqbP86pHzc66GKHwgVC+bNMJ4eoWfJ2bLQ7gnGZvRNLJrj5HmDhngHqXJnfIw9xyvkrg Y1ZD4kEXWq/BdNbhtNm8xnP7l+xRFKns0hdxTrGY/+7kcY0UZ1lmcz8l6ELIclUUqhz9 xIf8jl/2+eVUBBmyAv+LBBxrRTM86DDbpSdSBgh8zYeXzClJYPvnerZ8cUEemwFLsZvX tchM+i831vaI+dEI1SCshEJlTqKZ5JleLbsd7rcnmX4eQtUWDh5J79FFTWHza2YeRaWM tdRw== X-Forwarded-Encrypted: i=1; AJvYcCWKCkgDz1xGf1p/QZQAMhIYEeibc4jFHAKjKW0YXlX3Zt9utSkRZm2MTe2GsPdzThozlHMTXu7bWPakdgcPGeI= X-Gm-Message-State: AOJu0Yyqww8ggELmG6ZHJa1y2p8ufCX+M5rJbZHNuvCKWa0RiwvQwEnt EuvIHvLO9slRtAFA+8OnoJmz9wZw8JJ57pZKUxtC8aiAWsHwgeM3 X-Google-Smtp-Source: AGHT+IGF6ClezNaDJCgNVItwUT47z3ypWLkuh+/YgS0ODfYZYT0XyYurvi/+Cs3ViuFu39/f8Q/HXQ== X-Received: by 2002:a5d:42cf:0:b0:33d:579e:f462 with SMTP id t15-20020a5d42cf000000b0033d579ef462mr82927wrr.36.1710375055475; Wed, 13 Mar 2024 17:10:55 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:7aef:1aaa:3dff:d546]) by smtp.gmail.com with ESMTPSA id bu19-20020a056000079300b0033de2f2a88dsm281642wrb.103.2024.03.13.17.10.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 17:10:54 -0700 (PDT) From: luca.boccassi@gmail.com To: Edwin Brossette Cc: Vladimir Medvedkin , dpdk stable Subject: patch 'net/ixgbevf: fix RSS init for x550 NICs' has been queued to stable release 22.11.5 Date: Thu, 14 Mar 2024 00:09:16 +0000 Message-Id: <20240314000957.2810803-20-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240314000957.2810803-1-luca.boccassi@gmail.com> References: <20240307013159.1735343-102-luca.boccassi@gmail.com> <20240314000957.2810803-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/16/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/3a2d35d6e9c889e2da3ab586380d8cc7af373e6b Thanks. Luca Boccassi --- >From 3a2d35d6e9c889e2da3ab586380d8cc7af373e6b Mon Sep 17 00:00:00 2001 From: Edwin Brossette Date: Thu, 15 Feb 2024 14:31:45 +0100 Subject: [PATCH] net/ixgbevf: fix RSS init for x550 NICs [ upstream commit 3a53577d5f390e8635a672b79616e54c59b330ab ] Different Intel NICs with the igxbe PMD do not handle RSS in the same way when working with virtualization. While some NICs like Intel 82599ES only have a single RSS table in the device and leave all RSS features to be handled by the PF, some other NICs like x550 let the VF handle RSS features. This can lead to different behavior when RSS is enabled depending on the model of nic used. In particular, ixgbevf_dev_rx_init() does not configure RSS parameters at device init, even if the multi-queue mode option is set in the device configuration (ie. RTE_ETH_MQ_RX_RSS is set). Note that this issue went unnoticed until now, probably because some NICs do not really have support for RSS in virtualization mode. Thus, depending on the NIC used, we can we find ourselves in a situation where RSS is not configured despite being enabled. This will cause serious performance issues because the RSS RETA table will be fully zeroed, causing all packets to go only to the first queue, leaving all other queues empty. By looking at ixgbe_reta_size_get(), we can see that only X550 NIC models have a non zero RETA size set in VF mode. Therefore, add a call to ixgbe_rss_configure() for these cards in ixgbevf_dev_rx_init() if the option to enable RSS is set. Fixes: f4d1598ee14f ("ixgbevf: support RSS config on x550") Signed-off-by: Edwin Brossette Acked-by: Vladimir Medvedkin --- drivers/net/ixgbe/ixgbe_rxtx.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index a3a7c68806..e41bfa5ce3 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -5740,6 +5740,25 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev) IXGBE_PSRTYPE_RQPL_SHIFT; IXGBE_WRITE_REG(hw, IXGBE_VFPSRTYPE, psrtype); + /* Initialize the rss for x550_vf cards if enabled */ + switch (hw->mac.type) { + case ixgbe_mac_X550_vf: + case ixgbe_mac_X550EM_x_vf: + case ixgbe_mac_X550EM_a_vf: + switch (dev->data->dev_conf.rxmode.mq_mode) { + case RTE_ETH_MQ_RX_RSS: + case RTE_ETH_MQ_RX_DCB_RSS: + case RTE_ETH_MQ_RX_VMDQ_RSS: + ixgbe_rss_configure(dev); + break; + default: + break; + } + break; + default: + break; + } + ixgbe_set_rx_function(dev); return 0; -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-14 00:09:21.674729332 +0000 +++ 0020-net-ixgbevf-fix-RSS-init-for-x550-NICs.patch 2024-03-14 00:09:20.593614824 +0000 @@ -1 +1 @@ -From 3a53577d5f390e8635a672b79616e54c59b330ab Mon Sep 17 00:00:00 2001 +From 3a2d35d6e9c889e2da3ab586380d8cc7af373e6b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 3a53577d5f390e8635a672b79616e54c59b330ab ] + @@ -31 +32,0 @@ -Cc: stable@dpdk.org @@ -40 +41 @@ -index 90b0a7004f..f6c17d4efb 100644 +index a3a7c68806..e41bfa5ce3 100644 @@ -43 +44 @@ -@@ -5844,6 +5844,25 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev) +@@ -5740,6 +5740,25 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev)