From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3AE2543CAD for ; Thu, 14 Mar 2024 01:11:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3561540297; Thu, 14 Mar 2024 01:11:08 +0100 (CET) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mails.dpdk.org (Postfix) with ESMTP id 42AA34021E for ; Thu, 14 Mar 2024 01:11:07 +0100 (CET) Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-413eee75912so2616265e9.1 for ; Wed, 13 Mar 2024 17:11:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710375067; x=1710979867; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uIv8Ze9hQVEk/YFNksi3QXZ7nGELkVj8/XrnTPL1xU4=; b=IFvMw4bk6t/EEZM0mIhTHoa9UXcyScjmaJKQwuI/1aCapI5+4/pwoJCyXeSOvTZgz2 HDxqJOBQHkPGGYHqVGjA8BdompSVFrxjZbhX5N4oURa/jybV+E1/kAzbfOMklif0Gk/x TapXRn+SGh4YbuJxw8klQlktIXEctY07GdHDrG6u4nXZKPTwVbb+tJ8Ps3NwaHW4GmwC lWvGV61fV1mma8ZumhnnRQDf2ytTsLyXwQJim8bk6b67ylyosPNtZMtgBifqOsiVeN+L MveiGb7Wg3t5ERe7iJvs7vKETkETBoWPHWbsfc5T6Rm961EiCjYOxu3gERucKK71OQNj 50CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710375067; x=1710979867; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uIv8Ze9hQVEk/YFNksi3QXZ7nGELkVj8/XrnTPL1xU4=; b=jSRldTOkeHVJEui8Rpb32U4nd8D9GKdAT+ZOoYxyCNupLwq3klOFNWJYZalb2T8zQJ oVeX09p4BQ94HkID+y2C6O5CHibQxp67aN8ekLb79c30DpkmMyMacaQxVtK7l8qm3TmM Ma6Om6l7DkXUTiJoX8C4JVpiiYSBXN+AHHUQ0KJSfgWyP6+eCVssfPB1HMHrV03NsL0o okc6qy6nZAegFqGKM8dqFgRz44jnOKnKsWWA41ECuwPqgw2ooTsgXQAiY2CpgSHN6Elf S/IYcRZakooBmngxvyo2be2za7x8hZGdoZsvlU/j/Rgl2DIv/KfTw1i4zwn8Ai4SXfxZ bjNw== X-Forwarded-Encrypted: i=1; AJvYcCVTaOOs0uUnA373ag/35buQdLEmUTjuabvpl2lOLMQK66EUAZ1FTy6GDjCWqdznf20+9A9wyZg9ei3eMXbgPKs= X-Gm-Message-State: AOJu0YxkRzG3BRsvf8HMnOUIvJsL/HCXNb0Da7wG7hoQXggzF48mGbAB XKI+GXvaXopzaDUVlNprZG+yhUw1pGGOIB3Suu4danJ83N6ong+BsPUcqyD8 X-Google-Smtp-Source: AGHT+IFFBhlkyGAtKXTaf6GW9y+zjfYasnS991Wid6OmdhVIi1M+iSFMnVFBci59iiZ3v9VKndFXOw== X-Received: by 2002:a05:600c:3d89:b0:413:1ae3:8dd2 with SMTP id bi9-20020a05600c3d8900b004131ae38dd2mr183029wmb.37.1710375066805; Wed, 13 Mar 2024 17:11:06 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:7aef:1aaa:3dff:d546]) by smtp.gmail.com with ESMTPSA id be10-20020a05600c1e8a00b00412f428aedasm3805511wmb.46.2024.03.13.17.11.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 17:11:06 -0700 (PDT) From: luca.boccassi@gmail.com To: David Marchand Cc: Bruce Richardson , dpdk stable Subject: patch 'net/iavf: remove error logs for VLAN offloading' has been queued to stable release 22.11.5 Date: Thu, 14 Mar 2024 00:09:17 +0000 Message-Id: <20240314000957.2810803-21-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240314000957.2810803-1-luca.boccassi@gmail.com> References: <20240307013159.1735343-102-luca.boccassi@gmail.com> <20240314000957.2810803-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/16/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/baf1699534cffe5b9394ab52b2c3725af933e03c Thanks. Luca Boccassi --- >From baf1699534cffe5b9394ab52b2c3725af933e03c Mon Sep 17 00:00:00 2001 From: David Marchand Date: Tue, 6 Feb 2024 11:34:20 +0100 Subject: [PATCH] net/iavf: remove error logs for VLAN offloading [ upstream commit 325764b3a20a16a7a997a324cc0b93367eb7f3e1 ] This was reported by RH QE. When a vlan is enforced on a VF via an administrative configuration on the PF side, the net/iavf driver logs two error messages. Those error messages have no consequence on the rest of the port initialisation and packet processing works fine. [root@toto ~] # ip l set enp94s0 vf 0 vlan 2 [root@toto ~] # dpdk-testpmd -a 0000:5e:02.0 -- -i ... Configuring Port 0 (socket 0) iavf_dev_init_vlan(): Failed to update vlan offload iavf_dev_configure(): configure VLAN failed: -95 iavf_set_rx_function(): request RXDID[1] in Queue[0] is legacy, set rx_pkt_burst as legacy for all queues The first change is to remove the error log in iavf_dev_init_vlan(). This log is unneeded since all error path are covered by dedicated log messages already. Then, in iavf_dev_init_vlan(), requesting all possible VLAN offloading must not trigger an ERROR level log message. This is simply confusing, as the application may not have requested such vlan offloading. The reason why the driver requests all offloading is unclear so keep it as is. Instead, rephrase the log message and lower its level to INFO. Fixes: 1c301e8c3cff ("net/iavf: support new VLAN capabilities") Signed-off-by: David Marchand Acked-by: Bruce Richardson --- drivers/net/iavf/iavf_ethdev.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index a12ea39444..b244d45abb 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -609,7 +609,8 @@ iavf_dev_init_vlan(struct rte_eth_dev *dev) RTE_ETH_VLAN_FILTER_MASK | RTE_ETH_VLAN_EXTEND_MASK); if (err) { - PMD_DRV_LOG(ERR, "Failed to update vlan offload"); + PMD_DRV_LOG(INFO, + "VLAN offloading is not supported, or offloading was refused by the PF"); return err; } @@ -685,9 +686,7 @@ iavf_dev_configure(struct rte_eth_dev *dev) vf->max_rss_qregion = IAVF_MAX_NUM_QUEUES_DFLT; } - ret = iavf_dev_init_vlan(dev); - if (ret) - PMD_DRV_LOG(ERR, "configure VLAN failed: %d", ret); + iavf_dev_init_vlan(dev); if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_RSS_PF) { if (iavf_init_rss(ad) != 0) { -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-14 00:09:21.720645174 +0000 +++ 0021-net-iavf-remove-error-logs-for-VLAN-offloading.patch 2024-03-14 00:09:20.597614904 +0000 @@ -1 +1 @@ -From 325764b3a20a16a7a997a324cc0b93367eb7f3e1 Mon Sep 17 00:00:00 2001 +From baf1699534cffe5b9394ab52b2c3725af933e03c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 325764b3a20a16a7a997a324cc0b93367eb7f3e1 ] + @@ -33 +34,0 @@ -Cc: stable@dpdk.org @@ -42 +43 @@ -index b5f6049a91..2cb602a358 100644 +index a12ea39444..b244d45abb 100644 @@ -45 +46 @@ -@@ -633,7 +633,8 @@ iavf_dev_init_vlan(struct rte_eth_dev *dev) +@@ -609,7 +609,8 @@ iavf_dev_init_vlan(struct rte_eth_dev *dev) @@ -55 +56 @@ -@@ -709,9 +710,7 @@ iavf_dev_configure(struct rte_eth_dev *dev) +@@ -685,9 +686,7 @@ iavf_dev_configure(struct rte_eth_dev *dev)