From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2EB6A43CAD for ; Thu, 14 Mar 2024 01:11:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2705342E63; Thu, 14 Mar 2024 01:11:45 +0100 (CET) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by mails.dpdk.org (Postfix) with ESMTP id 6F2AD40297 for ; Thu, 14 Mar 2024 01:11:43 +0100 (CET) Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-413ef6908ccso2466785e9.3 for ; Wed, 13 Mar 2024 17:11:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710375103; x=1710979903; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eNZX88kRxyArYMKRne7uf7L4/y9ebaMYuqUMxUHM+M0=; b=jCrDph3PWvOXkzXtY/5vAxqa6KDEvH+2NndXVdh/8K2W2eGtyunkstzL+mf6QnFdUS l5fCUcjzFfNqiZ95tm4AK8a1YGzEHW6moTKfVKB6CmVrp/Zhb6QmfgpN1l+5PiRB0zO1 Huh3Vc8ZUWjqrAOfGq4cNiQHfSYV0A9ZcEGwzeM7Xjz/iE/OllkIbe0L9kZCFiYTDhNv z6W3Ho/kdQvMI5QzeOpd+5GrSgMPAe4gH+9SxAxDOrPW+3GHDYOBJlNWxyvERMbo9K7+ 1vgqeKWhvF7ccsrWwmDs9uQoE0EaGa7b+65HXOagMfggoIB8GWJTXVXtiqs3SfWWz2NA Gb8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710375103; x=1710979903; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eNZX88kRxyArYMKRne7uf7L4/y9ebaMYuqUMxUHM+M0=; b=hdKCz7gUFw8FOaUCEZizR7ZXWBedNY+uBFuzNFIBnUlUoTvN2QRmnlNW0ibVaxWr9z sO/vEkJxTWCEIPYOOAhndc98gsXSyJJgduDNGoYynK/9dV6c1UnAzt5myqEGCaq/6PXD gEWhWtcPnJvyLB/ASheeThqBbbB6FWcLuYwGu0cCIzhQhQIxa/5gpa3py+LTtNB33CRy 3L53WsGQE+jGcIM+FxJzwiFp1VNglw2FvIMlswLiBDX9FE7y/euvt2RHv7A4lhEbvQR0 Jks1Zb3Sd6DgVilEDlOz+WJ9JkPPo2KDsPWoz+9eZiCVrLMqp9GqIqfOmQjRKaAIcOiB 7qYw== X-Gm-Message-State: AOJu0Yw0GqW+Fy7dICmz6Efa/wR7sLAi2pZLPc+6uS/NEAnqxGlL3BMK WW5IxVs4d8t7wSDpHQP/6HaUXoW4PmWV67lQfVu6tzfQBGhTugnFplo2oq5j X-Google-Smtp-Source: AGHT+IFBZO26gf9LLBHloujEn74fe45S+4R9wR0SvMm97r42LG829de2mcXDFEQbxXSXv9H22oeoog== X-Received: by 2002:a05:600c:198d:b0:413:f274:14a6 with SMTP id t13-20020a05600c198d00b00413f27414a6mr80933wmq.11.1710375103117; Wed, 13 Mar 2024 17:11:43 -0700 (PDT) Received: from localhost ([137.220.120.171]) by smtp.gmail.com with ESMTPSA id fk11-20020a05600c0ccb00b00413e523b7f9sm3810413wmb.43.2024.03.13.17.11.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 17:11:42 -0700 (PDT) From: luca.boccassi@gmail.com To: Nithin Dabilpuram Cc: dpdk stable Subject: patch 'common/cnxk: fix mbox struct attributes' has been queued to stable release 22.11.5 Date: Thu, 14 Mar 2024 00:09:29 +0000 Message-Id: <20240314000957.2810803-33-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240314000957.2810803-1-luca.boccassi@gmail.com> References: <20240307013159.1735343-102-luca.boccassi@gmail.com> <20240314000957.2810803-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/16/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/430b2766cea6a892b22b0ca09f5d8fafa43831b9 Thanks. Luca Boccassi --- >From 430b2766cea6a892b22b0ca09f5d8fafa43831b9 Mon Sep 17 00:00:00 2001 From: Nithin Dabilpuram Date: Mon, 26 Feb 2024 19:05:34 +0530 Subject: [PATCH] common/cnxk: fix mbox struct attributes [ upstream commit c9dca1c5e352008bda8d0edeab8fbcf328437282 ] IO attribute is needed to mbox structs to avoid unaligned or pair access causing by compiler optimization. Add them to structs where it is missing. Fixes: 503b82de2cbf ("common/cnxk: add mbox request and response definitions") Fixes: ddf955d3917e ("common/cnxk: support CPT second pass") Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_mbox.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/common/cnxk/roc_mbox.h b/drivers/common/cnxk/roc_mbox.h index 18aa97b84a..9fc22d8a65 100644 --- a/drivers/common/cnxk/roc_mbox.h +++ b/drivers/common/cnxk/roc_mbox.h @@ -855,12 +855,12 @@ struct nix_cn10k_aq_enq_req { struct nix_cn10k_aq_enq_rsp { struct mbox_msghdr hdr; union { - struct nix_cn10k_rq_ctx_s rq; - struct nix_cn10k_sq_ctx_s sq; - struct nix_cq_ctx_s cq; - struct nix_rsse_s rss; - struct nix_rx_mce_s mce; - struct nix_band_prof_s prof; + __io struct nix_cn10k_rq_ctx_s rq; + __io struct nix_cn10k_sq_ctx_s sq; + __io struct nix_cq_ctx_s cq; + __io struct nix_rsse_s rss; + __io struct nix_rx_mce_s mce; + __io struct nix_band_prof_s prof; }; }; @@ -1096,11 +1096,11 @@ struct nix_rq_cpt_field_mask_cfg_req { #define RQ_CTX_MASK_MAX 6 union { uint64_t __io rq_ctx_word_set[RQ_CTX_MASK_MAX]; - struct nix_cn10k_rq_ctx_s rq_set; + __io struct nix_cn10k_rq_ctx_s rq_set; }; union { uint64_t __io rq_ctx_word_mask[RQ_CTX_MASK_MAX]; - struct nix_cn10k_rq_ctx_s rq_mask; + __io struct nix_cn10k_rq_ctx_s rq_mask; }; struct nix_lf_rx_ipec_cfg1_req { uint32_t __io spb_cpt_aura; -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-14 00:09:22.226841707 +0000 +++ 0033-common-cnxk-fix-mbox-struct-attributes.patch 2024-03-14 00:09:20.617615301 +0000 @@ -1 +1 @@ -From c9dca1c5e352008bda8d0edeab8fbcf328437282 Mon Sep 17 00:00:00 2001 +From 430b2766cea6a892b22b0ca09f5d8fafa43831b9 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c9dca1c5e352008bda8d0edeab8fbcf328437282 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 4b4f48e372..d8a8494ac4 100644 +index 18aa97b84a..9fc22d8a65 100644 @@ -23 +24 @@ -@@ -1427,12 +1427,12 @@ struct nix_cn10k_aq_enq_req { +@@ -855,12 +855,12 @@ struct nix_cn10k_aq_enq_req { @@ -42 +43 @@ -@@ -1668,11 +1668,11 @@ struct nix_rq_cpt_field_mask_cfg_req { +@@ -1096,11 +1096,11 @@ struct nix_rq_cpt_field_mask_cfg_req {