From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D49ED43CAD for ; Thu, 14 Mar 2024 01:11:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF2E642E5D; Thu, 14 Mar 2024 01:11:59 +0100 (CET) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by mails.dpdk.org (Postfix) with ESMTP id C360842E40 for ; Thu, 14 Mar 2024 01:11:57 +0100 (CET) Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-413f1a4dcc9so773755e9.1 for ; Wed, 13 Mar 2024 17:11:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710375117; x=1710979917; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4azbM8uLvj4IWEnfC/mmlrtjEEoaUJXRa1+engP6tvA=; b=Plqra4rT9rh71hphUTzoNEhxA3AvHYlLMUYxQ5zaxu2y+kjYg6JEaRGKPYGj2fsmNK z8F3cZkjkTiJcadxeyFMW33w6hB1UOF0dqdqQb9AdDetQpNW4ow0h3DuX69UhbBmcKj5 vkW8bYVNcik1v1ynMBu3hSAjVTfGD0RgebS0n0iPyA49g0kMuGcDTFUL2XKJ/PFMr3sS f8A2ubVHkrQ4sL7AOjXi7fQxhjQIByTulcizRwewNzlWUhfS1gcppD6Rc8+xTQiKSckV ZuvG0eAdvULGqAIm0mYDPu1fDybU7765tga4MlU0qmo7v/fOO4YwoNOF0X4UQDtnDHZ8 c4fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710375117; x=1710979917; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4azbM8uLvj4IWEnfC/mmlrtjEEoaUJXRa1+engP6tvA=; b=E9nBuMAPcEMzCStLd1lQ1S079f9y0FQhKVv/SzPIghPO7w3QjlHKz7TgHPLvGFkhdP k+dkrbyLzLCNVVUzwyNAUKLd3Pdtrvpabzfo/b+iAtaEqeCNdD/YPkuHAtO+yEwAIE1c BC1WyzqKDhEaUlEr9uSx51Pb8qPffA8YAS4GWOOA9ZgHguYUtJUbW1r//KQu0M10m5+1 q2RpYwj0PyehpzYTbe5rN/rrS/AfT6FsnoqGvpGugjSiGPHxVaHLw/LTx2og196z6lj3 AgUW+StQYXEVwKMBSYdm3Q57ytwtCQPD4buO/x1/WQsZPeQQ5W86XDkhDr/y+hVAs68m Y4dA== X-Forwarded-Encrypted: i=1; AJvYcCXygTtkURLUAOv1wNWBgmHhu2JD20d5RHs2d4uPzeWWoh4idjLXnWzG5FS9Z3kYdL9yPnNCKEDfzlY0MuJEZEo= X-Gm-Message-State: AOJu0YzgjaSJpWNPfTvruKwY6Lm1L+dbeepugrDzKjCOvHYl2HVmAVlE BCYMkH9IsJECjX9/BC+44rNE2SGVdbD3NrHBs/sfOEgc2G+aowMvvWap1s7+ X-Google-Smtp-Source: AGHT+IFJ1lceBS/zq86dSW7Myi80DcZoJ1J2vW0qAuNji7Kpkx6C//PTdK77nESwEGdVBF2AZHm37Q== X-Received: by 2002:a05:600c:3d05:b0:413:18f7:907 with SMTP id bh5-20020a05600c3d0500b0041318f70907mr189512wmb.25.1710375117395; Wed, 13 Mar 2024 17:11:57 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:7aef:1aaa:3dff:d546]) by smtp.gmail.com with ESMTPSA id l12-20020a05600c4f0c00b004122b7a680dsm601669wmq.21.2024.03.13.17.11.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 17:11:56 -0700 (PDT) From: luca.boccassi@gmail.com To: Satheesh Paul Cc: Nithin Dabilpuram , dpdk stable Subject: patch 'common/cnxk: remove dead code' has been queued to stable release 22.11.5 Date: Thu, 14 Mar 2024 00:09:32 +0000 Message-Id: <20240314000957.2810803-36-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240314000957.2810803-1-luca.boccassi@gmail.com> References: <20240307013159.1735343-102-luca.boccassi@gmail.com> <20240314000957.2810803-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/16/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/a1f69f50e1dec75963188bc84e2f69c816815ad9 Thanks. Luca Boccassi --- >From a1f69f50e1dec75963188bc84e2f69c816815ad9 Mon Sep 17 00:00:00 2001 From: Satheesh Paul Date: Fri, 1 Mar 2024 09:05:33 +0530 Subject: [PATCH] common/cnxk: remove dead code [ upstream commit 1ded7ef41ac888eb5e804d3337be687e5ebd324d ] Removed dead code reported by Coverity. Coverity issue: 380992 Fixes: da1ec39060b2 ("common/cnxk: delay inline device RQ enable to dev start") Signed-off-by: Satheesh Paul Reviewed-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix_inl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_inl.c b/drivers/common/cnxk/roc_nix_inl.c index 92ff44888d..15fec65d93 100644 --- a/drivers/common/cnxk/roc_nix_inl.c +++ b/drivers/common/cnxk/roc_nix_inl.c @@ -399,8 +399,7 @@ roc_nix_reassembly_configure(uint32_t max_wait_time, uint16_t max_frags) return -EFAULT; PLT_SET_USED(max_frags); - if (idev == NULL) - return -ENOTSUP; + roc_cpt = idev->cpt; if (!roc_cpt) { plt_err("Cannot support inline inbound, cryptodev not probed"); -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-14 00:09:22.356917506 +0000 +++ 0036-common-cnxk-remove-dead-code.patch 2024-03-14 00:09:20.625615459 +0000 @@ -1 +1 @@ -From 1ded7ef41ac888eb5e804d3337be687e5ebd324d Mon Sep 17 00:00:00 2001 +From a1f69f50e1dec75963188bc84e2f69c816815ad9 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 1ded7ef41ac888eb5e804d3337be687e5ebd324d ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index a205c658e9..7dbeae5017 100644 +index 92ff44888d..15fec65d93 100644 @@ -22 +23 @@ -@@ -677,8 +677,7 @@ roc_nix_reassembly_configure(uint32_t max_wait_time, uint16_t max_frags) +@@ -399,8 +399,7 @@ roc_nix_reassembly_configure(uint32_t max_wait_time, uint16_t max_frags)