From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F332C43CAE for ; Thu, 14 Mar 2024 01:12:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D464A42E73; Thu, 14 Mar 2024 01:12:38 +0100 (CET) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by mails.dpdk.org (Postfix) with ESMTP id 27E2340297 for ; Thu, 14 Mar 2024 01:12:37 +0100 (CET) Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-513a81b717cso573062e87.0 for ; Wed, 13 Mar 2024 17:12:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710375156; x=1710979956; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4bwIbgmu33LWmnmLK73PRd4HFHFEznmDtcqi9HDX92w=; b=lkpzxevuUC7H9kp68CGARDhNSP9M+EdwqPlBeKlsObiwcpNS84JIwXf1UX5qEu7S+Q MbcmemvdXOMKsqnrd3KvU3uvpPhhN9skkS4giZ1ks7NpN9heyfgR63drKGpActQ5nT00 i7FO9GCzHcCMH/1MFcQ1qdnhAAu01VDJvN+OZ6EwwO5Qf2EufMROEmWdnYfgjCGJgPTu 8fGGbmc4DjdLl71DDTAB3vp45T3ZhbS68/iKcCh70qVmz6cC1xEpJ5PGqwXrxIuJHFb+ hncJpqOFiuRiCMFnywlVAkiblg+TtHNsYKrknQ8SkqHOcmj6XNyOWQZFei3+t5sdxPs/ sofA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710375156; x=1710979956; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4bwIbgmu33LWmnmLK73PRd4HFHFEznmDtcqi9HDX92w=; b=LDU2z+riF2FUcxUZzHyuI2soRv55btfMO8XVguhFTOUqTno+k0H1G8mg4LqrDpxGx2 4lb3XeBhaChUFbyIgskltha5pCk0zsnM0+3ZquoV6LHpxORh8alYFJQiC28NpBbuIzhT zH+GmfiEeOW4Knniy5eEujH9Pg5V4gjori9YxsKV5XB+8gxCItsyS5HeSof6hjwZKfXJ 31lcaL/3w8x0mnCzG8MJffwzIap6TkaZ2gr5pzevDp5dbcqL6F2Mkm5PP5rxzQYbG+0l RuRg2qFPkA2yq3TIg6Y07H/yP82UCmAXngT4ewBGDVI2wKnjNzjGnFgdYQp6Kd1m0UQe t2ew== X-Forwarded-Encrypted: i=1; AJvYcCWDhcFm6s2LGxysDrzFobtgIVJSi3Eyz9jvawxXlfiVXty8aQJqndDWuwR1wLKhveeXIlTQ03RLD4IfFjM+KJE= X-Gm-Message-State: AOJu0YwNbb43sK1NOY8STKd7dFkAcPMw9eV1PNbVN5T2hAulUS8T27A6 tRv/Sbz8Rw7VUsWp9FfDek85Z0ixHyIz1vLMZRgddIKGSxFCi8vo X-Google-Smtp-Source: AGHT+IEPQF4ue4XnkaJ2u0J7qz4qw82An3ySa6QquHX/FcAOuvxC7OxlxFoJFyRiSHkHLSudsN1f6Q== X-Received: by 2002:a19:5f03:0:b0:513:c7c7:8799 with SMTP id t3-20020a195f03000000b00513c7c78799mr47784lfb.58.1710375156493; Wed, 13 Mar 2024 17:12:36 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:7aef:1aaa:3dff:d546]) by smtp.gmail.com with ESMTPSA id f10-20020a5d4dca000000b0033e95bf4796sm294831wru.27.2024.03.13.17.12.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 17:12:35 -0700 (PDT) From: luca.boccassi@gmail.com To: Bing Zhao Cc: Ori Kam , dpdk stable Subject: patch 'net/mlx5: remove device status check in flow creation' has been queued to stable release 22.11.5 Date: Thu, 14 Mar 2024 00:09:46 +0000 Message-Id: <20240314000957.2810803-50-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240314000957.2810803-1-luca.boccassi@gmail.com> References: <20240307013159.1735343-102-luca.boccassi@gmail.com> <20240314000957.2810803-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/16/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/fccac369b501cd5dff9c89326f5c307155030717 Thanks. Luca Boccassi --- >From fccac369b501cd5dff9c89326f5c307155030717 Mon Sep 17 00:00:00 2001 From: Bing Zhao Date: Thu, 29 Feb 2024 12:51:56 +0100 Subject: [PATCH] net/mlx5: remove device status check in flow creation [ upstream commit 4095ce34095e33ae9e8b19150b9280ff8737a590 ] The flow rule can be inserted even before the device started. The only exception is for a queue or RSS action. For the other interfaces of template API, the start status is not checked. The checking would cause some cache miss or eviction since the flag locates on some other cache line. Fixes: f1fecffa88df ("net/mlx5: support Direct Rules action template API") Signed-off-by: Bing Zhao Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow_hw.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index fe50d23987..20fa4eee0c 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -2514,10 +2514,6 @@ flow_hw_async_flow_create(struct rte_eth_dev *dev, uint32_t flow_idx; int ret; - if (unlikely((!dev->data->dev_started))) { - rte_errno = EINVAL; - goto error; - } if (unlikely(!priv->hw_q[queue].job_idx)) { rte_errno = ENOMEM; goto error; -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-14 00:09:23.009107573 +0000 +++ 0050-net-mlx5-remove-device-status-check-in-flow-creation.patch 2024-03-14 00:09:20.705617048 +0000 @@ -1 +1 @@ -From 4095ce34095e33ae9e8b19150b9280ff8737a590 Mon Sep 17 00:00:00 2001 +From fccac369b501cd5dff9c89326f5c307155030717 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4095ce34095e33ae9e8b19150b9280ff8737a590 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -19,2 +20,2 @@ - drivers/net/mlx5/mlx5_flow_hw.c | 5 ----- - 1 file changed, 5 deletions(-) + drivers/net/mlx5/mlx5_flow_hw.c | 4 ---- + 1 file changed, 4 deletions(-) @@ -23 +24 @@ -index 6f43e88864..8ca866059d 100644 +index fe50d23987..20fa4eee0c 100644 @@ -26,2 +27,2 @@ -@@ -3526,11 +3526,6 @@ flow_hw_async_flow_create(struct rte_eth_dev *dev, - uint32_t res_idx = 0; +@@ -2514,10 +2514,6 @@ flow_hw_async_flow_create(struct rte_eth_dev *dev, + uint32_t flow_idx; @@ -31,3 +32,2 @@ -- rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, -- "Port must be started before enqueueing flow operations"); -- return NULL; +- rte_errno = EINVAL; +- goto error; @@ -35,2 +35,2 @@ - flow = mlx5_ipool_malloc(table->flow, &flow_idx); - if (!flow) + if (unlikely(!priv->hw_q[queue].job_idx)) { + rte_errno = ENOMEM;