From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E97643CAD for ; Thu, 14 Mar 2024 01:13:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3436942E40; Thu, 14 Mar 2024 01:13:06 +0100 (CET) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mails.dpdk.org (Postfix) with ESMTP id 3A5CD40297 for ; Thu, 14 Mar 2024 01:13:04 +0100 (CET) Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-33e9ba0eadcso283189f8f.2 for ; Wed, 13 Mar 2024 17:13:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710375184; x=1710979984; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YbJoWtvqEP542KeDsqq9814lBwQ79eehK1T601ru88Q=; b=d6ib9A6MZW3UI445Vfng4QeFrFn9pJSH/0btyqU04mbuUuWVg0JtQ/qQooPwp5oZUB R2+ZfR+iLWNALpErK04bXxflW388gVZ3/n9T3KWgi+EVC1NW3LczH2c4ggoF+CSqRP9Z HgEthpcyVkWUx0sNM2mNW1CUKZtTQzrNR4GD2OHRJ5QEq2Oxh8NinSrhTq/VjmqHNnUn IwVbIL/p/2o8zNwriH/Avh09UEV4+XxX6GmVuj91piu/PSy9o2rZl9KO8Ojf004GD3nZ vnWUnNQvxFBJib1dOQtxUzjZzBOiLWCsqHxixJWpPXjRALjW4440sbfvWnDL6w5OGRW/ +aFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710375184; x=1710979984; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YbJoWtvqEP542KeDsqq9814lBwQ79eehK1T601ru88Q=; b=gK1Fiy62pcMrnMrSOrL2PFjQjo6ZfP/7QCm6+CWeC8Oh6yo/ZXbiFLglZpj9RX9gS1 ChJU3fUoPRPuode0c03vchwCBnJ+06nqQbUepq+mEyuCpWRO+cZSQnWXzTKzlz3PHYL0 WsMBZiw1lrBpSj/PHwAPw1hq4cHDCR9f0RUFUdfV95jPDNs+HNig4GhSpU4s5dZUB5uH cX0EmdCAhb/rXa/mucFgVbLzIDal331ShkCfs2VvQ6FMrH0Emxupgbzhuz4z8gGYUmzT MlWxwIRqRIZTeajJySvj0DaTLprQvFlW4O0/GKlr1FcIe0DnlxvEh8+0REiUiFzSXi/m 5AwQ== X-Gm-Message-State: AOJu0YyuwKSe13hAhnQhHsLve9A/sDgPuEG5KT/GFeJ1tda31JsAD7Sh VofhgYRaxIU/UJjM7kcnqzAr6QQqDEs5KUxddjHDzGPWMKUtQLNA X-Google-Smtp-Source: AGHT+IF7hjgTPc1bNZJzEW9wR2dpdKBWGBuxLp6jruSo9MHnBqa3wmiMr54ejWuSTEqucSAiTpqIrw== X-Received: by 2002:a05:6000:4:b0:33d:2885:ce58 with SMTP id h4-20020a056000000400b0033d2885ce58mr76287wrx.5.1710375183674; Wed, 13 Mar 2024 17:13:03 -0700 (PDT) Received: from localhost ([137.220.120.171]) by smtp.gmail.com with ESMTPSA id o19-20020adf8b93000000b0033e43756d11sm289545wra.85.2024.03.13.17.13.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 17:13:03 -0700 (PDT) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: dpdk stable Subject: patch 'net/tap: log Netlink extended ack unavailability' has been queued to stable release 22.11.5 Date: Thu, 14 Mar 2024 00:09:52 +0000 Message-Id: <20240314000957.2810803-56-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240314000957.2810803-1-luca.boccassi@gmail.com> References: <20240307013159.1735343-102-luca.boccassi@gmail.com> <20240314000957.2810803-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/16/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/49989423d04abd4caa1564786290a548877122f4 Thanks. Luca Boccassi --- >From 49989423d04abd4caa1564786290a548877122f4 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Fri, 1 Mar 2024 09:57:07 -0800 Subject: [PATCH] net/tap: log Netlink extended ack unavailability [ upstream commit 59c1eb37478b2ee30f5821bd4fc46b3de5929121 ] If kernel doesn't support external ack, log that to aide in any problem diagnosis. Coverity issue: 362848 Fixes: 647909bcf34b ("net/tap: use netlink extended ack support") Signed-off-by: Stephen Hemminger --- drivers/net/tap/tap_netlink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/tap/tap_netlink.c b/drivers/net/tap/tap_netlink.c index 75af3404b0..d9c260127d 100644 --- a/drivers/net/tap/tap_netlink.c +++ b/drivers/net/tap/tap_netlink.c @@ -72,7 +72,8 @@ tap_nl_init(uint32_t nl_groups) #ifdef NETLINK_EXT_ACK /* Ask for extended ACK response. on older kernel will ignore request. */ - setsockopt(fd, SOL_NETLINK, NETLINK_EXT_ACK, &one, sizeof(one)); + if (setsockopt(fd, SOL_NETLINK, NETLINK_EXT_ACK, &one, sizeof(one)) < 0) + TAP_LOG(NOTICE, "Unable to request netlink error information"); #endif if (bind(fd, (struct sockaddr *)&local, sizeof(local)) < 0) { -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-14 00:09:23.237634269 +0000 +++ 0056-net-tap-log-Netlink-extended-ack-unavailability.patch 2024-03-14 00:09:20.709617127 +0000 @@ -1 +1 @@ -From 59c1eb37478b2ee30f5821bd4fc46b3de5929121 Mon Sep 17 00:00:00 2001 +From 49989423d04abd4caa1564786290a548877122f4 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,2 @@ + +[ upstream commit 59c1eb37478b2ee30f5821bd4fc46b3de5929121 ]