From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7863243CAD for ; Thu, 14 Mar 2024 01:13:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C6B242E7C; Thu, 14 Mar 2024 01:13:07 +0100 (CET) Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) by mails.dpdk.org (Postfix) with ESMTP id 9192942E7C for ; Thu, 14 Mar 2024 01:13:06 +0100 (CET) Received: by mail-vs1-f43.google.com with SMTP id ada2fe7eead31-47268928105so99958137.1 for ; Wed, 13 Mar 2024 17:13:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710375186; x=1710979986; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vm0D4MEIBGxB4C1XWhZrPjBxtCI+R8qZ1wBBf0t1WUY=; b=bk4MqyIcvCbaLVYZp1eV4SQl4o6hE8ZP8QmhuFia30gP+PQvtKOBWzLRYf5cuSfrD9 TUwBhbU+bd2gGGaKKbvTFWvJM8DQpx2Y8Rs/syUL5H/zNoVNe7L2obDovJoQSaYQRmer SaHbJgVH3GnjTpCV0J0CSqrHRlSqlfdHbzhGuwOnhNyguAm2PnRkjhb8JG9YPSe9K8Dl /vSYc87J+fejlqj4OiTK8wwwp+hppmwDTYJHWWbrF3v2ydCGUNIfTbUDmuxSQtaQLnpV AzshlXssVAFHncK1bpGabBafhODfStesYafHXoiwyj2fe4t3L2TmxqJSgmSvysNukO4F EsrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710375186; x=1710979986; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vm0D4MEIBGxB4C1XWhZrPjBxtCI+R8qZ1wBBf0t1WUY=; b=kgiAsbl+P4lNycdCnBZsiyWPBMSxRS74HvHgA8O5JJwjfFQ5/pFckiJzrDAedsWSLI 3XZKTPd47TDk90af/q+MdgZFmBveCvG1qsthMuNm5qLTDeue2Pt5QQjdR6XL8Qw1A14z xoQ+zWMcNrWIfAnc75ivlB4Cwe83FHSUx5g1aKZALDl2wtb1tKDiOmAxhrECUQCbKw44 0DjH8ETV6QePfXJRQebBAERpTuXmpAXrIwXcT47mWUh+YSfhPTn2SVsjOYlpaNuChoCk smRklbJPHzLP1bz9blT7jvIdm6djK0SMpKTuCGx7HoRN4Sf0TWT0Nat9xiK+KruAOEX1 Bkrw== X-Forwarded-Encrypted: i=1; AJvYcCWhG+4eqE93jA8KyMUzgvIWiMs58mvvU2dFeZPcUtFZD+NwQ/qRVKbNvHQ6by4yBfbBB9sy8RYU2uZUE+IFMdY= X-Gm-Message-State: AOJu0YwFnNPoIGcMqUURTyPpnNV9TQDw9mvJh+IXqiPVqyAVbs3vek/v 2SArfXOY1bVQt3bgoKiEwt3rmZPGdb2ULaxXj5QsvlRsmy5/R0IP X-Google-Smtp-Source: AGHT+IG1UasLGs8z+eC+QNQSiGYroElzMs2bJjOhNjhN8+7mkyWBcbyCFt9HA6FT9oo7ILfqBF2IXg== X-Received: by 2002:ac5:ca07:0:b0:4c8:90e5:6790 with SMTP id c7-20020ac5ca07000000b004c890e56790mr474626vkm.5.1710375185762; Wed, 13 Mar 2024 17:13:05 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:7aef:1aaa:3dff:d546]) by smtp.gmail.com with ESMTPSA id 11-20020a0562140ccb00b00690d4695a27sm196769qvx.83.2024.03.13.17.13.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 17:13:05 -0700 (PDT) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: Tyler Retzlaff , Nicolas Chautru , dpdk stable Subject: patch 'baseband/fpga_5gnr_fec: use a better random generator' has been queued to stable release 22.11.5 Date: Thu, 14 Mar 2024 00:09:53 +0000 Message-Id: <20240314000957.2810803-57-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240314000957.2810803-1-luca.boccassi@gmail.com> References: <20240307013159.1735343-102-luca.boccassi@gmail.com> <20240314000957.2810803-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/16/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/bd47e113a2b12529ab0b8b46824980d9f90e1ad2 Thanks. Luca Boccassi --- >From bd47e113a2b12529ab0b8b46824980d9f90e1ad2 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Fri, 1 Mar 2024 09:57:11 -0800 Subject: [PATCH] baseband/fpga_5gnr_fec: use a better random generator [ upstream commit dd329b2cc53dd61156b0227b0b858f9b17215574 ] The function rand is very weak and should not be used. Use the DPDK rte_rand() which is seeded from entropy instead. Coverity issue: 414987 Fixes: b3d326e438f1 ("baseband/fpga_5gnr_fec: add FPGA mutex") Signed-off-by: Stephen Hemminger Reviewed-by: Tyler Retzlaff Acked-by: Nicolas Chautru --- drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c index 0dfeba08e1..171aed4d86 100644 --- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c +++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c @@ -16,6 +16,7 @@ #ifdef RTE_BBDEV_OFFLOAD_COST #include #endif +#include #include #include @@ -1502,7 +1503,7 @@ fpga_mutex_acquisition(struct fpga_queue *q) { uint32_t mutex_ctrl, mutex_read, cnt = 0; /* Assign a unique id for the duration of the DDR access */ - q->ddr_mutex_uuid = rand(); + q->ddr_mutex_uuid = rte_rand(); /* Request and wait for acquisition of the mutex */ mutex_ctrl = (q->ddr_mutex_uuid << 16) + 1; do { -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-14 00:09:23.273972879 +0000 +++ 0057-baseband-fpga_5gnr_fec-use-a-better-random-generator.patch 2024-03-14 00:09:20.713617206 +0000 @@ -1 +1 @@ -From dd329b2cc53dd61156b0227b0b858f9b17215574 Mon Sep 17 00:00:00 2001 +From bd47e113a2b12529ab0b8b46824980d9f90e1ad2 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit dd329b2cc53dd61156b0227b0b858f9b17215574 ] + @@ -20 +22 @@ -index efc1d3a772..9b253cde28 100644 +index 0dfeba08e1..171aed4d86 100644 @@ -23,3 +25,2 @@ -@@ -14,6 +14,7 @@ - #include - #include +@@ -16,6 +16,7 @@ + #ifdef RTE_BBDEV_OFFLOAD_COST @@ -26,0 +28 @@ + #endif @@ -31 +33 @@ -@@ -1990,7 +1991,7 @@ fpga_5gnr_mutex_acquisition(struct fpga_5gnr_queue *q) +@@ -1502,7 +1503,7 @@ fpga_mutex_acquisition(struct fpga_queue *q)