From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 192DC43CAD for ; Thu, 14 Mar 2024 01:10:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1160140297; Thu, 14 Mar 2024 01:10:20 +0100 (CET) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mails.dpdk.org (Postfix) with ESMTP id 0DF414021E for ; Thu, 14 Mar 2024 01:10:18 +0100 (CET) Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-413f1853bf3so1010895e9.0 for ; Wed, 13 Mar 2024 17:10:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710375018; x=1710979818; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9wPTO1VPp+H1Rfq1cowLhBqH5WNkxcccVBGwUUZhFiA=; b=BSXyMiyzCFNieEguNi8pJDTGW0Pl1qt6GY5/Fr9v//IRDIsZZPluJYvh4U0WUy75wQ OdVZXWJYzGgwFE43FVkPz/LGyuQM69c3u+AzT9d5zMd7SY0QEucE50VegSQ26a1Kc6qW YqlDz6Ky7QdSkzz3PGYgFZhpNHmZoNw2jOVy+B1nd6myXop7buOH6eF3xy4UskbEJA4o q+IjcOm2en8B+Djx/Jg66VCxjZZ+ELnoV1LbR02GWykdaUVEPNVrCn9fv1OOUouNnGUu pbsQoJITAJx4zYcQ5rsUaEu/b8/8JcGwfqUV3Za1HH2Xh2nlgLGdgUnkrpQqB6DKTGs/ aBzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710375018; x=1710979818; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9wPTO1VPp+H1Rfq1cowLhBqH5WNkxcccVBGwUUZhFiA=; b=AGCxiYB0Rl9MHTY30bTJ3azEOT5l0LuXs/pQiaY8JqstE2oMhDSkeHToA170ufV8m2 kPK1wuzwKgywtnoLWEJfTauk4jBlpv3SFeBr8cSRe8JO+SEzsxHHy9+PbvAgmMzjyBbz YhhZOghxt+VdjDErKIwHsWUL5dMrtnMzjz2g/dQD8RkVNI8uKkH/l8Pif2SBkueZgXyZ czArOhvo8jlJFJsGnPDWRufLnyUklVgQjYassClgW2PcUG5nZRgWGivsp7A7W8qcYyAM MQDdhMgIZCEz8r/mOaEUxlrwmrpCDGrakeMMoLyvuxR8PjtBBt+NOwIkOofR8GsaTug5 hVVw== X-Forwarded-Encrypted: i=1; AJvYcCVJ8ceNbP0YC7xKvlraQTKd5kgXUMQnPKRA8mEYHcBFi6VHFPSPxhkFMEa1szROcP3+z7v8ZsFB8WzQdEG/FDY= X-Gm-Message-State: AOJu0Yyfng4hBGvXLnHcZi+QgPIXIw6oNjfVvTnEF4+o2y8DuUf4QEYe hRuRLroLuXUV/hBkkjb5OBnKNkKZIU14wObNN4ElC5dxbpzLyAoS X-Google-Smtp-Source: AGHT+IHELcQBi+UHCAhc+QYD4lfmuJN2o/BSQmgAGQtVuqXMQpSnvYA3h5LHTmYTezjuB3ZnwlB7eA== X-Received: by 2002:a05:600c:468a:b0:412:95fb:e41 with SMTP id p10-20020a05600c468a00b0041295fb0e41mr188966wmo.24.1710375017222; Wed, 13 Mar 2024 17:10:17 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:7aef:1aaa:3dff:d546]) by smtp.gmail.com with ESMTPSA id fm6-20020a05600c0c0600b00413f292abfasm104652wmb.11.2024.03.13.17.10.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 17:10:16 -0700 (PDT) From: luca.boccassi@gmail.com To: Ganapati Kundapura Cc: Pavan Nikhilesh , dpdk stable Subject: patch 'test/event: fix crash in Tx adapter freeing' has been queued to stable release 22.11.5 Date: Thu, 14 Mar 2024 00:09:02 +0000 Message-Id: <20240314000957.2810803-6-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240314000957.2810803-1-luca.boccassi@gmail.com> References: <20240307013159.1735343-102-luca.boccassi@gmail.com> <20240314000957.2810803-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/16/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/3cdb7e6d4482ef8a36871400d8bbdc606ec6efed Thanks. Luca Boccassi --- >From 3cdb7e6d4482ef8a36871400d8bbdc606ec6efed Mon Sep 17 00:00:00 2001 From: Ganapati Kundapura Date: Mon, 26 Feb 2024 02:30:03 -0600 Subject: [PATCH] test/event: fix crash in Tx adapter freeing [ upstream commit 1f85467fcaf03c6b0d879614ee18f9a98fe9e9e6 ] Uninitialized mbufs are enqueued to eventdev which causes segfault on freeing the mbuf in Tx adapter. Fixed by initializing mbufs before enqueuing to eventdev. Fixes: 46cf97e4bbfa ("eventdev: add test for eth Tx adapter") Signed-off-by: Ganapati Kundapura Acked-by: Pavan Nikhilesh --- app/test/test_event_eth_tx_adapter.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/test/test_event_eth_tx_adapter.c b/app/test/test_event_eth_tx_adapter.c index c19a87a86a..2aeb28d8e9 100644 --- a/app/test/test_event_eth_tx_adapter.c +++ b/app/test/test_event_eth_tx_adapter.c @@ -482,6 +482,10 @@ tx_adapter_service(void) int internal_port; uint32_t cap; + /* Initialize mbufs */ + for (i = 0; i < RING_SIZE; i++) + rte_pktmbuf_reset(&bufs[i]); + memset(&dev_conf, 0, sizeof(dev_conf)); err = rte_event_eth_tx_adapter_caps_get(TEST_DEV_ID, TEST_ETHDEV_ID, &cap); -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-14 00:09:21.088674900 +0000 +++ 0006-test-event-fix-crash-in-Tx-adapter-freeing.patch 2024-03-14 00:09:20.565614269 +0000 @@ -1 +1 @@ -From 1f85467fcaf03c6b0d879614ee18f9a98fe9e9e6 Mon Sep 17 00:00:00 2001 +From 3cdb7e6d4482ef8a36871400d8bbdc606ec6efed Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 1f85467fcaf03c6b0d879614ee18f9a98fe9e9e6 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index dbd22f6800..482b8e69e3 100644 +index c19a87a86a..2aeb28d8e9 100644 @@ -23 +24 @@ -@@ -484,6 +484,10 @@ tx_adapter_service(void) +@@ -482,6 +482,10 @@ tx_adapter_service(void)