From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22D3E43CE7 for ; Mon, 18 Mar 2024 16:40:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1DFCC40A4B; Mon, 18 Mar 2024 16:40:43 +0100 (CET) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mails.dpdk.org (Postfix) with ESMTP id A39F2402B8 for ; Mon, 18 Mar 2024 16:40:41 +0100 (CET) Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4140816539fso15748205e9.3 for ; Mon, 18 Mar 2024 08:40:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710776441; x=1711381241; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9eHHmBKNDJEA1vVbWDyKeuEjkp4ks6hQpCu9IqET5TM=; b=gAYqTakLcinZJGGXwUwxU+jIS60p/ts4QCTPMYfG3jeaEG8U60pC6cD9QfptD+j5Eu mXexSNOZ1ihS+z+m+CeSz/D7fykCGpm9GNEHNvc70rfy2fxrYipu43uSKhScIlNIDJ1t mJZap0R4fHaRsyftpvjlgCVq9/c4gQ1wmDXUiROjOtG/+YtEYRh722riMhzZYSM8tUTZ /o4u9P7PSASGjfJuKQolwI42reRU5Jaf/dPU4fEOXLJMbbKVgZ5m7iK34e4lJZfTs6+l wh02KwaMx7rewGmIIrwmxqQpt8STSb17IMFUCmAoZ+YDtACd+7fA/8lgtHs3oDNb+94f Subg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710776441; x=1711381241; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9eHHmBKNDJEA1vVbWDyKeuEjkp4ks6hQpCu9IqET5TM=; b=eCUrPt6C4JN0AM9BhXH+1XpZfUhtYw4vDNEYVx/FMoPaSb7mZNXo5yo+K+/hoLlnrl 0AYzjIPdaypm3c+5h7+ItrTO/GrmIq6G/M95X2jQ45fGFXpZ7V6CCAlcheg0fvbGG9k/ 5jiTil50mSLsTbdEb9113Je+oXQmiMKrA+cCNmVMgKQdtufL7x12VW+CWIYzGz2/YrWs FxEwDERqjfDOEymAaVg9xb8ig/JTvqmS7DJEAxJXtd5J4fQIPrO1hUnOmdMHK/vR2XeN r3d5eOtLE96QctKVhBIbT7x6MJhwSgo4TjVh3wLACZePos90Qxy/XnhfHLKw0nW5x+N4 VSaw== X-Forwarded-Encrypted: i=1; AJvYcCVUF1MyptNF8ev8BptW1A3GxNc5pWo79HQs1gks83LC8AqmkZIHfZzdHGnzlyNkxPs1m5cPuZnEF4S5v5Y1zUo= X-Gm-Message-State: AOJu0Yy2ZZQMWjD3eHrHri5byp3hTQi+e02XV1sTnDaUrEwR27uC+j7f Up8vRjO1/akqO9Q/kFtNG1X338sOx8zG/Wz0H4wszE9RX3vnznbeM3PaOL75/nk= X-Google-Smtp-Source: AGHT+IH5LOnwsgN2AjyzRILJfomKHO1sg5maNK++PyxmP5hDGBSA1BUqF6KaeNiEZxPQXnF3MS9h2w== X-Received: by 2002:a05:600c:1d09:b0:414:48f:a79f with SMTP id l9-20020a05600c1d0900b00414048fa79fmr5622409wms.35.1710776441278; Mon, 18 Mar 2024 08:40:41 -0700 (PDT) Received: from localhost ([137.220.120.171]) by smtp.gmail.com with ESMTPSA id fl25-20020a05600c0b9900b004140a3d34fasm6591836wmb.41.2024.03.18.08.40.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 08:40:40 -0700 (PDT) From: luca.boccassi@gmail.com To: Bing Zhao Cc: Suanming Mou , dpdk stable Subject: patch 'net/mlx5: fix drop action release timing' has been queued to stable release 22.11.5 Date: Mon, 18 Mar 2024 15:39:15 +0000 Message-Id: <20240318153919.3407921-25-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240318153919.3407921-1-luca.boccassi@gmail.com> References: <20240314000957.2810803-61-luca.boccassi@gmail.com> <20240318153919.3407921-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/20/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/905283004dcdfb919e005f55c9a89c8a9e10ed6a Thanks. Luca Boccassi --- >From 905283004dcdfb919e005f55c9a89c8a9e10ed6a Mon Sep 17 00:00:00 2001 From: Bing Zhao Date: Fri, 8 Mar 2024 05:22:37 +0200 Subject: [PATCH] net/mlx5: fix drop action release timing [ upstream commit 22a3761b782b7c46ca428209b15b4f7382a40a62 ] When creating the drop action Devx object, the global counter set is also used as in the regular or hairpin queue creation. The drop action should be destroyed before the global counter set release procedure. Or else, the counter set object is still referenced and cannot be released successfully. This would cause the counter set resources to be exhausted after starting and stopping the ports repeatedly. Fixes: 65b3cd0dc39b ("net/mlx5: create global drop action") Signed-off-by: Bing Zhao Acked-by: Suanming Mou --- drivers/net/mlx5/mlx5.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 4d76da484b..96e732950d 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -2084,12 +2084,12 @@ mlx5_dev_close(struct rte_eth_dev *dev) priv->txqs = NULL; } mlx5_proc_priv_uninit(dev); + if (priv->drop_queue.hrxq) + mlx5_drop_action_destroy(dev); if (priv->q_counters) { mlx5_devx_cmd_destroy(priv->q_counters); priv->q_counters = NULL; } - if (priv->drop_queue.hrxq) - mlx5_drop_action_destroy(dev); if (priv->mreg_cp_tbl) mlx5_hlist_destroy(priv->mreg_cp_tbl); mlx5_mprq_free_mp(dev); -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-18 12:58:40.381536566 +0000 +++ 0025-net-mlx5-fix-drop-action-release-timing.patch 2024-03-18 12:58:39.255348625 +0000 @@ -1 +1 @@ -From 22a3761b782b7c46ca428209b15b4f7382a40a62 Mon Sep 17 00:00:00 2001 +From 905283004dcdfb919e005f55c9a89c8a9e10ed6a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 22a3761b782b7c46ca428209b15b4f7382a40a62 ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index 8b54843a43..d1a63822a5 100644 +index 4d76da484b..96e732950d 100644 @@ -28 +29 @@ -@@ -2382,12 +2382,12 @@ mlx5_dev_close(struct rte_eth_dev *dev) +@@ -2084,12 +2084,12 @@ mlx5_dev_close(struct rte_eth_dev *dev)