patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Tom Jones <thj@freebsd.org>
Cc: Ferruh Yigit <ferruh.yigit@amd.com>, dpdk stable <stable@dpdk.org>
Subject: patch 'net/vmxnet3: ignore Rx queue interrupt setup on FreeBSD' has been queued to stable release 21.11.7
Date: Thu,  4 Apr 2024 10:51:45 +0100	[thread overview]
Message-ID: <20240404095155.155427-15-ktraynor@redhat.com> (raw)
In-Reply-To: <20240404095155.155427-1-ktraynor@redhat.com>

Hi,

FYI, your patch has been queued to stable release 21.11.7

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 04/09/24. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/2ee1c5556735ef6f2021a5357a72f8ab23a8c227

Thanks.

Kevin

---
From 2ee1c5556735ef6f2021a5357a72f8ab23a8c227 Mon Sep 17 00:00:00 2001
From: Tom Jones <thj@freebsd.org>
Date: Thu, 21 Mar 2024 10:31:33 +0000
Subject: [PATCH] net/vmxnet3: ignore Rx queue interrupt setup on FreeBSD

[ upstream commit 19fede459e0d22f5ac891366465dce07e68196bc ]

Interrupts disabled on FreeBSD for the vmxnet3 driver as they are not
supported. Rx queue interrupts were missed by this change, don't
attempt to enable them on FreeBSD.

Without this change applications enabling interrupts encounter an
immediate abort on FreeBSD.

Fixes: 40d5676ff1ea ("net/vmxnet3: fix initialization on FreeBSD")

Signed-off-by: Tom Jones <thj@freebsd.org>
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
---
 .mailmap                             | 1 +
 drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/.mailmap b/.mailmap
index 2e60e2b813..d7ac5b5247 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1390,4 +1390,5 @@ Tomasz Zawadzki <tomasz.zawadzki@intel.com>
 Tom Barbette <barbette@kth.se> <tom.barbette@ulg.ac.be>
 Tom Crugnale <tcrugnale@sandvine.com>
+Tom Jones <thj@freebsd.org>
 Tom Millington <tmillington@solarflare.com>
 Tom Rix <trix@redhat.com>
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index da9635507e..32d1036c4f 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -1690,4 +1690,5 @@ static int
 vmxnet3_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id)
 {
+#ifndef RTE_EXEC_ENV_FREEBSD
 	struct vmxnet3_hw *hw = dev->data->dev_private;
 
@@ -1695,4 +1696,5 @@ vmxnet3_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id)
 			    rte_intr_vec_list_index_get(dev->intr_handle,
 							       queue_id));
+#endif
 
 	return 0;
-- 
2.44.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2024-04-04 10:49:34.393440246 +0100
+++ 0015-net-vmxnet3-ignore-Rx-queue-interrupt-setup-on-FreeB.patch	2024-04-04 10:49:33.756457753 +0100
@@ -1 +1 @@
-From 19fede459e0d22f5ac891366465dce07e68196bc Mon Sep 17 00:00:00 2001
+From 2ee1c5556735ef6f2021a5357a72f8ab23a8c227 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 19fede459e0d22f5ac891366465dce07e68196bc ]
+
@@ -14 +15,0 @@
-Cc: stable@dpdk.org
@@ -24 +25 @@
-index a0b19832b5..491af1f6ff 100644
+index 2e60e2b813..d7ac5b5247 100644
@@ -27 +28 @@
-@@ -1459,4 +1459,5 @@ Tomasz Zawadzki <tomasz.zawadzki@intel.com>
+@@ -1390,4 +1390,5 @@ Tomasz Zawadzki <tomasz.zawadzki@intel.com>
@@ -34 +35 @@
-index 2707b25148..ce7c347254 100644
+index da9635507e..32d1036c4f 100644
@@ -37 +38 @@
-@@ -1937,4 +1937,5 @@ static int
+@@ -1690,4 +1690,5 @@ static int
@@ -43 +44 @@
-@@ -1942,4 +1943,5 @@ vmxnet3_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id)
+@@ -1695,4 +1696,5 @@ vmxnet3_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id)


  parent reply	other threads:[~2024-04-04  9:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-04  9:51 patch 'net/hns3: enable PFC for all user priorities' " Kevin Traynor
2024-04-04  9:51 ` patch 'doc: add traffic manager in features table' " Kevin Traynor
2024-04-04  9:51 ` patch 'doc: add link speeds configuration " Kevin Traynor
2024-04-04  9:51 ` patch 'net/ena/base: limit exponential backoff' " Kevin Traynor
2024-04-04  9:51 ` patch 'net/ena/base: restructure interrupt handling' " Kevin Traynor
2024-04-04  9:51 ` patch 'app/testpmd: fix --stats-period option check' " Kevin Traynor
2024-04-04  9:51 ` patch 'net/hns3: support new device' " Kevin Traynor
2024-04-04  9:51 ` patch 'doc: update link to Windows DevX in mlx5 guide' " Kevin Traynor
2024-04-04  9:51 ` patch 'net/mlx5: prevent ioctl failure log flooding' " Kevin Traynor
2024-04-04  9:51 ` patch 'net/mlx5: fix age position in hairpin split' " Kevin Traynor
2024-04-04  9:51 ` patch 'net/mlx5: fix drop action release timing' " Kevin Traynor
2024-04-04  9:51 ` patch 'net/mlx5: fix warning about copy length' " Kevin Traynor
2024-04-04  9:51 ` patch 'net/bnxt: fix number of Tx queues being created' " Kevin Traynor
2024-04-04 13:52   ` Kishore Padmanabha
2024-04-04  9:51 ` patch 'doc: fix default IP fragments maximum in programmer guide' " Kevin Traynor
2024-04-04  9:51 ` Kevin Traynor [this message]
2024-04-04  9:51 ` patch 'doc: fix typo in profiling " Kevin Traynor
2024-04-04  9:51 ` patch 'doc: fix typo in packet framework " Kevin Traynor
2024-04-04  9:51 ` patch 'test/power: fix typo in error message' " Kevin Traynor
2024-04-04  9:51 ` patch 'test/cfgfile: fix typo in error messages' " Kevin Traynor
2024-04-04  9:51 ` patch 'examples/ipsec-secgw: fix typo in error message' " Kevin Traynor
2024-04-04  9:51 ` patch 'net/nfp: fix resource leak for PF initialization' " Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240404095155.155427-15-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=ferruh.yigit@amd.com \
    --cc=stable@dpdk.org \
    --cc=thj@freebsd.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).