patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Shai Brandes <shaibran@amazon.com>
Cc: Amit Bernstein <amitbern@amazon.com>, dpdk stable <stable@dpdk.org>
Subject: patch 'net/ena/base: restructure interrupt handling' has been queued to stable release 21.11.7
Date: Thu,  4 Apr 2024 10:51:35 +0100	[thread overview]
Message-ID: <20240404095155.155427-5-ktraynor@redhat.com> (raw)
In-Reply-To: <20240404095155.155427-1-ktraynor@redhat.com>

Hi,

FYI, your patch has been queued to stable release 21.11.7

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 04/09/24. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/4db5876a5eb477cb22b4cca81e008b6e3db8183f

Thanks.

Kevin

---
From 4db5876a5eb477cb22b4cca81e008b6e3db8183f Mon Sep 17 00:00:00 2001
From: Shai Brandes <shaibran@amazon.com>
Date: Tue, 12 Mar 2024 20:07:00 +0200
Subject: [PATCH] net/ena/base: restructure interrupt handling

[ upstream commit 553653ccc18c1ed9fb0406e1b0130e945d5ab30f ]

When invoking an admin command, in interrupt mode, if the interrupt
is received after timeout and also after the calling function finished
running, the response will be written into a memory that is no longer
valid.

Fixes: 99ecfbf845b3 ("ena: import communication layer")

Signed-off-by: Shai Brandes <shaibran@amazon.com>
Reviewed-by: Amit Bernstein <amitbern@amazon.com>
---
 drivers/net/ena/base/ena_com.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c
index 4bd85f29f5..98035f3cd4 100644
--- a/drivers/net/ena/base/ena_com.c
+++ b/drivers/net/ena/base/ena_com.c
@@ -174,4 +174,5 @@ static void comp_ctxt_release(struct ena_com_admin_queue *queue,
 				     struct ena_comp_ctx *comp_ctx)
 {
+	comp_ctx->user_cqe = NULL;
 	comp_ctx->occupied = false;
 	ATOMIC32_DEC(&queue->outstanding_cmds);
@@ -467,4 +468,7 @@ static void ena_com_handle_single_admin_completion(struct ena_com_admin_queue *a
 	}
 
+	if (!comp_ctx->occupied)
+		return;
+
 	comp_ctx->status = ENA_CMD_COMPLETED;
 	comp_ctx->comp_status = cqe->acq_common_descriptor.status;
-- 
2.44.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2024-04-04 10:49:34.032128733 +0100
+++ 0005-net-ena-base-restructure-interrupt-handling.patch	2024-04-04 10:49:33.699457603 +0100
@@ -1 +1 @@
-From 553653ccc18c1ed9fb0406e1b0130e945d5ab30f Mon Sep 17 00:00:00 2001
+From 4db5876a5eb477cb22b4cca81e008b6e3db8183f Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 553653ccc18c1ed9fb0406e1b0130e945d5ab30f ]
+
@@ -12 +13,0 @@
-Cc: stable@dpdk.org
@@ -21 +22 @@
-index fb3ad27d0a..a0c88b1a0e 100644
+index 4bd85f29f5..98035f3cd4 100644
@@ -24 +25 @@
-@@ -182,4 +182,5 @@ static void comp_ctxt_release(struct ena_com_admin_queue *queue,
+@@ -174,4 +174,5 @@ static void comp_ctxt_release(struct ena_com_admin_queue *queue,
@@ -30 +31 @@
-@@ -475,4 +476,7 @@ static void ena_com_handle_single_admin_completion(struct ena_com_admin_queue *a
+@@ -467,4 +468,7 @@ static void ena_com_handle_single_admin_completion(struct ena_com_admin_queue *a


  parent reply	other threads:[~2024-04-04  9:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-04  9:51 patch 'net/hns3: enable PFC for all user priorities' " Kevin Traynor
2024-04-04  9:51 ` patch 'doc: add traffic manager in features table' " Kevin Traynor
2024-04-04  9:51 ` patch 'doc: add link speeds configuration " Kevin Traynor
2024-04-04  9:51 ` patch 'net/ena/base: limit exponential backoff' " Kevin Traynor
2024-04-04  9:51 ` Kevin Traynor [this message]
2024-04-04  9:51 ` patch 'app/testpmd: fix --stats-period option check' " Kevin Traynor
2024-04-04  9:51 ` patch 'net/hns3: support new device' " Kevin Traynor
2024-04-04  9:51 ` patch 'doc: update link to Windows DevX in mlx5 guide' " Kevin Traynor
2024-04-04  9:51 ` patch 'net/mlx5: prevent ioctl failure log flooding' " Kevin Traynor
2024-04-04  9:51 ` patch 'net/mlx5: fix age position in hairpin split' " Kevin Traynor
2024-04-04  9:51 ` patch 'net/mlx5: fix drop action release timing' " Kevin Traynor
2024-04-04  9:51 ` patch 'net/mlx5: fix warning about copy length' " Kevin Traynor
2024-04-04  9:51 ` patch 'net/bnxt: fix number of Tx queues being created' " Kevin Traynor
2024-04-04 13:52   ` Kishore Padmanabha
2024-04-04  9:51 ` patch 'doc: fix default IP fragments maximum in programmer guide' " Kevin Traynor
2024-04-04  9:51 ` patch 'net/vmxnet3: ignore Rx queue interrupt setup on FreeBSD' " Kevin Traynor
2024-04-04  9:51 ` patch 'doc: fix typo in profiling guide' " Kevin Traynor
2024-04-04  9:51 ` patch 'doc: fix typo in packet framework " Kevin Traynor
2024-04-04  9:51 ` patch 'test/power: fix typo in error message' " Kevin Traynor
2024-04-04  9:51 ` patch 'test/cfgfile: fix typo in error messages' " Kevin Traynor
2024-04-04  9:51 ` patch 'examples/ipsec-secgw: fix typo in error message' " Kevin Traynor
2024-04-04  9:51 ` patch 'net/nfp: fix resource leak for PF initialization' " Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240404095155.155427-5-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=amitbern@amazon.com \
    --cc=shaibran@amazon.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).