From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CEE6743DF8 for ; Thu, 4 Apr 2024 11:52:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9073740395; Thu, 4 Apr 2024 11:52:35 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 703EE40268 for ; Thu, 4 Apr 2024 11:52:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712224353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8OGL+SZHq1nSl2Lie5EBAfu8aMRuAbNWC56niCsCdQ0=; b=WnbXRfU/XhzK6iUFeXvrL/dt3uXvh/KeX0waOGyIF8pLfi3kipft8BRA65J2f6jce3BwWa a37DBpYPNpd+amNCHxHCwdST7znWrZhI+VL3062lCaNQPAPTEGVca0Rqx43yR56bxN4sA0 TQQS3OV6sq+X8ya3Gj2kirSzivgsfNY= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-452-UrIW_7H9OdqhSMIhwCP_mw-1; Thu, 04 Apr 2024 05:52:31 -0400 X-MC-Unique: UrIW_7H9OdqhSMIhwCP_mw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 714C2285F98F; Thu, 4 Apr 2024 09:52:31 +0000 (UTC) Received: from rh.Home (unknown [10.39.192.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id C40873C54; Thu, 4 Apr 2024 09:52:30 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Ferruh Yigit , dpdk stable Subject: patch 'app/testpmd: fix --stats-period option check' has been queued to stable release 21.11.7 Date: Thu, 4 Apr 2024 10:51:36 +0100 Message-ID: <20240404095155.155427-6-ktraynor@redhat.com> In-Reply-To: <20240404095155.155427-1-ktraynor@redhat.com> References: <20240404095155.155427-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/09/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/300a10e4d36f89d0064cc128e920592b51c7d334 Thanks. Kevin --- >From 300a10e4d36f89d0064cc128e920592b51c7d334 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 14 Mar 2024 10:17:02 +0100 Subject: [PATCH] app/testpmd: fix --stats-period option check [ upstream commit 2ae06c579ea4e1cd234c5b14bef2957ee154ec74 ] Rather than silently ignore an invalid value, raise an error for stats-period user input. Fixes: cfea1f3048d1 ("app/testpmd: print statistics periodically") Signed-off-by: David Marchand Acked-by: Ferruh Yigit --- app/test-pmd/parameters.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index 79ba728f69..a6a4bf80f3 100644 --- a/app/test-pmd/parameters.c +++ b/app/test-pmd/parameters.c @@ -769,5 +769,5 @@ launch_args_parse(int argc, char** argv) if ((optarg[0] == '\0') || (end == NULL) || (*end != '\0')) - break; + rte_exit(EXIT_FAILURE, "Invalid stats-period value\n"); stats_period = n; -- 2.44.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-04-04 10:49:34.084022513 +0100 +++ 0006-app-testpmd-fix-stats-period-option-check.patch 2024-04-04 10:49:33.701457608 +0100 @@ -1 +1 @@ -From 2ae06c579ea4e1cd234c5b14bef2957ee154ec74 Mon Sep 17 00:00:00 2001 +From 300a10e4d36f89d0064cc128e920592b51c7d334 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 2ae06c579ea4e1cd234c5b14bef2957ee154ec74 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 11b0cce577..d715750bb8 100644 +index 79ba728f69..a6a4bf80f3 100644 @@ -22 +23 @@ -@@ -777,5 +777,5 @@ launch_args_parse(int argc, char** argv) +@@ -769,5 +769,5 @@ launch_args_parse(int argc, char** argv)