From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <stable-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 156B143E24 for <public@inbox.dpdk.org>; Sun, 7 Apr 2024 19:04:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 10155402EF; Sun, 7 Apr 2024 19:04:50 +0200 (CEST) Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by mails.dpdk.org (Postfix) with ESMTP id EDAA04029A for <stable@dpdk.org>; Sun, 7 Apr 2024 19:04:47 +0200 (CEST) Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-5e42b4bbfa4so2396124a12.1 for <stable@dpdk.org>; Sun, 07 Apr 2024 10:04:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1712509487; x=1713114287; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=mkEQBy+jPbZ/oLkTVmc6PP+aW3TUzj3wCzs3gG8TZWw=; b=SgsfP57soQ6jIZKrkKOY74fkA6dqgBkq0ym9BxmAecPPE3QLmd34mJcAhk7IdJoSc7 HG3VbFlp1O/4f6FtjPGRePyeowOseV475+0aPu6xsgtS5x8HB1m+dh3OQQPkSIKz1kHk X2XDzfdzRfDn+lTPLV0Dpg4eufuf0MBZcNJaP5zWaiXaiCWIYp1V0IZbApldhaXsZVQq Kx85Q3HlVp4rsTEm09muUuFL4lqDDASkBxQdTvF3XndJ0OuYEEpDXZz7xKsF3uH3beWr ui/y0kxLGQz1RQhCxcJdvbUAkTu+Rh2DFKFxwRFhMe5sxM0EJiEyiwFHvEXcXaxeRBUe XWKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712509487; x=1713114287; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mkEQBy+jPbZ/oLkTVmc6PP+aW3TUzj3wCzs3gG8TZWw=; b=NvcfgQNCEQY0i8sS2YpSQOukdSXrgSo93x5eidE2twJoqGflequ4lD7KtNMk/gb2JF eNmZdJQCkKAlb04gyXjcCIv5RE7+2lQgoub+F6ZbyVjuNRMHKB1KjSvMG1CCBETXAr+I 9oHAubmZX+5oYzP3aZn3YmVfDAZjbz1Jfzc3mTW478Ovq/JpE9eA2CSnaZC6lfZWT/4a l3wtUoAjMZ9R5lM1HU9FAbC0x9SONnfpk1DEWPzn7ltelE346got5VfFyED5vTSMWyfu LhO7IfrePV/v56wHOpvW6kDvdwrI/1dArhG55FI1490HktC2VCb/dD/EzMe3EsWNN8DY SsMg== X-Forwarded-Encrypted: i=1; AJvYcCXjJS2ubPtBwcMsmqJRMgnffEdqz6vs6pGIjOkNHiMsMrRce1zA/hljF0QiEjWHJ+lJWI7zpw0vG1DZH4UO8cI= X-Gm-Message-State: AOJu0Yz15BEMk0gGGBvoNGN8zBAe5WTuM4Eu8wB9xJhzfeDGftjW4A/A 97WsxiSdGnujOq1cqf3bD7ms/in6sGVarbPftFKq2aJcs7Z04Fz/37n2Ki5o/Ws= X-Google-Smtp-Source: AGHT+IECbOuZ5KXWlYwWZY6vD8U2+QN1cxTaPnxE9MG6espmsiIGN0lmGl/U7GDC3UPMqNKQarDVyg== X-Received: by 2002:a17:903:124c:b0:1e2:a467:1b6b with SMTP id u12-20020a170903124c00b001e2a4671b6bmr9176781plh.16.1712509486928; Sun, 07 Apr 2024 10:04:46 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id y13-20020a170902ed4d00b001e27462b97fsm5138600plb.293.2024.04.07.10.04.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Apr 2024 10:04:46 -0700 (PDT) Date: Sun, 7 Apr 2024 10:04:46 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Ashish Sadanandan <ashish.sadanandan@gmail.com> Cc: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org, nelio.laranjeiro@6wind.com, stable@dpdk.org Subject: Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h Message-ID: <20240407100446.27783873@hermes.local> In-Reply-To: <CAN44U21xhoHSSNAA7gGPs=DkNagDAU82=OmtHizGqVLPtWBi0A@mail.gmail.com> References: <20240202051335.776290-1-ashish.sadanandan@gmail.com> <20240318024415.555614-1-ashish.sadanandan@gmail.com> <CAN44U22nVQ7Bytr3t8SYDkPHzsEiF-D8T=8LOb19vHPCGNaW0w@mail.gmail.com> <1836105.FMhQkTaH9n@thomas> <CAN44U21xhoHSSNAA7gGPs=DkNagDAU82=OmtHizGqVLPtWBi0A@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches <stable.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/stable>, <mailto:stable-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/stable/> List-Post: <mailto:stable@dpdk.org> List-Help: <mailto:stable-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/stable>, <mailto:stable-request@dpdk.org?subject=subscribe> Errors-To: stable-bounces@dpdk.org On Sat, 6 Apr 2024 19:30:38 -0600 Ashish Sadanandan <ashish.sadanandan@gmail.com> wrote: > On Wed, Apr 3, 2024 at 8:52=E2=80=AFAM Thomas Monjalon <thomas@monjalon.n= et> wrote: >=20 > > 02/04/2024 18:03, Ashish Sadanandan: =20 > > > Hi everyone, > > > I've made the updates as suggested. Could someone please review the = =20 > > latest =20 > > > patchset? Not sure if I followed the new patchset instructions correc= tly, > > > I've always had trouble with that part. =20 > > > > I remember we were discussing about aligning all files. > > I was waiting for a patch applying the rule we discussed. > > > > I missed the part where people were volunteering me for additional work= :) =20 >=20 > The consensus seems to be that the extern "C" directives should only be in > public headers, not private ones. Can you please tell me if there's an ea= sy > way to get a list of public headers? The issue for private headers that Tyler mentioned is that MS has private DPDK PMD's that are written in C++. Not sure if this needs to be considered or supported.