From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D630043E57 for ; Sat, 13 Apr 2024 15:00:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D116C40A80; Sat, 13 Apr 2024 15:00:02 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2085.outbound.protection.outlook.com [40.107.236.85]) by mails.dpdk.org (Postfix) with ESMTP id C82C4400D6 for ; Sat, 13 Apr 2024 15:00:01 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GzcEA+i3Vk7b3A8E976VsbNXKSsW4Ch93LOD2Oew0fUhl1bQXf/dt+D0MqqtoETN105Vwieej0MlF0DCRv08/jtHaBRC4a+gEpwsRo2U4noGK+z4JZPF7PnHO+/OLgx/JS0xkor5g2FdWSPreennK9iX1Rj03o5WBZhnyYKPEcRMZPD58e3fPw+2XngbOzu4CG6bKZ+/dPKGnHR65IVtwE4t6fTWsetNi3DaHK0a2FYNSs6vh7y2KwWbTsG0Z+h+J4OuYaXfO2Kul5BSdVhaJZ0xPb4EDtIsiiDvJUWUpp8RcKobO00myMbJZuDcTfI4ua68ifqzu9Wfn1y85vB+rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BbOjhyGbOICCBoNQmv//qAzidmAGF7Rj2Ah7uchPFjM=; b=EjzuOcXTZ0hz8nfvcRH/xRi8G2PyOIQ7GrRA4F/d4Jk8jS6wfes08k1xWppc/njd9yp9fcuRawwgA4O8EBGs2nA+72HeQnptyAcbcEBBOgy6Jl/pwETtCUxCmSSI8ZgfaqEShkDPwp5Tfox2Bz6CbqaMimNyYl/M2ad6gYb0Am9iTHUZg16kmV9VSwUmtNGIaHsN1wghDryubC3/MYoIpBv2owhavHFH2ocSYA7swodu1W9Ak8WheHBRLY4C95ZzrQk8WIvPBvJLG8tw5IVEPpt0RiUlE5XAlqnvq0SNAAXaU7Ntso/+XVtH/3Qr3bStsctV7dsFH7SWF/alEhEzcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BbOjhyGbOICCBoNQmv//qAzidmAGF7Rj2Ah7uchPFjM=; b=clzP22oJWrzLfP14sa0/rn96wAWpwHdnZqC583oyF5HQS/oqFLKr6uUcuLaG21FaFU+nJ766n0yYcGLc3NOUNHrjAZT/sh4tTSNV2vOgxj17+4rxUjZT1e76XuY4h+IJKAHBRPgqC4hUVfKDLqhZHxhwS9vJyMIieMkr6Com2gCeUGRsM81lyeT7YSs+6l/QgQQpVg2bPsDgcmAAxWl+LrnNU5tJkMvOyE/ZPnp2vWoks47s9f0lFm+vYarOCDXxBTksSEz0aGwvJSS8mzal9j+8QjLigGHaGw9onmAhio7LKF139+uD9Y6hwDUrKl8yQu0taxEnfrdk43ou0KOAoA== Received: from MW4PR03CA0079.namprd03.prod.outlook.com (2603:10b6:303:b6::24) by DS7PR12MB6192.namprd12.prod.outlook.com (2603:10b6:8:97::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Sat, 13 Apr 2024 12:59:59 +0000 Received: from MWH0EPF000A6734.namprd04.prod.outlook.com (2603:10b6:303:b6:cafe::b4) by MW4PR03CA0079.outlook.office365.com (2603:10b6:303:b6::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.31 via Frontend Transport; Sat, 13 Apr 2024 12:59:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by MWH0EPF000A6734.mail.protection.outlook.com (10.167.249.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Sat, 13 Apr 2024 12:59:58 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sat, 13 Apr 2024 05:59:49 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Sat, 13 Apr 2024 05:59:47 -0700 From: Xueming Li To: Bing Zhao CC: Suanming Mou , dpdk stable Subject: patch 'net/mlx5: fix drop action release timing' has been queued to stable release 23.11.1 Date: Sat, 13 Apr 2024 20:49:47 +0800 Message-ID: <20240413125005.725659-107-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240413125005.725659-1-xuemingl@nvidia.com> References: <20240305094757.439387-1-xuemingl@nvidia.com> <20240413125005.725659-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000A6734:EE_|DS7PR12MB6192:EE_ X-MS-Office365-Filtering-Correlation-Id: c9754662-5b73-448d-c2fe-08dc5bb99fd3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IHMKN5NCscKH4mkudBIb8RVoaNXy++RQaKlTo1od9H4APAu962JQtaVHa67peMVSUmHekw80mabEmkkr+5J0VB2kuMSGYwlg3KbfBPResK6KAmPfN6vdPFYhOv+ZYeiZihOSvVfCc8NtZVN8cfdz5MtbpYfKINq5ps61crSTLgNFwOyircwWhVObV56XrzTNYuAJc2+j1AbMIIrRHMuMfXjX5qnkI0JI2MJNDKvBocGrNzQ2WGp1G+/itDxZhkiSYp0cn5N3UmbDol+gBZlQ6QRbbO0rquJoz0K0OC5wPQVv7jhpA13eY8jEYixLhdhubKyb/WcX+N+s8ti8cltAc2+L2Cd3diQrHccezvh8bf+wJyGvW3nrcvErvBHePNvad1mPQFcAK6oMFxx4G4McQ4RZPMu3P3gwwr1reyKbxNlYn/1SaWl8TWu3Dn86b2mG1WQTKtAe2gmMcBktlhZvof6HcLn5WMS5fEhJ7npo5bEUX7gwGmsLBxd9a8MsaHHJMQ33R7BnuRkRP/uz5kIuSu0IvyzAjU6+gS1XUkUvZEmaykVZtaA+bMzqespEEabNC/PeVTQYNLIXRLXF3F5LxxJ6SxQJDV2eiCnrU2AYRM4a49eGsjFRgw65E6EcxQH+Zf7H0+Oawz3PbzjRvqmi3z+rg4I3t+zQAo7y73ZAG5uk5T0BvVqRgHgv4udif6lheFvI5tdMJ0eE1TVLfStTGQNgyycqDMAW8Qka45msHS6pAZqj1lDDbVORE9/zl1t9 X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(82310400014)(1800799015)(376005)(36860700004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2024 12:59:58.7519 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c9754662-5b73-448d-c2fe-08dc5bb99fd3 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000A6734.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6192 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/15/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=2864fd3102de0b12ee38816c850b320482ecfb92 Thanks. Xueming Li --- >From 2864fd3102de0b12ee38816c850b320482ecfb92 Mon Sep 17 00:00:00 2001 From: Bing Zhao Date: Fri, 8 Mar 2024 05:22:37 +0200 Subject: [PATCH] net/mlx5: fix drop action release timing Cc: Xueming Li [ upstream commit 22a3761b782b7c46ca428209b15b4f7382a40a62 ] When creating the drop action Devx object, the global counter set is also used as in the regular or hairpin queue creation. The drop action should be destroyed before the global counter set release procedure. Or else, the counter set object is still referenced and cannot be released successfully. This would cause the counter set resources to be exhausted after starting and stopping the ports repeatedly. Fixes: 65b3cd0dc39b ("net/mlx5: create global drop action") Signed-off-by: Bing Zhao Acked-by: Suanming Mou --- drivers/net/mlx5/mlx5.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 95f2ed073c..417e88e848 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -2290,12 +2290,12 @@ mlx5_dev_close(struct rte_eth_dev *dev) priv->txqs = NULL; } mlx5_proc_priv_uninit(dev); + if (priv->drop_queue.hrxq) + mlx5_drop_action_destroy(dev); if (priv->q_counters) { mlx5_devx_cmd_destroy(priv->q_counters); priv->q_counters = NULL; } - if (priv->drop_queue.hrxq) - mlx5_drop_action_destroy(dev); if (priv->mreg_cp_tbl) mlx5_hlist_destroy(priv->mreg_cp_tbl); mlx5_mprq_free_mp(dev); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-04-13 20:43:08.302722515 +0800 +++ 0107-net-mlx5-fix-drop-action-release-timing.patch 2024-04-13 20:43:05.117753775 +0800 @@ -1 +1 @@ -From 22a3761b782b7c46ca428209b15b4f7382a40a62 Mon Sep 17 00:00:00 2001 +From 2864fd3102de0b12ee38816c850b320482ecfb92 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 22a3761b782b7c46ca428209b15b4f7382a40a62 ] @@ -16 +18,0 @@ -Cc: stable@dpdk.org @@ -25 +27 @@ -index 8b54843a43..d1a63822a5 100644 +index 95f2ed073c..417e88e848 100644 @@ -28 +30 @@ -@@ -2382,12 +2382,12 @@ mlx5_dev_close(struct rte_eth_dev *dev) +@@ -2290,12 +2290,12 @@ mlx5_dev_close(struct rte_eth_dev *dev)