From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C0BA43E57 for ; Sat, 13 Apr 2024 14:52:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 95E40402E1; Sat, 13 Apr 2024 14:52:10 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2078.outbound.protection.outlook.com [40.107.94.78]) by mails.dpdk.org (Postfix) with ESMTP id 0C46440294 for ; Sat, 13 Apr 2024 14:52:09 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YdiFWiExwQgAXP25oY0tW731h0lM8OOY2nZsdh+q6qHb9ZWqIcuIi3aESRoEJvnxnSsMDpN7TB/sstErCWnhAhJvoLETvIxZmNk8WxAiCu01GMJJgNn+JY2EzMx5YTMw5e43vPAeJctAsigMj45+viSibANscvWatNGLljjdiyDN2TZjHEgPxuSFqaehNWDdDm+YB3IBVl/t1Yr3GrzLmt6E+l3O/OXacu0HeMH/r9Gq+21kTTNznsgYJhGYIK6pCY9T1UJaE7v+bb58bQe0tEQm8A8mEZgtlc7dyuffUqnXhVfedAqD1gkZbgVGcPfdo7z92ymaHAcE7G72IKSRUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PbLxGqRSLULUzfYHntclwovoiTDnMFHwgfzJEooQbMc=; b=KWOx5P5rrc1hIRSbHzsDrcace2s1VrsceU4bhVveUnX3Zfzc/PfEx0EfQ22wh3wZfddtzgWF6fmVORlf7lzX+dHdZsDrS2fWxIOMGpFWWcyJnkzoEO+gjAubTlryBcAGMZvWsO4GjLATEVZ56gg57/440bZBmpRyvnvx+pS3fuU77eduwZDGDcrF1lDguXuCXipZyhqTl0+FBfzVk/51DZz1wPB7gwCmvnbC2C/53zJWBkNmkX7vclL2FhSWqR+OeDkBjJ2JKpHiVLXj0ydL4UM6HkxKo5WSM4WVF0+4+s+klwAbbBKOIMb968ug1MCRBoANdeIOrtRBXB/iGEX34g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PbLxGqRSLULUzfYHntclwovoiTDnMFHwgfzJEooQbMc=; b=hXRGMptpXqvnX94t+ZFgQgtLSoBfXvMXAr4CUDcLMoSfiPJkbMX08HvEHpK30v3j53pnsu99NfJ3eFvcIORg0jdkxStehsqKq4Jgw6Tbu4Uj4WpQu5RuHGLLNVfvcPT+7l+ixBKdb61meni3/K85u9pd6rudro3xZ8eQGZMfZ9Uo4Tj57elqbpyUyxqf5DQ5LTogX3PiyCbpcwI10sxT5vIlvx3B3ybsKKpcZw39jlPVKRwYES5fUcu0Yhaumx8wKno/XIZwNgYhGLf3Tw5LejG6iYVDw4xYWkxddehQBm5V1XUjcUbM3PopjsjYJ1ji650MrtiwZfbkgBZBVQCAUQ== Received: from BL1PR13CA0352.namprd13.prod.outlook.com (2603:10b6:208:2c6::27) by BY5PR12MB4292.namprd12.prod.outlook.com (2603:10b6:a03:212::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.55; Sat, 13 Apr 2024 12:52:05 +0000 Received: from BL02EPF00021F6D.namprd02.prod.outlook.com (2603:10b6:208:2c6:cafe::20) by BL1PR13CA0352.outlook.office365.com (2603:10b6:208:2c6::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7495.16 via Frontend Transport; Sat, 13 Apr 2024 12:52:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL02EPF00021F6D.mail.protection.outlook.com (10.167.249.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Sat, 13 Apr 2024 12:52:05 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sat, 13 Apr 2024 05:51:52 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Sat, 13 Apr 2024 05:51:50 -0700 From: Xueming Li To: Dariusz Sosnowski CC: Ori Kam , dpdk stable Subject: patch 'app/testpmd: fix async flow create failure handling' has been queued to stable release 23.11.1 Date: Sat, 13 Apr 2024 20:48:18 +0800 Message-ID: <20240413125005.725659-18-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240413125005.725659-1-xuemingl@nvidia.com> References: <20240305094757.439387-1-xuemingl@nvidia.com> <20240413125005.725659-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00021F6D:EE_|BY5PR12MB4292:EE_ X-MS-Office365-Filtering-Correlation-Id: 48c89e7b-e4eb-4e5c-d76a-08dc5bb88588 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?mR3Kw+KMrRdDwm6fNk0a0CiOnmu0NxJGLgf9Lk+sGNlLqklvN94n8+NFsTuy?= =?us-ascii?Q?pUNrRs4tI1+tGTRSRLw1nm1HcRcVvxWWlUG42TGET7Zo7HufTwWDvE9PuNZ5?= =?us-ascii?Q?1v8e2s1/h3xkVhs1A4uf4a3guAzlhE7BuGepQrqiOfjvtRSXx7kGkz6R0zNq?= =?us-ascii?Q?hL9m2D4522VMt0dVWBEzY2w8dKE6UCoux6jTN/80ToNImYkOYUBdXXB+2W/A?= =?us-ascii?Q?NdQ41DasShda9cQecGuEhPAQiBsR5LU1s7NqirUkxuT0jPRI6CU7+MaKoeKY?= =?us-ascii?Q?PsokV6ahzt/Bzs3U4pFwotB0C2mtt65A6JxzHaSzlStxcUgDG+dVDMbvjDYn?= =?us-ascii?Q?Kgim1Bfm5kuBBGGjigFI+s2hXN/JZno08upBmE9fWKudAOe8Ubabiju4dd9c?= =?us-ascii?Q?6HAsB7ckRJB+BuG1q0LpyXLGQEr4flFOFW+n3qMW/vHER8BS1SYBkjXswanh?= =?us-ascii?Q?U36s83e0/svjhEAJOedm+oLpOVsxrUR1fPVgnZZfj8pK299XbiaxJPGXk9Ci?= =?us-ascii?Q?pdFngDerJfmWQiee2dQj+E05NM6HQfSj/dkFYLoSsV+BjCg6g5+tbWYezLIB?= =?us-ascii?Q?sWgyz78MqJ+QiCAXcx7XsS30+hBKsTZr6VcI83DXkfPTIW2I+0yQSDlSdb31?= =?us-ascii?Q?8joa9p2RqIQ+5A3a6X31xduhhBRI6pnM6HPuoAa2K+Y607KREu06Y/Oq+itJ?= =?us-ascii?Q?mbegNzt4IccGZSeTMcEUDDKOK+j3obhstLYvpOegjnghg4QT2+oFZ85YbIfU?= =?us-ascii?Q?xHyI1T9tO/V7C9KnsViQbik3ghM5GkFzKlHk58H8zx5Gxrqca2fKurUV8HVN?= =?us-ascii?Q?oXeOlegGd7OKjLLJCBmYCi2rYCEjYHjq2TyRbOu6gnwuZtXkHML1xz5UizJi?= =?us-ascii?Q?GTqlDArA6Jp3kYyoCogq1XU/FcNt+A22M/L6sWSIv7nC3zSVyKsZwAflQue1?= =?us-ascii?Q?DGtyg3G5jYLxlYLnH94B7s+JgGsGZJtgRMiNcYnbJpTeOGaT2dNuItYdnlle?= =?us-ascii?Q?3UGIGG1svA9MRoks67eiEu7/m+LwB5qwWvNAZmFB14Nxe+/gNjbv/z7E1XyK?= =?us-ascii?Q?KMT5VfgHpVbHlbF6r1ms2TddCusY/fL0nFJeUKJP3QoMz1t1NXBK6WFOfVct?= =?us-ascii?Q?E9LI/5IJyJhpCsNOaim4vUw5osYKp9TinG13iRGYuR743tT5pgbI3L8ad81B?= =?us-ascii?Q?gj1CS1XsLYkxPjQKmuls+Drq46NcL77U57mU9uxHp4XriSGNLG/fLLV2Mm8D?= =?us-ascii?Q?spRstH+WdI80vJpkKWiM6Iv+F7hFQOerLvH9HqelwTpOc9TdXOcR7DLJ3jAi?= =?us-ascii?Q?GpMvVtuvYKnzBvnfdntALFKf20mCCRIFgr6n8GLxJK3fK1HThPO3bYi+HTGv?= =?us-ascii?Q?wWjPBMfWcwXMCcWVcEFhR0lPcIyN?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(82310400014)(376005)(1800799015)(36860700004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2024 12:52:05.0028 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 48c89e7b-e4eb-4e5c-d76a-08dc5bb88588 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00021F6D.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4292 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/15/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=4a1ffc9b02bcda814389a53b914cdad06e03f872 Thanks. Xueming Li --- >From 4a1ffc9b02bcda814389a53b914cdad06e03f872 Mon Sep 17 00:00:00 2001 From: Dariusz Sosnowski Date: Wed, 28 Feb 2024 19:57:07 +0100 Subject: [PATCH] app/testpmd: fix async flow create failure handling Cc: Xueming Li [ upstream commit 0da12ecba770873851a3a63dc08052271a350aeb ] In case of an error when an asynchronous flow create operation was enqueued, test-pmd attempted to enqueue a flow destroy operation of that flow rule. However, this was incorrect because: - Flow rule index was used to enqueue a flow destroy operation. This flow rule index was not yet initialized, so flow rule number 0 was always destroyed as a result. - Since rte_flow_async_create() does not return a handle on error, then there is no flow rule to destroy. test-pmd only needs to free internal memory allocated for storing a flow rule. Any flow destroy operation is not needed in this case. Fixes: ecdc927b99f2 ("app/testpmd: add async flow create/destroy operations") Signed-off-by: Dariusz Sosnowski Acked-by: Ori Kam --- app/test-pmd/config.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 2c4dedd603..7c24e401ec 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -2789,8 +2789,7 @@ port_queue_flow_create(portid_t port_id, queueid_t queue_id, flow = rte_flow_async_create_by_index(port_id, queue_id, &op_attr, pt->table, rule_idx, actions, actions_idx, job, &error); if (!flow) { - uint64_t flow_id = pf->id; - port_queue_flow_destroy(port_id, queue_id, true, 1, &flow_id); + free(pf); free(job); return port_flow_complain(&error); } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-04-13 20:43:05.724984282 +0800 +++ 0018-app-testpmd-fix-async-flow-create-failure-handling.patch 2024-04-13 20:43:04.927754023 +0800 @@ -1 +1 @@ -From 0da12ecba770873851a3a63dc08052271a350aeb Mon Sep 17 00:00:00 2001 +From 4a1ffc9b02bcda814389a53b914cdad06e03f872 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 0da12ecba770873851a3a63dc08052271a350aeb ] @@ -22 +24,0 @@ -Cc: stable@dpdk.org @@ -31 +33 @@ -index cd2a436cd7..968d2164ab 100644 +index 2c4dedd603..7c24e401ec 100644 @@ -34 +36 @@ -@@ -2856,8 +2856,7 @@ port_queue_flow_create(portid_t port_id, queueid_t queue_id, +@@ -2789,8 +2789,7 @@ port_queue_flow_create(portid_t port_id, queueid_t queue_id,