From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2430B43E57 for ; Sat, 13 Apr 2024 14:52:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E74640294; Sat, 13 Apr 2024 14:52:28 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2087.outbound.protection.outlook.com [40.107.93.87]) by mails.dpdk.org (Postfix) with ESMTP id 74FCA400D6 for ; Sat, 13 Apr 2024 14:52:26 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YxeqLVAIVhIpyTkoJ0Rlq19Gg5l6RtDm8hNFx1pdv5lNP0lK+MW1m0gWx7Zy2k2eQ5vy+GK+yZ0H4VquQVpAixvg9io0woWry6Q0gjDOshIX9kt+58UNFO6yS2lj6AdUcOGhT2whimi9NuP+3EDvnf08EWN2wgxpmKW3UxUyrOg3vl7ulr8glsUEiPDtBpwoWBBf8u/+Ln26MG9hQG+KN+xJdhTEb7TZTbW2q4aN3ggPBVmWlvJAyk//NfuP3Ix++aKc3mJ7gAvCSa/0ykipYxvy8yCXthze6mXnxZqaR1e53VqmIGv3b0TYKPKO6yRS49Q5EwvGes9367b4Iw0VqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PmbcvCUB2HRteMkzNOAoz31580AHSTFFdmf4uzWEq1I=; b=diUWkZuimrOVygEtjJg5BlXMAu0xDgg79b35MooHk2CPQ2keoGE/Xj7lv2VoA5WQZoz4Y04sQ5TDwuxl0yQDgoBuPDZQhUTwgvc3V8NzMJJqDCSyBSSpH0YnWdwiOckYBKFnM5XVY68PEFwYNovUDUs8aEddbHi5SXVnHJjJuAxwn4jKYtL2I4T6nJRSLYa3dr3SFfkxYkyXXQ2bTBi8oYmw1+icVE/agJpH2DeDxageIMO+iVNfU6Gya61an/Z/9NIqY4ZbM4vNJrlNXXNr9RYdPUr7SIEo3ZkWHeT5ipgczMO30MqfWVww72ajXbeaSoVsj4l9D16hgUrIZZduYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=6wind.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PmbcvCUB2HRteMkzNOAoz31580AHSTFFdmf4uzWEq1I=; b=EyiJkDMBu4FbKwMygeeTxrBkRaXRKGJFoEPu2fGx4dzFJwxjVQyRcP7Ch84AKZrwJWojzYEP8O5YSS/kxh7e4DMIjEbZgNAEOKy8TjfpSdLbtYL1e4NdOJerYOjzlots5vvmcDeqvG/1p4YqcqCIssx9rlAA5p2D8938BktP7bNA1lATWAzX24nUy6pw4FMrPMr7l6YK4X1AQ3hvtSKsh8Hp+mVP4cJ7WfvVmZJdpFc0owZOlqJ7EhNKYWv5zhB8035V1huK1u7r9ZcN4FV+2jLQUkz6ZT8wFsaKfsJcsRKjSaikrq9MbtS1jyelzFWXrnoTo6BnH0fKkBqk3K6S7Q== Received: from BY3PR04CA0005.namprd04.prod.outlook.com (2603:10b6:a03:217::10) by SA3PR12MB7784.namprd12.prod.outlook.com (2603:10b6:806:317::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Sat, 13 Apr 2024 12:52:21 +0000 Received: from SJ1PEPF00001CDF.namprd05.prod.outlook.com (2603:10b6:a03:217:cafe::50) by BY3PR04CA0005.outlook.office365.com (2603:10b6:a03:217::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.31 via Frontend Transport; Sat, 13 Apr 2024 12:52:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ1PEPF00001CDF.mail.protection.outlook.com (10.167.242.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Sat, 13 Apr 2024 12:52:20 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sat, 13 Apr 2024 05:52:15 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Sat, 13 Apr 2024 05:52:14 -0700 From: Xueming Li To: Edwin Brossette CC: Vladimir Medvedkin , dpdk stable Subject: patch 'net/ixgbevf: fix RSS init for x550 NICs' has been queued to stable release 23.11.1 Date: Sat, 13 Apr 2024 20:48:22 +0800 Message-ID: <20240413125005.725659-22-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240413125005.725659-1-xuemingl@nvidia.com> References: <20240305094757.439387-1-xuemingl@nvidia.com> <20240413125005.725659-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CDF:EE_|SA3PR12MB7784:EE_ X-MS-Office365-Filtering-Correlation-Id: 6b5cfb86-94df-4bd4-1951-08dc5bb88ea4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w155UES3RAdhTzWNROj2ldT7es15bhNyRkKMrSZ2I+hOHc2V0B3rpMuihev1QQflhV72X05Weg6kliXkLTwu8wlB9zMNig5Y9EaNcdyePZzbAZiL+Fo9lnP/hRAI/L3u6qozeMgBZf6n/Dwszgx7rca+42TsSbNGkLAGWcNg/V5XqJJ6U2M6BQ6gAej1CfRi7dPGfVaCSFbDrzbCBCcWrRaC6LlN9NDz55tRnX1Z7omkTCzg9/kZXqlFOYocLnn5m5F2JPppcaXkEDcfMTf9UYCeV+daBx6cE9M1DDUXeSl2ktVQUaeAx0y2IvRT791a3zj/yKPXWcS3v1d8hS2AHI8PA2ylrqBjDPFVgGxrZZJWdECpiuQ/wQ7Yd8yCKIyxBjIN/p1mj7N8HQJanw+A388m5XWCmz/aSpZWGDk0k+Ny13Uej+GVAzaukoNvJK5Gjlpn3CVr12/VzFz8E+Onmriy0rNI+o9zXXsO1eQeIfJSwDvxTO0JLnClE3TNnye6otIM3P5u9AOn3IGvR6Rhjy2aupUicpsztFniPouC8harJfpW/8pLcRiXpomxCeOb+IF/n2wg/4ivjIRYJWYqI6/9gnsFIZZPDR6Oy8uF1Bs5a8Jzwz8fV2UQW5+EGEy5o7YZ9wzgWS9hS4IrW7dgC/Dxk6AD7Qejcn9vgvWWgLGKP1baxIiWuHADan9+9X2f7WQB7GNMPdgQbIzxiW/9QsNtpGxdXnmUA6hL3WSyicdkW70i75iLNL/xUB8zNvhp X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(82310400014)(1800799015)(376005)(36860700004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2024 12:52:20.4529 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6b5cfb86-94df-4bd4-1951-08dc5bb88ea4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CDF.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7784 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/15/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=2aa5a757508a5861f9ddfc07cace84b7a51697f6 Thanks. Xueming Li --- >From 2aa5a757508a5861f9ddfc07cace84b7a51697f6 Mon Sep 17 00:00:00 2001 From: Edwin Brossette Date: Thu, 15 Feb 2024 14:31:45 +0100 Subject: [PATCH] net/ixgbevf: fix RSS init for x550 NICs Cc: Xueming Li [ upstream commit 3a53577d5f390e8635a672b79616e54c59b330ab ] Different Intel NICs with the igxbe PMD do not handle RSS in the same way when working with virtualization. While some NICs like Intel 82599ES only have a single RSS table in the device and leave all RSS features to be handled by the PF, some other NICs like x550 let the VF handle RSS features. This can lead to different behavior when RSS is enabled depending on the model of nic used. In particular, ixgbevf_dev_rx_init() does not configure RSS parameters at device init, even if the multi-queue mode option is set in the device configuration (ie. RTE_ETH_MQ_RX_RSS is set). Note that this issue went unnoticed until now, probably because some NICs do not really have support for RSS in virtualization mode. Thus, depending on the NIC used, we can we find ourselves in a situation where RSS is not configured despite being enabled. This will cause serious performance issues because the RSS RETA table will be fully zeroed, causing all packets to go only to the first queue, leaving all other queues empty. By looking at ixgbe_reta_size_get(), we can see that only X550 NIC models have a non zero RETA size set in VF mode. Therefore, add a call to ixgbe_rss_configure() for these cards in ixgbevf_dev_rx_init() if the option to enable RSS is set. Fixes: f4d1598ee14f ("ixgbevf: support RSS config on x550") Signed-off-by: Edwin Brossette Acked-by: Vladimir Medvedkin --- drivers/net/ixgbe/ixgbe_rxtx.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index 90b0a7004f..f6c17d4efb 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -5844,6 +5844,25 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev) IXGBE_PSRTYPE_RQPL_SHIFT; IXGBE_WRITE_REG(hw, IXGBE_VFPSRTYPE, psrtype); + /* Initialize the rss for x550_vf cards if enabled */ + switch (hw->mac.type) { + case ixgbe_mac_X550_vf: + case ixgbe_mac_X550EM_x_vf: + case ixgbe_mac_X550EM_a_vf: + switch (dev->data->dev_conf.rxmode.mq_mode) { + case RTE_ETH_MQ_RX_RSS: + case RTE_ETH_MQ_RX_DCB_RSS: + case RTE_ETH_MQ_RX_VMDQ_RSS: + ixgbe_rss_configure(dev); + break; + default: + break; + } + break; + default: + break; + } + ixgbe_set_rx_function(dev); return 0; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-04-13 20:43:05.824293352 +0800 +++ 0022-net-ixgbevf-fix-RSS-init-for-x550-NICs.patch 2024-04-13 20:43:04.937754010 +0800 @@ -1 +1 @@ -From 3a53577d5f390e8635a672b79616e54c59b330ab Mon Sep 17 00:00:00 2001 +From 2aa5a757508a5861f9ddfc07cace84b7a51697f6 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 3a53577d5f390e8635a672b79616e54c59b330ab ] @@ -31 +33,0 @@ -Cc: stable@dpdk.org