From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71F9D43E57 for ; Sat, 13 Apr 2024 14:52:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C8214068E; Sat, 13 Apr 2024 14:52:34 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2044.outbound.protection.outlook.com [40.107.101.44]) by mails.dpdk.org (Postfix) with ESMTP id AC0C240294 for ; Sat, 13 Apr 2024 14:52:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l1nHlsjneZWgmszWPBYQhWFtdL2UvCTarQmgvJbEALqUGJkRIU6E+E2ClGLR5qKvyzChbmEFK9iityfGUDDZrVi31LCTHQWDjn7h4pssW1BwXrd14ZmOHAu1x6ov+ubGR2/OOdErYou/r84PERKrGje0nkVFr5MHEZoB2gQPPDZByNV1q2pS6lKnUe654tyGxaQT0DRT3gS3JJzDLA8/2ZKqGRXeCcLmJrZm6iQX0oYse4arKY4fc4BDr5/aiPZOmsIIWntupxK20AzKECOMABdOXFI4oUvfQY0zlMpSIn5JTIHnmU/w+d3sdlExgjZ/xs/64xv5IAzj54ZmlWYCCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jh8OhbRou0VEYihQijz60vbV+1GMIxXYASBiPYdudwE=; b=clK7pO502SHI1he/BRCtR2WsFLPhpPCpP2x/uoBmsEq54gtSgATBAbuTF3cT7L7L6lKXgatjHCiroOG76t/6mUGjriKzXcIaLrnR+nqalvXzPyaD7QD/5CAknN4sEjyS4rhsAEpRCr4OpG7bq3KQTwnKr7McsLCcav2X4eG+X+GtAL0WSAOBFDWnyUfPn+GIVB91ZKjS04FjqwL6fQZ3vQmVkGh38lXflnMkjB02C3/EeVI76AZlWot9gK/QCL3NKf3hpV+NPgZWVO3HF4e6b/yWAVx1V80esgQlZznWU6SKEBtC4jbO47g1ztWJeirL0IY5HHUpE285Bq0s5NOLqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jh8OhbRou0VEYihQijz60vbV+1GMIxXYASBiPYdudwE=; b=b39pQWVe7rqnskaW+CXFnSo++0G0Dm1UgPq3hcUK0NknSw4Am5NWx0ESUiHeblh9FNKlWdPjyCy4516BdmyIBOpDR2qHS+ISrZdFFNZjulTgQT/SvcC5wWkd2rMRmG9En1Wi+CuTFhOxg9+Ctt6cnXIKfgSp+KBwpFYFjKoVXwqgidVSPBsBM/u+eatmIyOZNDJVIYSvEvgr9oZOZUGXbNdotHntkjzormLlltBxIdiVY8pmkQ8nT5RTi/Uhq/P6zvTItKmhlyQ3OkcgKXJKzrWdanxoTvSA1xUq7+oEHEtMQpMpFdwEMJVxCCSBEmOtTlDz5yTY8dzpNat5wrU67w== Received: from BL1PR13CA0358.namprd13.prod.outlook.com (2603:10b6:208:2c6::33) by DS0PR12MB8198.namprd12.prod.outlook.com (2603:10b6:8:f2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Sat, 13 Apr 2024 12:52:30 +0000 Received: from BL02EPF00021F6D.namprd02.prod.outlook.com (2603:10b6:208:2c6:cafe::db) by BL1PR13CA0358.outlook.office365.com (2603:10b6:208:2c6::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7495.16 via Frontend Transport; Sat, 13 Apr 2024 12:52:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL02EPF00021F6D.mail.protection.outlook.com (10.167.249.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Sat, 13 Apr 2024 12:52:29 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sat, 13 Apr 2024 05:52:17 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Sat, 13 Apr 2024 05:52:16 -0700 From: Xueming Li To: David Marchand CC: Bruce Richardson , dpdk stable Subject: patch 'net/iavf: remove error logs for VLAN offloading' has been queued to stable release 23.11.1 Date: Sat, 13 Apr 2024 20:48:23 +0800 Message-ID: <20240413125005.725659-23-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240413125005.725659-1-xuemingl@nvidia.com> References: <20240305094757.439387-1-xuemingl@nvidia.com> <20240413125005.725659-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00021F6D:EE_|DS0PR12MB8198:EE_ X-MS-Office365-Filtering-Correlation-Id: 11dba901-377b-47fd-5e1c-08dc5bb89468 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hPOasKa2MygFofAo1zCCTDYROInkiIQEx6NwZh2znaKN4t5L6B5EneX6neRtZ/PzorNW5Tt6Ve0/GVPr3CVmHIKqiDzsCsbKusDK1QSv7YqC0eO6FsBTp7HvM0fFmwlk1IEjVX8hTu7b6VHfv4pIhgh9rbQ7WMf+XR7IsSci4vsgYqu31kA5bHbkreSjmLjuiYBG5yvkKiHi77HDtRGuhAw35JhVrja3/z2/6Cws0CgqqithPFp2HoOZcXgYy371kkvbyGZ/6M8KexmgS1JxwmnDvMAPM0j30tEVkAlO15/iKKLYripYgfHWBmpx1mQ8zi5aze9wlWIuUu1fwlU9OF3dMKabujHacdl+TP0agDA4LGNQB/HV1PJUCvjI2ACltXYnLIf4huJNfaw+vKNz7XyPlKbL6fLAEyLMXC0DdnCQetjnVtSG6BljsqgwG4MhhG/1g5Hjg5Lvs8/I++DTa+rHV+iNQkMIIok4LSj26zoRV7KA5pGDG11wxE0x1A6LVIw32E/8h8wRBaB2Dcmx6HFRYTyL+Pq/Yvply0rXM85PpSBgtxS9mYFQoJz4k2eLSeyeT2/cNaZ0niwzICtCHDo8aabnZmr7sqHJuqPT0UoKOUcNTjiCP6neQ1Inr/XnWloCugfJUpElRH7H1johv4rr3iuK4RxDgC5w/qdE8/u+Xnhqauz49EojtTA+gDAniNNMXeBusRNhsPOpiHRn164OfZx35pq28DgG0v/EkmecWvxasXPwR8ZMZDajsgDz X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(1800799015)(82310400014)(376005)(36860700004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2024 12:52:29.9714 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 11dba901-377b-47fd-5e1c-08dc5bb89468 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00021F6D.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8198 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/15/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=eefc0111dec8c9b7a03b672e1d890d3a9229ced3 Thanks. Xueming Li --- >From eefc0111dec8c9b7a03b672e1d890d3a9229ced3 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Tue, 6 Feb 2024 11:34:20 +0100 Subject: [PATCH] net/iavf: remove error logs for VLAN offloading Cc: Xueming Li [ upstream commit 325764b3a20a16a7a997a324cc0b93367eb7f3e1 ] This was reported by RH QE. When a vlan is enforced on a VF via an administrative configuration on the PF side, the net/iavf driver logs two error messages. Those error messages have no consequence on the rest of the port initialisation and packet processing works fine. [root@toto ~] # ip l set enp94s0 vf 0 vlan 2 [root@toto ~] # dpdk-testpmd -a 0000:5e:02.0 -- -i ... Configuring Port 0 (socket 0) iavf_dev_init_vlan(): Failed to update vlan offload iavf_dev_configure(): configure VLAN failed: -95 iavf_set_rx_function(): request RXDID[1] in Queue[0] is legacy, set rx_pkt_burst as legacy for all queues The first change is to remove the error log in iavf_dev_init_vlan(). This log is unneeded since all error path are covered by dedicated log messages already. Then, in iavf_dev_init_vlan(), requesting all possible VLAN offloading must not trigger an ERROR level log message. This is simply confusing, as the application may not have requested such vlan offloading. The reason why the driver requests all offloading is unclear so keep it as is. Instead, rephrase the log message and lower its level to INFO. Fixes: 1c301e8c3cff ("net/iavf: support new VLAN capabilities") Signed-off-by: David Marchand Acked-by: Bruce Richardson --- drivers/net/iavf/iavf_ethdev.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index 32a1626420..c26612c4a1 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -630,7 +630,8 @@ iavf_dev_init_vlan(struct rte_eth_dev *dev) RTE_ETH_VLAN_FILTER_MASK | RTE_ETH_VLAN_EXTEND_MASK); if (err) { - PMD_DRV_LOG(ERR, "Failed to update vlan offload"); + PMD_DRV_LOG(INFO, + "VLAN offloading is not supported, or offloading was refused by the PF"); return err; } @@ -706,9 +707,7 @@ iavf_dev_configure(struct rte_eth_dev *dev) vf->max_rss_qregion = IAVF_MAX_NUM_QUEUES_DFLT; } - ret = iavf_dev_init_vlan(dev); - if (ret) - PMD_DRV_LOG(ERR, "configure VLAN failed: %d", ret); + iavf_dev_init_vlan(dev); if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_RSS_PF) { if (iavf_init_rss(ad) != 0) { -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-04-13 20:43:05.849317819 +0800 +++ 0023-net-iavf-remove-error-logs-for-VLAN-offloading.patch 2024-04-13 20:43:04.937754010 +0800 @@ -1 +1 @@ -From 325764b3a20a16a7a997a324cc0b93367eb7f3e1 Mon Sep 17 00:00:00 2001 +From eefc0111dec8c9b7a03b672e1d890d3a9229ced3 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 325764b3a20a16a7a997a324cc0b93367eb7f3e1 ] @@ -33 +35,0 @@ -Cc: stable@dpdk.org @@ -42 +44 @@ -index b5f6049a91..2cb602a358 100644 +index 32a1626420..c26612c4a1 100644 @@ -45 +47 @@ -@@ -633,7 +633,8 @@ iavf_dev_init_vlan(struct rte_eth_dev *dev) +@@ -630,7 +630,8 @@ iavf_dev_init_vlan(struct rte_eth_dev *dev) @@ -55 +57 @@ -@@ -709,9 +710,7 @@ iavf_dev_configure(struct rte_eth_dev *dev) +@@ -706,9 +707,7 @@ iavf_dev_configure(struct rte_eth_dev *dev)