From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E832B43E57 for ; Sat, 13 Apr 2024 14:53:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E085740294; Sat, 13 Apr 2024 14:53:02 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2040.outbound.protection.outlook.com [40.107.237.40]) by mails.dpdk.org (Postfix) with ESMTP id D313B400D6 for ; Sat, 13 Apr 2024 14:53:01 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ejYWI7krHxRRELbwQgOdg8QQwjTO8jSC/ecKwcApEaF0nJfCdcqSk+qPEBY2MMV5SL7eXtEv/PRCO9/aVLQ6Hys1Rm9BmMro9mABrRHMWFaxMKEVC0Uy3pXgoyFQdyEkZnec2PJlDKT0jSVJue9bBvCKEIK9NtqRksKKQSTPXXEER3baURWUCf8AGuhYuibTqkXlGrXpyHt3IYGerp695f5ZXFtQNEkBfs4RFCK/jTsOdJz7s2522Wp/HJYYWPkC0y6ZxfyIIAyyfXpgjDCm8GXThubBqBHUUVsoPhg/sI2J/88u9oec+7xahkyNAlTf5cu9ecvxdkDIDyYq7AEIeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GKP7l1DPulZZ/YOU+LnQpOjIW2bKCFv4WF/zS/xQQqA=; b=GudBauutBZbKYLGCOL1XWa3KEmUGicf3XAPjoOpmsKnPYwarArCECLkuE7Xw3Xp50gtj98ezZEiIF4tF6al1CtGYNy1EZ5BQvMO5E+STndQs+9PmSS+hi8zngfF7XfpctKm/g3Zwj1YEMdhIjkNUGPgPNCgJ+wGwu7mIAquco0cbuA+2I8DmS1gJlweWzHV9TEibyZypd91Ng9fo/gkXUKbDw1YEXA1WrF1HkrMhhObiQ/H0E1F9XtuMd6tcAICA8B7o+0Ur3GGVFD77RpCgJdMUIF69l6wc5vbXaPdGdT2P/xpDuSqi2kL2bPcaxaNDzfGxZlYpzd6RZR9qrLvv2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GKP7l1DPulZZ/YOU+LnQpOjIW2bKCFv4WF/zS/xQQqA=; b=qqylBsd6QcsNvyUFTZnhURe2qFplkFknzQw8mkWa2vkJJQcN2+lJ6ws3VpNaAvO97ndyi8k5br7964HTqMJoRQEiOx0pvDDqlG1Se97bVMSLjdiaimMuAOgiEDXgdKUR1JRnC28P7tQKG6ctaV6Iss0T/fkQOov+KbtElcwo4BQQfzC7whajTWsv8QyfBHCit21RVVHhN503N8VLIqM7e8oMuijxrTzjgVcAp0IEolIxa4wZ5CZELLpn5dAU6zpGkqDmJW4BjDtYKFonKROEjQU2DcSy2f9oGDbu35eePt+K94m2s5Y6UBVfWz6yCjusRFG4iIYuAzNabeOIXaIN9Q== Received: from BL1PR13CA0028.namprd13.prod.outlook.com (2603:10b6:208:256::33) by MW4PR12MB6730.namprd12.prod.outlook.com (2603:10b6:303:1ec::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.55; Sat, 13 Apr 2024 12:52:57 +0000 Received: from BL02EPF00021F6F.namprd02.prod.outlook.com (2603:10b6:208:256:cafe::b0) by BL1PR13CA0028.outlook.office365.com (2603:10b6:208:256::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7495.16 via Frontend Transport; Sat, 13 Apr 2024 12:52:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL02EPF00021F6F.mail.protection.outlook.com (10.167.249.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Sat, 13 Apr 2024 12:52:56 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sat, 13 Apr 2024 05:52:40 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Sat, 13 Apr 2024 05:52:38 -0700 From: Xueming Li To: Bruce Richardson CC: Anatoly Burakov , dpdk stable Subject: patch 'net/iavf: remove incorrect 16B descriptor read block' has been queued to stable release 23.11.1 Date: Sat, 13 Apr 2024 20:48:26 +0800 Message-ID: <20240413125005.725659-26-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240413125005.725659-1-xuemingl@nvidia.com> References: <20240305094757.439387-1-xuemingl@nvidia.com> <20240413125005.725659-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00021F6F:EE_|MW4PR12MB6730:EE_ X-MS-Office365-Filtering-Correlation-Id: ec48ef59-4150-4b13-2469-08dc5bb8a413 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r9JsyvOciTDZVZRSPKpe+43t1tHXdYk4uqKkBsabKf9++9/XRWsxz4JaOo+04u2noaJAgjk9i/PbO3Kd7I05Q6X7d3x6Or+RJFUwa2SKBzGgpZ89QWv6ET+jrZ+Ke0rubPOOPWEa2VQCJqqsl1SSWbCh6ieb/vZGlugAUjvrGuufsKEx/eo+p96pvvhOgI20zaCXrZWVkqLh1v4310+Bvxy2RRrvvo3Cv2aNCvLGstUHfeXYAI+s/vPJrLwDZ1evRgkUuz1SmVS8tlyK9JM7QskXmD1DE2B15+hr0Z4B4CfbCFCif1lsZNGizQeN0PWBu7FZtCM1p3XTTtGH2yaUVXf+HQmb95pqBXRAcX24WtKmx19ytV1Tdz2+0hu6UJUI1fWmLKQFm6eYTprJkAaVMO+56Jid9yAxDx4emp4ipn7Nl/yIDYWxv4x4s7u2QR2i0Csjl6laMDq3quwwqYphLrrArnBYjXX8G7XKloZo0gYlBIsSQZ7jnb4bL2Sdtr36DdtKLoS5Tto66kFp4zYApYe4+fAYBW/1sjP1Y/BxTkmFr931DRZiZDLIQ6x0IRUMrSm1plAqqiRgTVWj1lRK8QVVcVckY0oWnSS0ufIGEviq8hrHhj/wI0CNjF6kOgJxy0Mcz06mgUbcQV7arHoSp/MlUPvS50u+DEu3Gl3Bg2qY6B4v/M2Ihr8ia6EiDVFsxIPSJX+2eao5L22nJWWdMZ8G8R3FvmICBwnVEw0akmMUSnPFrPBhxm3rZANnypnJ X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(1800799015)(376005)(82310400014)(36860700004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2024 12:52:56.2720 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ec48ef59-4150-4b13-2469-08dc5bb8a413 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00021F6F.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6730 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/15/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=72093d3d41b3a9fcad9010accc7f55e79f205cc9 Thanks. Xueming Li --- >From 72093d3d41b3a9fcad9010accc7f55e79f205cc9 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Tue, 23 Jan 2024 11:40:50 +0000 Subject: [PATCH] net/iavf: remove incorrect 16B descriptor read block Cc: Xueming Li [ upstream commit d4ade5d02d188fcbe51871c5a5d66ef075ca0f86 ] By default, the driver works with 32B descriptors, but has a separate descriptor read block for reading two descriptors at a time when using 16B descriptors. However, the 32B reads used are not guaranteed to be atomic, which will cause issues if that is not the case on a system, since the descriptors may be read in an undefined order. Remove the block, to avoid issues, and just use the regular descriptor reading path for 16B descriptors, if that support is enabled at build time. Fixes: af0c246a3800 ("net/iavf: enable AVX2 for iavf") Signed-off-by: Bruce Richardson Acked-by: Anatoly Burakov --- drivers/net/iavf/iavf_rxtx_vec_avx2.c | 80 ++++++++------------------- 1 file changed, 24 insertions(+), 56 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx_vec_avx2.c b/drivers/net/iavf/iavf_rxtx_vec_avx2.c index 510b4d8f1c..49d41af953 100644 --- a/drivers/net/iavf/iavf_rxtx_vec_avx2.c +++ b/drivers/net/iavf/iavf_rxtx_vec_avx2.c @@ -193,62 +193,30 @@ _iavf_recv_raw_pkts_vec_avx2(struct iavf_rx_queue *rxq, _mm256_loadu_si256((void *)&sw_ring[i + 4])); #endif - __m256i raw_desc0_1, raw_desc2_3, raw_desc4_5, raw_desc6_7; -#ifdef RTE_LIBRTE_IAVF_16BYTE_RX_DESC - /* for AVX we need alignment otherwise loads are not atomic */ - if (avx_aligned) { - /* load in descriptors, 2 at a time, in reverse order */ - raw_desc6_7 = _mm256_load_si256((void *)(rxdp + 6)); - rte_compiler_barrier(); - raw_desc4_5 = _mm256_load_si256((void *)(rxdp + 4)); - rte_compiler_barrier(); - raw_desc2_3 = _mm256_load_si256((void *)(rxdp + 2)); - rte_compiler_barrier(); - raw_desc0_1 = _mm256_load_si256((void *)(rxdp + 0)); - } else -#endif - { - const __m128i raw_desc7 = - _mm_load_si128((void *)(rxdp + 7)); - rte_compiler_barrier(); - const __m128i raw_desc6 = - _mm_load_si128((void *)(rxdp + 6)); - rte_compiler_barrier(); - const __m128i raw_desc5 = - _mm_load_si128((void *)(rxdp + 5)); - rte_compiler_barrier(); - const __m128i raw_desc4 = - _mm_load_si128((void *)(rxdp + 4)); - rte_compiler_barrier(); - const __m128i raw_desc3 = - _mm_load_si128((void *)(rxdp + 3)); - rte_compiler_barrier(); - const __m128i raw_desc2 = - _mm_load_si128((void *)(rxdp + 2)); - rte_compiler_barrier(); - const __m128i raw_desc1 = - _mm_load_si128((void *)(rxdp + 1)); - rte_compiler_barrier(); - const __m128i raw_desc0 = - _mm_load_si128((void *)(rxdp + 0)); - - raw_desc6_7 = - _mm256_inserti128_si256 - (_mm256_castsi128_si256(raw_desc6), - raw_desc7, 1); - raw_desc4_5 = - _mm256_inserti128_si256 - (_mm256_castsi128_si256(raw_desc4), - raw_desc5, 1); - raw_desc2_3 = - _mm256_inserti128_si256 - (_mm256_castsi128_si256(raw_desc2), - raw_desc3, 1); - raw_desc0_1 = - _mm256_inserti128_si256 - (_mm256_castsi128_si256(raw_desc0), - raw_desc1, 1); - } + const __m128i raw_desc7 = _mm_load_si128((void *)(rxdp + 7)); + rte_compiler_barrier(); + const __m128i raw_desc6 = _mm_load_si128((void *)(rxdp + 6)); + rte_compiler_barrier(); + const __m128i raw_desc5 = _mm_load_si128((void *)(rxdp + 5)); + rte_compiler_barrier(); + const __m128i raw_desc4 = _mm_load_si128((void *)(rxdp + 4)); + rte_compiler_barrier(); + const __m128i raw_desc3 = _mm_load_si128((void *)(rxdp + 3)); + rte_compiler_barrier(); + const __m128i raw_desc2 = _mm_load_si128((void *)(rxdp + 2)); + rte_compiler_barrier(); + const __m128i raw_desc1 = _mm_load_si128((void *)(rxdp + 1)); + rte_compiler_barrier(); + const __m128i raw_desc0 = _mm_load_si128((void *)(rxdp + 0)); + + const __m256i raw_desc6_7 = + _mm256_inserti128_si256(_mm256_castsi128_si256(raw_desc6), raw_desc7, 1); + const __m256i raw_desc4_5 = + _mm256_inserti128_si256(_mm256_castsi128_si256(raw_desc4), raw_desc5, 1); + const __m256i raw_desc2_3 = + _mm256_inserti128_si256(_mm256_castsi128_si256(raw_desc2), raw_desc3, 1); + const __m256i raw_desc0_1 = + _mm256_inserti128_si256(_mm256_castsi128_si256(raw_desc0), raw_desc1, 1); if (split_packet) { int j; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-04-13 20:43:05.929289815 +0800 +++ 0026-net-iavf-remove-incorrect-16B-descriptor-read-block.patch 2024-04-13 20:43:04.937754010 +0800 @@ -1 +1 @@ -From d4ade5d02d188fcbe51871c5a5d66ef075ca0f86 Mon Sep 17 00:00:00 2001 +From 72093d3d41b3a9fcad9010accc7f55e79f205cc9 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit d4ade5d02d188fcbe51871c5a5d66ef075ca0f86 ] @@ -15 +17,0 @@ -Cc: stable@dpdk.org