From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0E2743E57 for ; Sat, 13 Apr 2024 14:56:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB9DB40E01; Sat, 13 Apr 2024 14:56:34 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2058.outbound.protection.outlook.com [40.107.244.58]) by mails.dpdk.org (Postfix) with ESMTP id F3E4840DF8 for ; Sat, 13 Apr 2024 14:56:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IMCa0S2Sxxe30cmE25LNPXJgTbg1ZLFBRjMcELeqIvBtRJkh/yDGPyqTI6aPoAYYdTdeXcnraK0PYXLW3MoRDoaESYM4QhPY7Y5EjZUM0JI3Ea/THEqO81pWCFCUdpAxtqP8Ecb0PlCo1rpevc+ZDh3+Grter69dKPkue8l5su+x11IVcT/omjcljVZx5rvLon6jNwctaAHCv/ZnGNHZV9T2zygDVrk1vJaZ3qDDQDs88dlSVDBFLTmCKZMusm4Zyaz40dswLjYDRokwDgGb/QaseGBWSxY3wlvvINTLPQY1QNAlVHgjBx28dUDhJtp+Bovgvtc2liDhntM6iObM0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ll4/AFJ0hrPWPizSBJPEcAAwlrKog4RymOqNc1nb99g=; b=TAD2uZOMehacmEz+G68RyFJ76bVvxmnX6uBeqrvQC+HNrfM+c5JeFxWCZJUmtOTT3Q+xVG7fgX5/fKmgXQEp8HKgPJw/L6G7Z/h+bAZoz5dK781OkDliDYEtR0lz6VaYjXJFG30O8orhD00c1htdYA7SYI6OzxbtH2W56ZezR0LKNZpfbSCGKiIMTO1+2NXignVqDCH0Wfkdqxdh895zudoKRhM2P0wgxPRnO1Sviu2ogslusIARl0+ochLa/2BVdhgQbv3EH3olYEkmu0KKqn9jPo1zNeMJJ0JUR/aLF3Whgth8mSA6nhr6lkNcxz5kpPLOyFnxmSgz+cbJstc6OA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ll4/AFJ0hrPWPizSBJPEcAAwlrKog4RymOqNc1nb99g=; b=e1LP0bNs5rVBwgZ5JbfWALWxqHHQKjX4U1lqZ2TeRkGU1atGOlR3T8FxfTc8Axb00pVigT8PwAxkoFAMW4a/G0s4F+G/v+lPy/avJFj079+1rFN+HM6Zh+Dh65w1YTDbAD1dLlWS14dpl9/AW/iCX6S4bWeSqXJ4G0nsmtVNt3y1He/oabO1DF8cG2odF/8hUhiCLzWc96ULIHgXnzU5QyQKt52SLJFGDWhp7uCF2pnq2a3EbLaMmNZGDPhefgbpE25jutNcE5B1S6cEEQJANhWirVbEbq1CEKooStn+7MsA/In4+OTF3EKNAaFYiH0UHlpwzJnMVzQtyb9l6KWNnA== Received: from DM6PR11CA0015.namprd11.prod.outlook.com (2603:10b6:5:190::28) by DS7PR12MB8417.namprd12.prod.outlook.com (2603:10b6:8:eb::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Sat, 13 Apr 2024 12:56:31 +0000 Received: from DS3PEPF0000C37A.namprd04.prod.outlook.com (2603:10b6:5:190:cafe::f4) by DM6PR11CA0015.outlook.office365.com (2603:10b6:5:190::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.30 via Frontend Transport; Sat, 13 Apr 2024 12:56:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS3PEPF0000C37A.mail.protection.outlook.com (10.167.23.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Sat, 13 Apr 2024 12:56:31 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sat, 13 Apr 2024 05:56:20 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Sat, 13 Apr 2024 05:56:18 -0700 From: Xueming Li To: Konstantin Ananyev CC: Konstantin Ananyev , Pavan Nikhilesh , dpdk stable Subject: patch 'examples/l3fwd: fix Rx over not ready port' has been queued to stable release 23.11.1 Date: Sat, 13 Apr 2024 20:49:10 +0800 Message-ID: <20240413125005.725659-70-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240413125005.725659-1-xuemingl@nvidia.com> References: <20240305094757.439387-1-xuemingl@nvidia.com> <20240413125005.725659-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF0000C37A:EE_|DS7PR12MB8417:EE_ X-MS-Office365-Filtering-Correlation-Id: a4375247-4995-41f5-f432-08dc5bb9244a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?PQ0nwcyYynsAfEIh8arzZ2ipA76mQSnqhsoP9YjFFchCvUlOyjf4mr43H55o?= =?us-ascii?Q?D+bk/a+dYpgDSQGsIvAH7A3fCTEmKIa12raaoI6JBTTZYQOrc70AU/ctFFIv?= =?us-ascii?Q?bGi5J3QJULxG321tqxQOISp1fegx4KC+PoP9SuMsQujLv26VP9jnmDr1azRz?= =?us-ascii?Q?b6CDnZjt5pJCGbgiLjMEYyTlooz1q3H92rfhSpqQPUm2EzYy73fBPSDL5k/6?= =?us-ascii?Q?EKnBYohvBFdtg3w2dOaU1HnaFp5SrU1x89s5zsSS1SZmaDVcbcAMOPtBtWi4?= =?us-ascii?Q?mveYKTMkcYYLXbSvzlrKzQWQsI9zfBsTB42udpJK9oScFPaRLh0on6/VRW2M?= =?us-ascii?Q?jQwNLHK0TFA6mAqqqZhbDaI9+hmC+ParEJfxc46yaerm3mXPLyBbRFSLFGbu?= =?us-ascii?Q?/JOLFXrXUq2NFTx13Xug3NsZPO0H7nWBTuTjAGekS6TrmVPeZwz/c4y3PzhU?= =?us-ascii?Q?zL3t92Vre6600Sbh01xALF63hPo+pnzWaCarpGPcGf5nZ3MRsNH7IehrgeSi?= =?us-ascii?Q?tNQ1byzAINX7cfSrqTlInEiCBp5+Ckp4xyCVxWXZb07KFHLLHxd2MYYBAX4s?= =?us-ascii?Q?B7ARlCKIuYgC0Coohmdyp0Rh9weSdEF4dqv7UPdWKUlOkvA9rATWH/S25Q1U?= =?us-ascii?Q?cUHYVTVXWLye4iIRW4TBzRtZTKkE1IX/xE1UayUl7xxynfoaVe2DVDH/sedi?= =?us-ascii?Q?AHNkMBXAtY2gA7NPkGEUj6tE5PKKc8dTGI/rzBTgKJR9N92GfRRI7s51m+s4?= =?us-ascii?Q?KuakVqEtCKU67o0V9LJ2C7sUq4QQUQq2W6b5viDsklIoABhSCe/sl8f9u6ec?= =?us-ascii?Q?SmGKQ0kicGxVHaaXybehrrzdkRIFZ8Kq/IqYY1c3ZV0XCoc9ubYlOeMbqHxb?= =?us-ascii?Q?zPfQJeHwnaoVE1OvWSOj/2PrH45TdIN3xG4ZC+nVsOli1CCdxTfijeSXAln9?= =?us-ascii?Q?0Z0HvFMwxDiALXV+o6l3bmI/fNVt+BTfN8lWu3uTaSo9TcnoOlYKO8cLGJKs?= =?us-ascii?Q?XFrMSZkkzAM3Xz4ojANGkzLmY7yFjE7RZTtGk4rRERt5I21xNMokbNT639Wl?= =?us-ascii?Q?acFIPX9je03rZOvnhzaJ/5WffyRCEEeK7yaUqRWEwscQaDoslOOPt7DnWz/W?= =?us-ascii?Q?DeV74X7Cvm00As/StNEe0SHDhyhz+Ydl1I6rBd8zFJXWFe7/PQg8zDBlkjC6?= =?us-ascii?Q?l+lr2/G04+LmxPR4d47glFQ39X64fKJw0WA7GIFSVggC8sCT66m3ycuW8Ayh?= =?us-ascii?Q?h2nE/8I9C1lN0bMmYRU8pH8gfOf0ZLcxrFBOgnHZbudDIRW0lD/ekPPmRDmB?= =?us-ascii?Q?07XXKWiiGIInct0psZOlZdayM18X7XUAyfYtbBoOpK3SnvHKjI8/teppd91R?= =?us-ascii?Q?2XbtwSg=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(36860700004)(82310400014)(376005)(1800799015); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2024 12:56:31.4174 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a4375247-4995-41f5-f432-08dc5bb9244a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF0000C37A.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8417 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/15/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=ce95b8c9cd764820f0364755f97809549f58e76f Thanks. Xueming Li --- >From ce95b8c9cd764820f0364755f97809549f58e76f Mon Sep 17 00:00:00 2001 From: Konstantin Ananyev Date: Fri, 1 Mar 2024 16:39:31 +0000 Subject: [PATCH] examples/l3fwd: fix Rx over not ready port Cc: Xueming Li [ upstream commit 495709d32be87cb962c55917b19ad7d4489cde3e ] Running l3fwd in event mode with SW eventdev, service cores can start RX before main thread is finished with PMD installation. to reproduce: ./dpdk-l3fwd --lcores=49,51 -n 6 -a ca:00.0 -s 0x8000000000000 \ --vdev event_sw0 -- \ -L -P -p 1 --mode eventdev --eventq-sched=ordered \ --rule_ipv4=test/l3fwd_lpm_v4_u1.cfg --rule_ipv6=test/l3fwd_lpm_v6_u1.cfg \ --no-numa At init stage user will most likely see the error message like that: ETHDEV: lcore 51 called rx_pkt_burst for not ready port 0 0: ./dpdk-l3fwd (rte_dump_stack+0x1f) [15de723] ... 9: ./dpdk-l3fwd (eal_thread_loop+0x5a2) [15c1324] ... And then all depends how luck/unlucky you are. If there are some actual packet in HW RX queue, then the app will most likely crash, otherwise it might survive. As error message suggests, the problem is that services are started before main thread finished with NIC setup and initialization. The suggested fix moves services startup after NIC setup phase. Bugzilla ID: 1390 Fixes: 8bd537e9c6cf ("examples/l3fwd: add service core setup based on caps") Signed-off-by: Konstantin Ananyev Signed-off-by: Konstantin Ananyev Acked-by: Pavan Nikhilesh --- examples/l3fwd/main.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index 3bf28aec0c..d4fb5d1971 100644 --- a/examples/l3fwd/main.c +++ b/examples/l3fwd/main.c @@ -1577,7 +1577,6 @@ main(int argc, char **argv) l3fwd_lkp.main_loop = evt_rsrc->ops.fib_event_loop; else l3fwd_lkp.main_loop = evt_rsrc->ops.lpm_event_loop; - l3fwd_event_service_setup(); } else #endif l3fwd_poll_resource_setup(); @@ -1609,6 +1608,11 @@ main(int argc, char **argv) } } +#ifdef RTE_LIB_EVENTDEV + if (evt_rsrc->enabled) + l3fwd_event_service_setup(); +#endif + printf("\n"); for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) { -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-04-13 20:43:07.179359982 +0800 +++ 0070-examples-l3fwd-fix-Rx-over-not-ready-port.patch 2024-04-13 20:43:05.017753905 +0800 @@ -1 +1 @@ -From 495709d32be87cb962c55917b19ad7d4489cde3e Mon Sep 17 00:00:00 2001 +From ce95b8c9cd764820f0364755f97809549f58e76f Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 495709d32be87cb962c55917b19ad7d4489cde3e ] @@ -31 +33,0 @@ -Cc: stable@dpdk.org