23.11.1 patches review and test

23.11.1 patches review and test

[Xueming Li]

Hi all,

Here is a list of patches targeted for stable release 23.11.1.

The planned date for the final release is 17th May.

Please help with testing and validation of your use cases and report
any issues/results with reply-all to this mail. For the final release
the fixes and reported validations will be added to the release notes.

A release candidate tarball can be found at:

    https://dpdk.org/browse/dpdk-stable/tag/?id=v23.11.1-rc2

These patches are located at branch 23.11 of dpdk-stable repo:
    https://dpdk.org/browse/dpdk-stable/

Thanks.

Xueming Li <xuemingl@nvidia.com>

---
Ajit Khaparde (2):
      net/bnxt: fix array overflow
      net/bnxt: modify locking for representor Tx

Akhil Goyal (1):
      common/cnxk: fix memory leak in CPT init

Akshay Dorwat (1):
      net/ionic: fix RSS query

Alan Elder (2):
      net: add macros for VLAN metadata parsing
      net/netvsc: fix VLAN metadata parsing

Alex Vesker (3):
      net/mlx5/hws: fix direct index insert on depend WQE
      net/mlx5/hws: fix memory access in L3 decapsulation
      net/mlx5/hws: fix tunnel protocol checks

Ali Alnubani (1):
      doc: update link to Windows DevX in mlx5 guide

Andrew Boyer (2):
      net/ionic: fix device close
      doc: fix typos in cryptodev overview

Ankur Dwivedi (1):
      doc: fix aging poll frequency option in cnxk guide

Anoob Joseph (1):
      examples/ipsec-secgw: fix width of variables

Anup Prabhu (1):
      ml/cnxk: fix xstats calculation

Arkadiusz Kusztal (2):
      common/qat: fix legacy flag
      crypto/qat: fix crash with CCM null AAD pointer

Bing Zhao (7):
      net/mlx5: prevent querying aged flows on uninit port
      net/mlx5: fix condition of LACP miss flow
      net/mlx5: fix HWS registers initialization
      net/mlx5: fix counters map in bonding mode
      net/mlx5: remove device status check in flow creation
      net/mlx5: fix age position in hairpin split
      net/mlx5: fix drop action release timing

Bruce Richardson (11):
      buildtools/cmdline: fix generated code for IP addresses
      buildtools/cmdline: fix IP address initializer
      kernel/freebsd: fix module build on FreeBSD 14
      build: fix linker warnings about undefined symbols
      net/vmxnet3: fix initialization on FreeBSD
      eventdev: improve Doxygen comments on configure struct
      eventdev: fix Doxygen processing of vector struct
      net/i40e: remove incorrect 16B descriptor read block
      net/iavf: remove incorrect 16B descriptor read block
      net/ice: remove incorrect 16B descriptor read block
      test: do not count skipped tests as executed

Chaoyong He (12):
      net/nfp: fix resource leak for device initialization
      net/nfp: fix resource leak for CoreNIC firmware
      net/nfp: fix resource leak for PF initialization
      net/nfp: fix resource leak for flower firmware
      net/nfp: fix resource leak for exit of CoreNIC firmware
      net/nfp: fix resource leak for exit of flower firmware
      net/nfp: fix resource leak for VF
      net/nfp: fix NFD3 metadata process
      net/nfp: fix NFDk metadata process
      net/nfp: fix switch domain free check
      net/nfp: fix initialization failure flow
      net/nfp: fix uninitialized variable

Chengwen Feng (17):
      eal: verify strdup return
      bus/dpaa: verify strdup return
      bus/fslmc: verify strdup return
      bus/vdev: verify strdup return
      dma/idxd: verify strdup return
      event/cnxk: verify strdup return
      net/failsafe: fix memory leak in args parsing
      net/nfp: verify strdup return
      app/dumpcap: verify strdup return
      app/pdump: verify strdup return
      app/crypto-perf: verify strdup return
      app/dma-perf: verify strdup return
      app/testpmd: verify strdup return
      test: verify strdup return
      examples/qos_sched: fix memory leak in args parsing
      examples/vhost: verify strdup return
      net/hns3: remove QinQ insert support for VF

Cristian Dumitrescu (1):
      net/softnic: fix include of log library

Dariusz Sosnowski (9):
      app/testpmd: fix async flow create failure handling
      net/mlx5: fix conntrack action handle representation
      net/mlx5: fix connection tracking action validation
      net/mlx5: fix VLAN handling in meter split
      net/mlx5: fix flow counter cache starvation
      net/mlx5: fix template clean up of FDB control flow rule
      net/mlx5: fix flow configure validation
      net/mlx5: fix async flow create error handling
      net/mlx5: fix rollback on failed flow configure

David Marchand (17):
      hash: remove some dead code
      regexdev: fix logtype register
      lib: use dedicated logtypes and macros
      lib: add newline in logs
      lib: remove redundant newline from logs
      dma/dpaa2: fix logtype register
      build: fix reasons conflict
      app/graph: fix build reason
      ci: update versions of actions in GHA
      vhost: fix virtqueue access check in datapath
      vhost: fix virtqueue access check in VDUSE setup
      vhost: fix virtqueue access check in vhost-user setup
      test/event: skip test if no driver is present
      net/iavf: remove error logs for VLAN offloading
      app/testpmd: fix --stats-period option check
      app/testpmd: fix burst option parsing
      app/testpmd: fix error message for invalid option

Dengdui Huang (8):
      net/hns3: refactor VF mailbox message struct
      net/hns3: refactor PF mailbox message struct
      net/hns3: refactor send mailbox function
      net/hns3: refactor handle mailbox function
      net/hns3: fix VF multiple count on one reset
      net/hns3: fix disable command with firmware
      net/hns3: fix reset level comparison
      app/testpmd: fix crash in multi-process forwarding

Edwin Brossette (2):
      net/virtio: remove duplicate queue xstats
      net/ixgbevf: fix RSS init for x550 NICs

Eli Britstein (1):
      net/mlx5: prevent ioctl failure log flooding

Emi Aoki (1):
      doc: fix typo in profiling guide

Erez Shitrit (2):
      net/mlx5/hws: check not supported fields in VXLAN
      net/mlx5/hws: fix port ID for root table

Ferruh Yigit (8):
      pipeline: fix calloc parameters
      eventdev: fix calloc parameters
      dmadev: fix calloc parameters
      rawdev: fix calloc parameters
      common/mlx5: fix calloc parameters
      net/bnx2x: fix calloc parameters
      net/nfp: fix calloc parameters
      net/sfc: fix calloc parameters

Fidel Castro (1):
      test/power: fix typo in error message

Flore Norceide (1):
      doc: fix typo in packet framework guide

Ganapati Kundapura (2):
      test/event: fix crash in Tx adapter freeing
      eventdev/crypto: fix enqueueing

Gowrishankar Muthukrishnan (1):
      crypto/cnxk: fix CN9K ECDH public key verification

Gregory Etelson (11):
      net/mlx5: fix parameters verification in HWS table create
      net/mlx5: fix flow action template expansion
      app/testpmd: fix async indirect action list creation
      net/mlx5: fix HWS meter actions availability
      net/mlx5: fix sync meter processing in HWS
      net/mlx5: fix indirect action async job initialization
      net/mlx5: fix non-masked indirect list meter translation
      net/mlx5: fix VLAN ID in flow modify
      net/mlx5: remove duplication of L3 flow item validation
      net/mlx5: fix IP-in-IP tunnels recognition
      net/mlx5: fix sync flow meter action

Hamdan Igbaria (2):
      net/mlx5/hws: fix VLAN item in non-relaxed mode
      net/mlx5/hws: fix VLAN inner type

Hanumanth Pothula (1):
      net/thunderx: fix DMAC control register update

Hao Chen (1):
      vhost: fix deadlock during vDPA SW live migration

Harman Kalra (3):
      common/cnxk: fix mbox region copy
      common/cnxk: fix VLAN check for inner header
      common/cnxk: fix link config for SDP

Hernan Vargas (1):
      doc: fix configuration in baseband 5GNR driver guide

Holly Nichols (1):
      test/cfgfile: fix typo in error messages

Honnappa Nagarahalli (2):
      rcu: use atomic operation on acked token
      rcu: fix acked token in debug log

Huisong Li (2):
      doc: add traffic manager in features table
      doc: add link speeds configuration in features table

Itamar Gozlan (1):
      net/mlx5/hws: skip item when inserting rules by index

Jie Hai (2):
      net/hns3: enable PFC for all user priorities
      net/hns3: support new device

Jonathan Erb (1):
      telemetry: fix empty JSON dictionaries

Joyce Kong (2):
      net/memif: fix crash with Tx burst larger than 255
      config: fix CPU instruction set for cross-build

Juraj Linkeš (2):
      dts: fix smoke tests driver regex
      dts: strip whitespaces from stdout and stderr

Kaiwen Deng (3):
      net/i40e: remove redundant judgment in flow parsing
      net/ice: fix tunnel TSO capabilities
      net: fix TCP/UDP checksum with padding data

Kalesh AP (4):
      net/bnxt: fix 50G and 100G forced speed
      net/bnxt: fix speed change from 200G to 25G on Thor
      net/bnxt: fix backward firmware compatibility
      net/bnxt: fix null pointer dereference

Kamil Vojanec (1):
      examples/l3fwd: fix Rx queue configuration

Kevin Traynor (1):
      net/ixgbe: increase VF reset timeout

Kiran Kumar K (1):
      net/cnxk: fix flow RSS configuration

Kishore Padmanabha (1):
      net/bnxt: fix number of Tx queues being created

Kommula Shiva Shankar (1):
      common/cnxk: fix RSS RETA configuration

Konstantin Ananyev (1):
      examples/l3fwd: fix Rx over not ready port

Kumara Parameshwaran (3):
      gro: fix reordering of packets
      app/testpmd: fix GRO packets flush on timeout
      app/testpmd: return if no packets in GRO heavy weight mode

Long Li (3):
      net/mana: prevent values overflow returned from RDMA layer
      net/mana: fix memory leak on MR allocation
      net/mana: handle MR cache expansion failure

Long Wu (5):
      net/nfp: fix Rx memory leak
      net/nfp: fix Rx descriptor
      net/nfp: fix device close
      net/nfp: fix device resource freeing
      net/nfp: free switch domain ID on close

Maayan Kashani (1):
      net/mlx5: fix DR context release ordering

Masoumeh Farhadi Nia (1):
      examples/ipsec-secgw: fix typo in error message

Maxime Coquelin (3):
      vhost: fix memory leak in Virtio Tx split path
      vhost: fix VDUSE device destruction failure
      net/virtio: fix vDPA device init advertising control queue

Michael Baum (9):
      net/mlx5: fix jump action validation
      net/mlx5: fix flow tag modification
      net/mlx5/hws: fix ESP flow matching validation
      net/mlx5: fix GENEVE TLV option management
      common/mlx5: fix duplicate read of general capabilities
      common/mlx5: fix query sample info capability
      net/mlx5: remove GENEVE options length limitation
      net/mlx5: fix GENEVE option item translation
      net/mlx5/hws: enable multiple integrity items

Mingjin Ye (3):
      net/iavf: fix no polling mode switching
      test: fix probing in secondary process
      bus/vdev: fix devargs in secondary process

Morten Brørup (3):
      event/dlb2: remove superfluous memcpy
      net/bnx2x: fix warnings about memcpy lengths
      net/mlx5: fix warning about copy length

Mário Kuka (1):
      net/bonding: fix flow count query

Neel Patel (1):
      net/ionic: fix missing volatile type for cqe pointers

Nithin Dabilpuram (5):
      common/cnxk: remove CN9K inline IPsec FP opcodes
      net/cnxk: fix buffer size configuration
      common/cnxk: fix Tx MTU configuration
      net/cnxk: fix indirect mbuf handling in Tx
      common/cnxk: fix mbox struct attributes

Pavan Nikhilesh (2):
      event/cnxk: fix dequeue timeout configuration
      doc: fix commands in eventdev test tool guide

Pengfei Sun (1):
      net/mlx5: fix use after free when releasing Tx queues

Qi Zhang (2):
      net/ice: fix link update
      net/ice: fix memory leaks

Qian Hao (1):
      examples/packet_ordering: fix Rx with reorder mode disabled

Qin Ke (1):
      net/nfp: fix getting firmware VNIC version

Radu Nicolau (1):
      examples/ipsec-secgw: fix cryptodev to SA mapping

Rahul Bhansali (5):
      common/cnxk: fix inline device pointer check
      net/cnxk: fix Rx packet format check condition
      net/cnxk: add cookies check for multi-segment offload
      net/cnxk: fix mbuf fields in multi-segment Tx
      net/cnxk: improve Tx performance for SW mbuf free

Rakesh Kudurumalla (1):
      test/mbuf: fix external mbuf case with assert enabled

Robin Jarry (3):
      build: link static libs with whole-archive in subproject
      test: assume C source files are UTF-8 encoded
      build: pass cflags in subproject

Rongwei Liu (3):
      net/mlx5: fix stats query crash in secondary process
      app/testpmd: fix flow modify tag typo
      net/mlx5: fix modify flex item

Rushil Gupta (1):
      net/gve: fix DQO for chained descriptors

Satheesh Paul (3):
      net/cnxk: fix aged flow query
      common/cnxk: remove dead code
      common/cnxk: fix possible out-of-bounds access

Shai Brandes (5):
      net/ena: fix fast mbuf free
      net/ena/base: limit exponential backoff
      net/ena/base: restructure interrupt handling
      net/ena: fix mbuf double free in fast free mode
      net/ena/base: fix metrics excessive memory consumption

Shani Peretz (1):
      app/testpmd: fix auto-completion for indirect action list

Shaowei Sun (1):
      telemetry: fix connected clients count

Shihong Wang (2):
      net/nfp: fix IPsec data endianness
      examples/ipsec-secgw: fix Rx queue ID in Rx callback

Shiyang He (1):
      net/iavf: fix crash on VF start

Shun Hao (1):
      net/mlx5: fix meter policy priority

Simei Su (1):
      doc: fix default IP fragments maximum in programmer guide

Sivaprasad Tummala (1):
      eal/x86: add AMD vendor check for TSC calibration

Sivaramakrishnan Venkat (1):
      drivers/net: fix buffer overflow for packet types list

Stephen Hemminger (7):
      doc: remove cmdline polling mode deprecation notice
      cryptodev: remove unused extern variable
      doc: add --latencystats option in testpmd guide
      app/testpmd: hide --bitrate-stats in help if disabled
      common/sfc_efx/base: use C11 static assert
      net/tap: do not overwrite flow API errors
      net/tap: fix traffic control handle calculation

Suanming Mou (6):
      app/crypto-perf: fix next segment mbuf
      app/crypto-perf: fix data comparison
      app/crypto-perf: fix encrypt operation verification
      app/crypto-perf: fix copy segment size
      app/crypto-perf: fix out-of-place mbuf size
      app/crypto-perf: add missing op resubmission

Sunil Kumar Kori (1):
      net/cnxk: fix MTU limit

Sunyang Wu (1):
      ethdev: fix NVGRE encap flow action description

Tom Jones (1):
      net/vmxnet3: ignore Rx queue interrupt setup on FreeBSD

Viacheslav Ovsiienko (1):
      net/mlx5: fix error packets drop in regular Rx

Wathsala Vithanage (1):
      net/memif: fix extra mbuf refcnt update in zero copy Tx

Weiguo Li (1):
      net/bnxt: fix deadlock in ULP timer callback

Wenwu Ma (1):
      net/igc: fix timesync disable

Xueming Li (1):
      23.11.1-rc1

Yajun Wu (1):
      vdpa/mlx5: fix queue enable drain CQ

Yunjian Wang (4):
      net/iavf: fix memory leak on security context error
      net/ixgbe: fix memoy leak after device init failure
      net/af_xdp: fix memzone leak on config failure
      net/af_xdp: fix leak on XSK configuration failure

Re: 23.11.1 patches review and test

[YangHang Liu]

[-- Attachment #1: Type: text/plain, Size: 18496 bytes --]

RedHat QE tested below 18 scenarios on RHEL 9.4 and didn't find any new
dpdk issues.

   - VM with device assignment(PF) throughput testing(1G hugepage size):
   PASS
   - VM with device assignment(PF) throughput testing(2M hugepage size) :
   PASS
   - VM with device assignment(VF) throughput testing: PASS
   - PVP (host dpdk testpmd as vswitch) 1Q: throughput testing: PASS
   - PVP vhost-user 2Q throughput testing: PASS
   - PVP vhost-user 1Q - cross numa node throughput testing: PASS
   - VM with vhost-user 2 queues throughput testing: PASS
   - vhost-user reconnect with dpdk-client, qemu-server qemu reconnect: PASS
   - vhost-user reconnect with dpdk-client, qemu-server ovs reconnect: PASS
   - PVP  reconnect with dpdk-client, qemu-server: PASS
   - PVP 1Q live migration testing: PASS
   - PVP 1Q cross numa node live migration testing: PASS
   - VM with ovs+dpdk+vhost-user 1Q live migration testing: PASS
   - VM with ovs+dpdk+vhost-user 1Q live migration testing (2M): PASS
   - VM with ovs+dpdk+vhost-user 2Q live migration testing: PASS
   - VM with ovs+dpdk+vhost-user 4Q live migration testing: PASS
   - Host PF + DPDK testing: PASS
   - Host VF + DPDK testing: PASS

Test Versions:

   - qemu-kvm-8.2.0
   - kernel 5.14
   - libvirt 10.0
   - git log

               Commit 51783c9b605a408ee9d72200347de6e5cbd2daf7
               Author: Xueming Li <xuemingl@nvidia.com>
               Date:   Tue May 7 14:37:37 2024 +0800
               version: 23.11.1-rc2
               Signed-off-by: Xueming Li <xuemingl@nvidia.com>


   - Test device : X540-AT2 NIC(ixgbe, 10G)

Tested-by: Yanghang Liu<yanghliu@redhat.com>


On Tue, May 7, 2024 at 3:32 PM Xueming Li <xuemingl@nvidia.com> wrote:

> Hi all,
>
> Here is a list of patches targeted for stable release 23.11.1.
>
> The planned date for the final release is 17th May.
>
> Please help with testing and validation of your use cases and report
> any issues/results with reply-all to this mail. For the final release
> the fixes and reported validations will be added to the release notes.
>
> A release candidate tarball can be found at:
>
>     https://dpdk.org/browse/dpdk-stable/tag/?id=v23.11.1-rc2
>
> These patches are located at branch 23.11 of dpdk-stable repo:
>     https://dpdk.org/browse/dpdk-stable/
>
> Thanks.
>
> Xueming Li <xuemingl@nvidia.com>
>
> ---
> Ajit Khaparde (2):
>       net/bnxt: fix array overflow
>       net/bnxt: modify locking for representor Tx
>
> Akhil Goyal (1):
>       common/cnxk: fix memory leak in CPT init
>
> Akshay Dorwat (1):
>       net/ionic: fix RSS query
>
> Alan Elder (2):
>       net: add macros for VLAN metadata parsing
>       net/netvsc: fix VLAN metadata parsing
>
> Alex Vesker (3):
>       net/mlx5/hws: fix direct index insert on depend WQE
>       net/mlx5/hws: fix memory access in L3 decapsulation
>       net/mlx5/hws: fix tunnel protocol checks
>
> Ali Alnubani (1):
>       doc: update link to Windows DevX in mlx5 guide
>
> Andrew Boyer (2):
>       net/ionic: fix device close
>       doc: fix typos in cryptodev overview
>
> Ankur Dwivedi (1):
>       doc: fix aging poll frequency option in cnxk guide
>
> Anoob Joseph (1):
>       examples/ipsec-secgw: fix width of variables
>
> Anup Prabhu (1):
>       ml/cnxk: fix xstats calculation
>
> Arkadiusz Kusztal (2):
>       common/qat: fix legacy flag
>       crypto/qat: fix crash with CCM null AAD pointer
>
> Bing Zhao (7):
>       net/mlx5: prevent querying aged flows on uninit port
>       net/mlx5: fix condition of LACP miss flow
>       net/mlx5: fix HWS registers initialization
>       net/mlx5: fix counters map in bonding mode
>       net/mlx5: remove device status check in flow creation
>       net/mlx5: fix age position in hairpin split
>       net/mlx5: fix drop action release timing
>
> Bruce Richardson (11):
>       buildtools/cmdline: fix generated code for IP addresses
>       buildtools/cmdline: fix IP address initializer
>       kernel/freebsd: fix module build on FreeBSD 14
>       build: fix linker warnings about undefined symbols
>       net/vmxnet3: fix initialization on FreeBSD
>       eventdev: improve Doxygen comments on configure struct
>       eventdev: fix Doxygen processing of vector struct
>       net/i40e: remove incorrect 16B descriptor read block
>       net/iavf: remove incorrect 16B descriptor read block
>       net/ice: remove incorrect 16B descriptor read block
>       test: do not count skipped tests as executed
>
> Chaoyong He (12):
>       net/nfp: fix resource leak for device initialization
>       net/nfp: fix resource leak for CoreNIC firmware
>       net/nfp: fix resource leak for PF initialization
>       net/nfp: fix resource leak for flower firmware
>       net/nfp: fix resource leak for exit of CoreNIC firmware
>       net/nfp: fix resource leak for exit of flower firmware
>       net/nfp: fix resource leak for VF
>       net/nfp: fix NFD3 metadata process
>       net/nfp: fix NFDk metadata process
>       net/nfp: fix switch domain free check
>       net/nfp: fix initialization failure flow
>       net/nfp: fix uninitialized variable
>
> Chengwen Feng (17):
>       eal: verify strdup return
>       bus/dpaa: verify strdup return
>       bus/fslmc: verify strdup return
>       bus/vdev: verify strdup return
>       dma/idxd: verify strdup return
>       event/cnxk: verify strdup return
>       net/failsafe: fix memory leak in args parsing
>       net/nfp: verify strdup return
>       app/dumpcap: verify strdup return
>       app/pdump: verify strdup return
>       app/crypto-perf: verify strdup return
>       app/dma-perf: verify strdup return
>       app/testpmd: verify strdup return
>       test: verify strdup return
>       examples/qos_sched: fix memory leak in args parsing
>       examples/vhost: verify strdup return
>       net/hns3: remove QinQ insert support for VF
>
> Cristian Dumitrescu (1):
>       net/softnic: fix include of log library
>
> Dariusz Sosnowski (9):
>       app/testpmd: fix async flow create failure handling
>       net/mlx5: fix conntrack action handle representation
>       net/mlx5: fix connection tracking action validation
>       net/mlx5: fix VLAN handling in meter split
>       net/mlx5: fix flow counter cache starvation
>       net/mlx5: fix template clean up of FDB control flow rule
>       net/mlx5: fix flow configure validation
>       net/mlx5: fix async flow create error handling
>       net/mlx5: fix rollback on failed flow configure
>
> David Marchand (17):
>       hash: remove some dead code
>       regexdev: fix logtype register
>       lib: use dedicated logtypes and macros
>       lib: add newline in logs
>       lib: remove redundant newline from logs
>       dma/dpaa2: fix logtype register
>       build: fix reasons conflict
>       app/graph: fix build reason
>       ci: update versions of actions in GHA
>       vhost: fix virtqueue access check in datapath
>       vhost: fix virtqueue access check in VDUSE setup
>       vhost: fix virtqueue access check in vhost-user setup
>       test/event: skip test if no driver is present
>       net/iavf: remove error logs for VLAN offloading
>       app/testpmd: fix --stats-period option check
>       app/testpmd: fix burst option parsing
>       app/testpmd: fix error message for invalid option
>
> Dengdui Huang (8):
>       net/hns3: refactor VF mailbox message struct
>       net/hns3: refactor PF mailbox message struct
>       net/hns3: refactor send mailbox function
>       net/hns3: refactor handle mailbox function
>       net/hns3: fix VF multiple count on one reset
>       net/hns3: fix disable command with firmware
>       net/hns3: fix reset level comparison
>       app/testpmd: fix crash in multi-process forwarding
>
> Edwin Brossette (2):
>       net/virtio: remove duplicate queue xstats
>       net/ixgbevf: fix RSS init for x550 NICs
>
> Eli Britstein (1):
>       net/mlx5: prevent ioctl failure log flooding
>
> Emi Aoki (1):
>       doc: fix typo in profiling guide
>
> Erez Shitrit (2):
>       net/mlx5/hws: check not supported fields in VXLAN
>       net/mlx5/hws: fix port ID for root table
>
> Ferruh Yigit (8):
>       pipeline: fix calloc parameters
>       eventdev: fix calloc parameters
>       dmadev: fix calloc parameters
>       rawdev: fix calloc parameters
>       common/mlx5: fix calloc parameters
>       net/bnx2x: fix calloc parameters
>       net/nfp: fix calloc parameters
>       net/sfc: fix calloc parameters
>
> Fidel Castro (1):
>       test/power: fix typo in error message
>
> Flore Norceide (1):
>       doc: fix typo in packet framework guide
>
> Ganapati Kundapura (2):
>       test/event: fix crash in Tx adapter freeing
>       eventdev/crypto: fix enqueueing
>
> Gowrishankar Muthukrishnan (1):
>       crypto/cnxk: fix CN9K ECDH public key verification
>
> Gregory Etelson (11):
>       net/mlx5: fix parameters verification in HWS table create
>       net/mlx5: fix flow action template expansion
>       app/testpmd: fix async indirect action list creation
>       net/mlx5: fix HWS meter actions availability
>       net/mlx5: fix sync meter processing in HWS
>       net/mlx5: fix indirect action async job initialization
>       net/mlx5: fix non-masked indirect list meter translation
>       net/mlx5: fix VLAN ID in flow modify
>       net/mlx5: remove duplication of L3 flow item validation
>       net/mlx5: fix IP-in-IP tunnels recognition
>       net/mlx5: fix sync flow meter action
>
> Hamdan Igbaria (2):
>       net/mlx5/hws: fix VLAN item in non-relaxed mode
>       net/mlx5/hws: fix VLAN inner type
>
> Hanumanth Pothula (1):
>       net/thunderx: fix DMAC control register update
>
> Hao Chen (1):
>       vhost: fix deadlock during vDPA SW live migration
>
> Harman Kalra (3):
>       common/cnxk: fix mbox region copy
>       common/cnxk: fix VLAN check for inner header
>       common/cnxk: fix link config for SDP
>
> Hernan Vargas (1):
>       doc: fix configuration in baseband 5GNR driver guide
>
> Holly Nichols (1):
>       test/cfgfile: fix typo in error messages
>
> Honnappa Nagarahalli (2):
>       rcu: use atomic operation on acked token
>       rcu: fix acked token in debug log
>
> Huisong Li (2):
>       doc: add traffic manager in features table
>       doc: add link speeds configuration in features table
>
> Itamar Gozlan (1):
>       net/mlx5/hws: skip item when inserting rules by index
>
> Jie Hai (2):
>       net/hns3: enable PFC for all user priorities
>       net/hns3: support new device
>
> Jonathan Erb (1):
>       telemetry: fix empty JSON dictionaries
>
> Joyce Kong (2):
>       net/memif: fix crash with Tx burst larger than 255
>       config: fix CPU instruction set for cross-build
>
> Juraj Linkeš (2):
>       dts: fix smoke tests driver regex
>       dts: strip whitespaces from stdout and stderr
>
> Kaiwen Deng (3):
>       net/i40e: remove redundant judgment in flow parsing
>       net/ice: fix tunnel TSO capabilities
>       net: fix TCP/UDP checksum with padding data
>
> Kalesh AP (4):
>       net/bnxt: fix 50G and 100G forced speed
>       net/bnxt: fix speed change from 200G to 25G on Thor
>       net/bnxt: fix backward firmware compatibility
>       net/bnxt: fix null pointer dereference
>
> Kamil Vojanec (1):
>       examples/l3fwd: fix Rx queue configuration
>
> Kevin Traynor (1):
>       net/ixgbe: increase VF reset timeout
>
> Kiran Kumar K (1):
>       net/cnxk: fix flow RSS configuration
>
> Kishore Padmanabha (1):
>       net/bnxt: fix number of Tx queues being created
>
> Kommula Shiva Shankar (1):
>       common/cnxk: fix RSS RETA configuration
>
> Konstantin Ananyev (1):
>       examples/l3fwd: fix Rx over not ready port
>
> Kumara Parameshwaran (3):
>       gro: fix reordering of packets
>       app/testpmd: fix GRO packets flush on timeout
>       app/testpmd: return if no packets in GRO heavy weight mode
>
> Long Li (3):
>       net/mana: prevent values overflow returned from RDMA layer
>       net/mana: fix memory leak on MR allocation
>       net/mana: handle MR cache expansion failure
>
> Long Wu (5):
>       net/nfp: fix Rx memory leak
>       net/nfp: fix Rx descriptor
>       net/nfp: fix device close
>       net/nfp: fix device resource freeing
>       net/nfp: free switch domain ID on close
>
> Maayan Kashani (1):
>       net/mlx5: fix DR context release ordering
>
> Masoumeh Farhadi Nia (1):
>       examples/ipsec-secgw: fix typo in error message
>
> Maxime Coquelin (3):
>       vhost: fix memory leak in Virtio Tx split path
>       vhost: fix VDUSE device destruction failure
>       net/virtio: fix vDPA device init advertising control queue
>
> Michael Baum (9):
>       net/mlx5: fix jump action validation
>       net/mlx5: fix flow tag modification
>       net/mlx5/hws: fix ESP flow matching validation
>       net/mlx5: fix GENEVE TLV option management
>       common/mlx5: fix duplicate read of general capabilities
>       common/mlx5: fix query sample info capability
>       net/mlx5: remove GENEVE options length limitation
>       net/mlx5: fix GENEVE option item translation
>       net/mlx5/hws: enable multiple integrity items
>
> Mingjin Ye (3):
>       net/iavf: fix no polling mode switching
>       test: fix probing in secondary process
>       bus/vdev: fix devargs in secondary process
>
> Morten Brørup (3):
>       event/dlb2: remove superfluous memcpy
>       net/bnx2x: fix warnings about memcpy lengths
>       net/mlx5: fix warning about copy length
>
> Mário Kuka (1):
>       net/bonding: fix flow count query
>
> Neel Patel (1):
>       net/ionic: fix missing volatile type for cqe pointers
>
> Nithin Dabilpuram (5):
>       common/cnxk: remove CN9K inline IPsec FP opcodes
>       net/cnxk: fix buffer size configuration
>       common/cnxk: fix Tx MTU configuration
>       net/cnxk: fix indirect mbuf handling in Tx
>       common/cnxk: fix mbox struct attributes
>
> Pavan Nikhilesh (2):
>       event/cnxk: fix dequeue timeout configuration
>       doc: fix commands in eventdev test tool guide
>
> Pengfei Sun (1):
>       net/mlx5: fix use after free when releasing Tx queues
>
> Qi Zhang (2):
>       net/ice: fix link update
>       net/ice: fix memory leaks
>
> Qian Hao (1):
>       examples/packet_ordering: fix Rx with reorder mode disabled
>
> Qin Ke (1):
>       net/nfp: fix getting firmware VNIC version
>
> Radu Nicolau (1):
>       examples/ipsec-secgw: fix cryptodev to SA mapping
>
> Rahul Bhansali (5):
>       common/cnxk: fix inline device pointer check
>       net/cnxk: fix Rx packet format check condition
>       net/cnxk: add cookies check for multi-segment offload
>       net/cnxk: fix mbuf fields in multi-segment Tx
>       net/cnxk: improve Tx performance for SW mbuf free
>
> Rakesh Kudurumalla (1):
>       test/mbuf: fix external mbuf case with assert enabled
>
> Robin Jarry (3):
>       build: link static libs with whole-archive in subproject
>       test: assume C source files are UTF-8 encoded
>       build: pass cflags in subproject
>
> Rongwei Liu (3):
>       net/mlx5: fix stats query crash in secondary process
>       app/testpmd: fix flow modify tag typo
>       net/mlx5: fix modify flex item
>
> Rushil Gupta (1):
>       net/gve: fix DQO for chained descriptors
>
> Satheesh Paul (3):
>       net/cnxk: fix aged flow query
>       common/cnxk: remove dead code
>       common/cnxk: fix possible out-of-bounds access
>
> Shai Brandes (5):
>       net/ena: fix fast mbuf free
>       net/ena/base: limit exponential backoff
>       net/ena/base: restructure interrupt handling
>       net/ena: fix mbuf double free in fast free mode
>       net/ena/base: fix metrics excessive memory consumption
>
> Shani Peretz (1):
>       app/testpmd: fix auto-completion for indirect action list
>
> Shaowei Sun (1):
>       telemetry: fix connected clients count
>
> Shihong Wang (2):
>       net/nfp: fix IPsec data endianness
>       examples/ipsec-secgw: fix Rx queue ID in Rx callback
>
> Shiyang He (1):
>       net/iavf: fix crash on VF start
>
> Shun Hao (1):
>       net/mlx5: fix meter policy priority
>
> Simei Su (1):
>       doc: fix default IP fragments maximum in programmer guide
>
> Sivaprasad Tummala (1):
>       eal/x86: add AMD vendor check for TSC calibration
>
> Sivaramakrishnan Venkat (1):
>       drivers/net: fix buffer overflow for packet types list
>
> Stephen Hemminger (7):
>       doc: remove cmdline polling mode deprecation notice
>       cryptodev: remove unused extern variable
>       doc: add --latencystats option in testpmd guide
>       app/testpmd: hide --bitrate-stats in help if disabled
>       common/sfc_efx/base: use C11 static assert
>       net/tap: do not overwrite flow API errors
>       net/tap: fix traffic control handle calculation
>
> Suanming Mou (6):
>       app/crypto-perf: fix next segment mbuf
>       app/crypto-perf: fix data comparison
>       app/crypto-perf: fix encrypt operation verification
>       app/crypto-perf: fix copy segment size
>       app/crypto-perf: fix out-of-place mbuf size
>       app/crypto-perf: add missing op resubmission
>
> Sunil Kumar Kori (1):
>       net/cnxk: fix MTU limit
>
> Sunyang Wu (1):
>       ethdev: fix NVGRE encap flow action description
>
> Tom Jones (1):
>       net/vmxnet3: ignore Rx queue interrupt setup on FreeBSD
>
> Viacheslav Ovsiienko (1):
>       net/mlx5: fix error packets drop in regular Rx
>
> Wathsala Vithanage (1):
>       net/memif: fix extra mbuf refcnt update in zero copy Tx
>
> Weiguo Li (1):
>       net/bnxt: fix deadlock in ULP timer callback
>
> Wenwu Ma (1):
>       net/igc: fix timesync disable
>
> Xueming Li (1):
>       23.11.1-rc1
>
> Yajun Wu (1):
>       vdpa/mlx5: fix queue enable drain CQ
>
> Yunjian Wang (4):
>       net/iavf: fix memory leak on security context error
>       net/ixgbe: fix memoy leak after device init failure
>       net/af_xdp: fix memzone leak on config failure
>       net/af_xdp: fix leak on XSK configuration failure
>
>

[-- Attachment #2: Type: text/html, Size: 22837 bytes --]

Re: 23.11.1 patches review and test

[Xueming Li]

[-- Attachment #1: Type: text/plain, Size: 18891 bytes --]

Hi YangHang,

Thanks for the verification and feedback!

Best Regards,
Xueming
________________________________
From: YangHang Liu <yanghliu@redhat.com>
Sent: Wednesday, May 8, 2024 5:49 PM
To: Xueming Li <xuemingl@nvidia.com>
Cc: stable@dpdk.org <stable@dpdk.org>; dev@dpdk.org <dev@dpdk.org>; Abhishek Marathe <Abhishek.Marathe@microsoft.com>; Ali Alnubani <alialnu@nvidia.com>; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Raslan Darawsheh <rasland@nvidia.com>; NBU-Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>; benjamin.walker@intel.com <benjamin.walker@intel.com>; qian.q.xu@intel.com <qian.q.xu@intel.com>; yuan.peng@intel.com <yuan.peng@intel.com>; zhaoyan.chen@intel.com <zhaoyan.chen@intel.com>; Chao Yang <chayang@redhat.com>
Subject: Re: 23.11.1 patches review and test

RedHat QE tested below 18 scenarios on RHEL 9.4 and didn't find any new dpdk issues.

  *   VM with device assignment(PF) throughput testing(1G hugepage size): PASS
  *   VM with device assignment(PF) throughput testing(2M hugepage size) : PASS
  *   VM with device assignment(VF) throughput testing: PASS
  *   PVP (host dpdk testpmd as vswitch) 1Q: throughput testing: PASS
  *   PVP vhost-user 2Q throughput testing: PASS
  *   PVP vhost-user 1Q - cross numa node throughput testing: PASS
  *   VM with vhost-user 2 queues throughput testing: PASS
  *   vhost-user reconnect with dpdk-client, qemu-server qemu reconnect: PASS
  *   vhost-user reconnect with dpdk-client, qemu-server ovs reconnect: PASS
  *   PVP  reconnect with dpdk-client, qemu-server: PASS
  *   PVP 1Q live migration testing: PASS
  *   PVP 1Q cross numa node live migration testing: PASS
  *   VM with ovs+dpdk+vhost-user 1Q live migration testing: PASS
  *   VM with ovs+dpdk+vhost-user 1Q live migration testing (2M): PASS
  *   VM with ovs+dpdk+vhost-user 2Q live migration testing: PASS
  *   VM with ovs+dpdk+vhost-user 4Q live migration testing: PASS
  *   Host PF + DPDK testing: PASS
  *   Host VF + DPDK testing: PASS

Test Versions:

  *   qemu-kvm-8.2.0
  *   kernel 5.14
  *   libvirt 10.0
  *   git log

               Commit 51783c9b605a408ee9d72200347de6e5cbd2daf7
               Author: Xueming Li <xuemingl@nvidia.com<mailto:xuemingl@nvidia.com>>
               Date:   Tue May 7 14:37:37 2024 +0800
               version: 23.11.1-rc2
               Signed-off-by: Xueming Li <xuemingl@nvidia.com<mailto:xuemingl@nvidia.com>>

  *   Test device : X540-AT2 NIC(ixgbe, 10G)

Tested-by: Yanghang Liu<yanghliu@redhat.com<mailto:yanghliu@redhat.com>>


On Tue, May 7, 2024 at 3:32 PM Xueming Li <xuemingl@nvidia.com<mailto:xuemingl@nvidia.com>> wrote:
Hi all,

Here is a list of patches targeted for stable release 23.11.1.

The planned date for the final release is 17th May.

Please help with testing and validation of your use cases and report
any issues/results with reply-all to this mail. For the final release
the fixes and reported validations will be added to the release notes.

A release candidate tarball can be found at:

    https://dpdk.org/browse/dpdk-stable/tag/?id=v23.11.1-rc2

These patches are located at branch 23.11 of dpdk-stable repo:
    https://dpdk.org/browse/dpdk-stable/

Thanks.

Xueming Li <xuemingl@nvidia.com<mailto:xuemingl@nvidia.com>>

---
Ajit Khaparde (2):
      net/bnxt: fix array overflow
      net/bnxt: modify locking for representor Tx

Akhil Goyal (1):
      common/cnxk: fix memory leak in CPT init

Akshay Dorwat (1):
      net/ionic: fix RSS query

Alan Elder (2):
      net: add macros for VLAN metadata parsing
      net/netvsc: fix VLAN metadata parsing

Alex Vesker (3):
      net/mlx5/hws: fix direct index insert on depend WQE
      net/mlx5/hws: fix memory access in L3 decapsulation
      net/mlx5/hws: fix tunnel protocol checks

Ali Alnubani (1):
      doc: update link to Windows DevX in mlx5 guide

Andrew Boyer (2):
      net/ionic: fix device close
      doc: fix typos in cryptodev overview

Ankur Dwivedi (1):
      doc: fix aging poll frequency option in cnxk guide

Anoob Joseph (1):
      examples/ipsec-secgw: fix width of variables

Anup Prabhu (1):
      ml/cnxk: fix xstats calculation

Arkadiusz Kusztal (2):
      common/qat: fix legacy flag
      crypto/qat: fix crash with CCM null AAD pointer

Bing Zhao (7):
      net/mlx5: prevent querying aged flows on uninit port
      net/mlx5: fix condition of LACP miss flow
      net/mlx5: fix HWS registers initialization
      net/mlx5: fix counters map in bonding mode
      net/mlx5: remove device status check in flow creation
      net/mlx5: fix age position in hairpin split
      net/mlx5: fix drop action release timing

Bruce Richardson (11):
      buildtools/cmdline: fix generated code for IP addresses
      buildtools/cmdline: fix IP address initializer
      kernel/freebsd: fix module build on FreeBSD 14
      build: fix linker warnings about undefined symbols
      net/vmxnet3: fix initialization on FreeBSD
      eventdev: improve Doxygen comments on configure struct
      eventdev: fix Doxygen processing of vector struct
      net/i40e: remove incorrect 16B descriptor read block
      net/iavf: remove incorrect 16B descriptor read block
      net/ice: remove incorrect 16B descriptor read block
      test: do not count skipped tests as executed

Chaoyong He (12):
      net/nfp: fix resource leak for device initialization
      net/nfp: fix resource leak for CoreNIC firmware
      net/nfp: fix resource leak for PF initialization
      net/nfp: fix resource leak for flower firmware
      net/nfp: fix resource leak for exit of CoreNIC firmware
      net/nfp: fix resource leak for exit of flower firmware
      net/nfp: fix resource leak for VF
      net/nfp: fix NFD3 metadata process
      net/nfp: fix NFDk metadata process
      net/nfp: fix switch domain free check
      net/nfp: fix initialization failure flow
      net/nfp: fix uninitialized variable

Chengwen Feng (17):
      eal: verify strdup return
      bus/dpaa: verify strdup return
      bus/fslmc: verify strdup return
      bus/vdev: verify strdup return
      dma/idxd: verify strdup return
      event/cnxk: verify strdup return
      net/failsafe: fix memory leak in args parsing
      net/nfp: verify strdup return
      app/dumpcap: verify strdup return
      app/pdump: verify strdup return
      app/crypto-perf: verify strdup return
      app/dma-perf: verify strdup return
      app/testpmd: verify strdup return
      test: verify strdup return
      examples/qos_sched: fix memory leak in args parsing
      examples/vhost: verify strdup return
      net/hns3: remove QinQ insert support for VF

Cristian Dumitrescu (1):
      net/softnic: fix include of log library

Dariusz Sosnowski (9):
      app/testpmd: fix async flow create failure handling
      net/mlx5: fix conntrack action handle representation
      net/mlx5: fix connection tracking action validation
      net/mlx5: fix VLAN handling in meter split
      net/mlx5: fix flow counter cache starvation
      net/mlx5: fix template clean up of FDB control flow rule
      net/mlx5: fix flow configure validation
      net/mlx5: fix async flow create error handling
      net/mlx5: fix rollback on failed flow configure

David Marchand (17):
      hash: remove some dead code
      regexdev: fix logtype register
      lib: use dedicated logtypes and macros
      lib: add newline in logs
      lib: remove redundant newline from logs
      dma/dpaa2: fix logtype register
      build: fix reasons conflict
      app/graph: fix build reason
      ci: update versions of actions in GHA
      vhost: fix virtqueue access check in datapath
      vhost: fix virtqueue access check in VDUSE setup
      vhost: fix virtqueue access check in vhost-user setup
      test/event: skip test if no driver is present
      net/iavf: remove error logs for VLAN offloading
      app/testpmd: fix --stats-period option check
      app/testpmd: fix burst option parsing
      app/testpmd: fix error message for invalid option

Dengdui Huang (8):
      net/hns3: refactor VF mailbox message struct
      net/hns3: refactor PF mailbox message struct
      net/hns3: refactor send mailbox function
      net/hns3: refactor handle mailbox function
      net/hns3: fix VF multiple count on one reset
      net/hns3: fix disable command with firmware
      net/hns3: fix reset level comparison
      app/testpmd: fix crash in multi-process forwarding

Edwin Brossette (2):
      net/virtio: remove duplicate queue xstats
      net/ixgbevf: fix RSS init for x550 NICs

Eli Britstein (1):
      net/mlx5: prevent ioctl failure log flooding

Emi Aoki (1):
      doc: fix typo in profiling guide

Erez Shitrit (2):
      net/mlx5/hws: check not supported fields in VXLAN
      net/mlx5/hws: fix port ID for root table

Ferruh Yigit (8):
      pipeline: fix calloc parameters
      eventdev: fix calloc parameters
      dmadev: fix calloc parameters
      rawdev: fix calloc parameters
      common/mlx5: fix calloc parameters
      net/bnx2x: fix calloc parameters
      net/nfp: fix calloc parameters
      net/sfc: fix calloc parameters

Fidel Castro (1):
      test/power: fix typo in error message

Flore Norceide (1):
      doc: fix typo in packet framework guide

Ganapati Kundapura (2):
      test/event: fix crash in Tx adapter freeing
      eventdev/crypto: fix enqueueing

Gowrishankar Muthukrishnan (1):
      crypto/cnxk: fix CN9K ECDH public key verification

Gregory Etelson (11):
      net/mlx5: fix parameters verification in HWS table create
      net/mlx5: fix flow action template expansion
      app/testpmd: fix async indirect action list creation
      net/mlx5: fix HWS meter actions availability
      net/mlx5: fix sync meter processing in HWS
      net/mlx5: fix indirect action async job initialization
      net/mlx5: fix non-masked indirect list meter translation
      net/mlx5: fix VLAN ID in flow modify
      net/mlx5: remove duplication of L3 flow item validation
      net/mlx5: fix IP-in-IP tunnels recognition
      net/mlx5: fix sync flow meter action

Hamdan Igbaria (2):
      net/mlx5/hws: fix VLAN item in non-relaxed mode
      net/mlx5/hws: fix VLAN inner type

Hanumanth Pothula (1):
      net/thunderx: fix DMAC control register update

Hao Chen (1):
      vhost: fix deadlock during vDPA SW live migration

Harman Kalra (3):
      common/cnxk: fix mbox region copy
      common/cnxk: fix VLAN check for inner header
      common/cnxk: fix link config for SDP

Hernan Vargas (1):
      doc: fix configuration in baseband 5GNR driver guide

Holly Nichols (1):
      test/cfgfile: fix typo in error messages

Honnappa Nagarahalli (2):
      rcu: use atomic operation on acked token
      rcu: fix acked token in debug log

Huisong Li (2):
      doc: add traffic manager in features table
      doc: add link speeds configuration in features table

Itamar Gozlan (1):
      net/mlx5/hws: skip item when inserting rules by index

Jie Hai (2):
      net/hns3: enable PFC for all user priorities
      net/hns3: support new device

Jonathan Erb (1):
      telemetry: fix empty JSON dictionaries

Joyce Kong (2):
      net/memif: fix crash with Tx burst larger than 255
      config: fix CPU instruction set for cross-build

Juraj Linkeš (2):
      dts: fix smoke tests driver regex
      dts: strip whitespaces from stdout and stderr

Kaiwen Deng (3):
      net/i40e: remove redundant judgment in flow parsing
      net/ice: fix tunnel TSO capabilities
      net: fix TCP/UDP checksum with padding data

Kalesh AP (4):
      net/bnxt: fix 50G and 100G forced speed
      net/bnxt: fix speed change from 200G to 25G on Thor
      net/bnxt: fix backward firmware compatibility
      net/bnxt: fix null pointer dereference

Kamil Vojanec (1):
      examples/l3fwd: fix Rx queue configuration

Kevin Traynor (1):
      net/ixgbe: increase VF reset timeout

Kiran Kumar K (1):
      net/cnxk: fix flow RSS configuration

Kishore Padmanabha (1):
      net/bnxt: fix number of Tx queues being created

Kommula Shiva Shankar (1):
      common/cnxk: fix RSS RETA configuration

Konstantin Ananyev (1):
      examples/l3fwd: fix Rx over not ready port

Kumara Parameshwaran (3):
      gro: fix reordering of packets
      app/testpmd: fix GRO packets flush on timeout
      app/testpmd: return if no packets in GRO heavy weight mode

Long Li (3):
      net/mana: prevent values overflow returned from RDMA layer
      net/mana: fix memory leak on MR allocation
      net/mana: handle MR cache expansion failure

Long Wu (5):
      net/nfp: fix Rx memory leak
      net/nfp: fix Rx descriptor
      net/nfp: fix device close
      net/nfp: fix device resource freeing
      net/nfp: free switch domain ID on close

Maayan Kashani (1):
      net/mlx5: fix DR context release ordering

Masoumeh Farhadi Nia (1):
      examples/ipsec-secgw: fix typo in error message

Maxime Coquelin (3):
      vhost: fix memory leak in Virtio Tx split path
      vhost: fix VDUSE device destruction failure
      net/virtio: fix vDPA device init advertising control queue

Michael Baum (9):
      net/mlx5: fix jump action validation
      net/mlx5: fix flow tag modification
      net/mlx5/hws: fix ESP flow matching validation
      net/mlx5: fix GENEVE TLV option management
      common/mlx5: fix duplicate read of general capabilities
      common/mlx5: fix query sample info capability
      net/mlx5: remove GENEVE options length limitation
      net/mlx5: fix GENEVE option item translation
      net/mlx5/hws: enable multiple integrity items

Mingjin Ye (3):
      net/iavf: fix no polling mode switching
      test: fix probing in secondary process
      bus/vdev: fix devargs in secondary process

Morten Brørup (3):
      event/dlb2: remove superfluous memcpy
      net/bnx2x: fix warnings about memcpy lengths
      net/mlx5: fix warning about copy length

Mário Kuka (1):
      net/bonding: fix flow count query

Neel Patel (1):
      net/ionic: fix missing volatile type for cqe pointers

Nithin Dabilpuram (5):
      common/cnxk: remove CN9K inline IPsec FP opcodes
      net/cnxk: fix buffer size configuration
      common/cnxk: fix Tx MTU configuration
      net/cnxk: fix indirect mbuf handling in Tx
      common/cnxk: fix mbox struct attributes

Pavan Nikhilesh (2):
      event/cnxk: fix dequeue timeout configuration
      doc: fix commands in eventdev test tool guide

Pengfei Sun (1):
      net/mlx5: fix use after free when releasing Tx queues

Qi Zhang (2):
      net/ice: fix link update
      net/ice: fix memory leaks

Qian Hao (1):
      examples/packet_ordering: fix Rx with reorder mode disabled

Qin Ke (1):
      net/nfp: fix getting firmware VNIC version

Radu Nicolau (1):
      examples/ipsec-secgw: fix cryptodev to SA mapping

Rahul Bhansali (5):
      common/cnxk: fix inline device pointer check
      net/cnxk: fix Rx packet format check condition
      net/cnxk: add cookies check for multi-segment offload
      net/cnxk: fix mbuf fields in multi-segment Tx
      net/cnxk: improve Tx performance for SW mbuf free

Rakesh Kudurumalla (1):
      test/mbuf: fix external mbuf case with assert enabled

Robin Jarry (3):
      build: link static libs with whole-archive in subproject
      test: assume C source files are UTF-8 encoded
      build: pass cflags in subproject

Rongwei Liu (3):
      net/mlx5: fix stats query crash in secondary process
      app/testpmd: fix flow modify tag typo
      net/mlx5: fix modify flex item

Rushil Gupta (1):
      net/gve: fix DQO for chained descriptors

Satheesh Paul (3):
      net/cnxk: fix aged flow query
      common/cnxk: remove dead code
      common/cnxk: fix possible out-of-bounds access

Shai Brandes (5):
      net/ena: fix fast mbuf free
      net/ena/base: limit exponential backoff
      net/ena/base: restructure interrupt handling
      net/ena: fix mbuf double free in fast free mode
      net/ena/base: fix metrics excessive memory consumption

Shani Peretz (1):
      app/testpmd: fix auto-completion for indirect action list

Shaowei Sun (1):
      telemetry: fix connected clients count

Shihong Wang (2):
      net/nfp: fix IPsec data endianness
      examples/ipsec-secgw: fix Rx queue ID in Rx callback

Shiyang He (1):
      net/iavf: fix crash on VF start

Shun Hao (1):
      net/mlx5: fix meter policy priority

Simei Su (1):
      doc: fix default IP fragments maximum in programmer guide

Sivaprasad Tummala (1):
      eal/x86: add AMD vendor check for TSC calibration

Sivaramakrishnan Venkat (1):
      drivers/net: fix buffer overflow for packet types list

Stephen Hemminger (7):
      doc: remove cmdline polling mode deprecation notice
      cryptodev: remove unused extern variable
      doc: add --latencystats option in testpmd guide
      app/testpmd: hide --bitrate-stats in help if disabled
      common/sfc_efx/base: use C11 static assert
      net/tap: do not overwrite flow API errors
      net/tap: fix traffic control handle calculation

Suanming Mou (6):
      app/crypto-perf: fix next segment mbuf
      app/crypto-perf: fix data comparison
      app/crypto-perf: fix encrypt operation verification
      app/crypto-perf: fix copy segment size
      app/crypto-perf: fix out-of-place mbuf size
      app/crypto-perf: add missing op resubmission

Sunil Kumar Kori (1):
      net/cnxk: fix MTU limit

Sunyang Wu (1):
      ethdev: fix NVGRE encap flow action description

Tom Jones (1):
      net/vmxnet3: ignore Rx queue interrupt setup on FreeBSD

Viacheslav Ovsiienko (1):
      net/mlx5: fix error packets drop in regular Rx

Wathsala Vithanage (1):
      net/memif: fix extra mbuf refcnt update in zero copy Tx

Weiguo Li (1):
      net/bnxt: fix deadlock in ULP timer callback

Wenwu Ma (1):
      net/igc: fix timesync disable

Xueming Li (1):
      23.11.1-rc1

Yajun Wu (1):
      vdpa/mlx5: fix queue enable drain CQ

Yunjian Wang (4):
      net/iavf: fix memory leak on security context error
      net/ixgbe: fix memoy leak after device init failure
      net/af_xdp: fix memzone leak on config failure
      net/af_xdp: fix leak on XSK configuration failure


[-- Attachment #2: Type: text/html, Size: 28913 bytes --]

RE: 23.11.1 patches review and test

[Ali Alnubani]

> -----Original Message-----
> From: Xueming Li <xuemingl@nvidia.com>
> Sent: Tuesday, May 7, 2024 10:32 AM
> To: stable@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> Ali Alnubani <alialnu@nvidia.com>; David Christensen
> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
> Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John
> McNamara <john.mcnamara@intel.com>; Ju-Hyoung Lee
> <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca
> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Raslan
> Darawsheh <rasland@nvidia.com>; NBU-Contact-Thomas Monjalon
> (EXTERNAL) <thomas@monjalon.net>; Yanghang Liu <yanghliu@redhat.com>;
> benjamin.walker@intel.com; qian.q.xu@intel.com; yuan.peng@intel.com;
> zhaoyan.chen@intel.com
> Subject: 23.11.1 patches review and test
> 
> Hi all,
> 
> Here is a list of patches targeted for stable release 23.11.1.
> 
> The planned date for the final release is 17th May.
> 
> Please help with testing and validation of your use cases and report
> any issues/results with reply-all to this mail. For the final release
> the fixes and reported validations will be added to the release notes.
> 
> A release candidate tarball can be found at:
> 
>     https://dpdk.org/browse/dpdk-stable/tag/?id=v23.11.1-rc2
> 
> These patches are located at branch 23.11 of dpdk-stable repo:
>     https://dpdk.org/browse/dpdk-stable/
> 
> Thanks.
> 
> Xueming Li <xuemingl@nvidia.com>
> 
> ---

Hello Xueming,

We ran the following functional tests with Nvidia hardware on v23.11.1-rc2:
- Basic functionality:
  Send and receive multiple types of traffic.
- testpmd xstats counter test.
- testpmd timestamp test.
- Changing/checking link status through testpmd.
- rte_flow tests (https://doc.dpdk.org/guides/nics/mlx5.html#supported-hardware-offloads)
- RSS tests.
- VLAN filtering, stripping, and insertion tests.
- Checksum and TSO tests.
- ptype tests.
- link_status_interrupt example application tests.
- l3fwd-power example application tests.
- Multi-process example applications tests.
- Hardware LRO tests.
- Buffer Split tests.
- Tx scheduling tests.

Functional tests ran on:
- NIC: ConnectX-6 Dx / OS: Ubuntu 20.04 / Driver: MLNX_OFED_LINUX-24.04-0.6.6.0 / Firmware: 22.41.1000
- NIC: ConnectX-7 / OS: Ubuntu 20.04 / Driver: MLNX_OFED_LINUX-24.04-0.6.6.0 / Firmware: 28.41.1000
- DPU: BlueField-2 / DOCA SW version: 2.7.0 / Firmware: 24.41.1000

Additionally, we ran build tests with multiple configurations on the following OS/driver combinations (all passed):
- Debian 12 with MLNX_OFED_LINUX-24.01-0.3.3.1.
- Ubuntu 20.04.6 with MLNX_OFED_LINUX-24.01-0.3.3.1.
- Ubuntu 22.04.4 with MLNX_OFED_LINUX-24.04-0.6.6.0.
- Ubuntu 20.04.6 with rdma-core master (311c591).
- Ubuntu 20.04.6 with rdma-core v28.0.
- Fedora 40 with rdma-core v48.0.
- Fedora 41 (Rawhide) with rdma-core v51.0.
- OpenSUSE Leap 15.5 with rdma-core v42.0.
- Windows Server 2019 with Clang 16.0.6.

We don't see new issues caused by the changes in this release.

Thanks,
Ali

Re: 23.11.1 patches review and test

[Xueming Li]

[-- Attachment #1: Type: text/plain, Size: 4225 bytes --]

Hi Ali,

Thanks for the verification.

Best Regards,
Xueming
________________________________
From: Ali Alnubani <alialnu@nvidia.com>
Sent: Wednesday, May 15, 2024 1:36 AM
To: Xueming Li <xuemingl@nvidia.com>; stable@dpdk.org <stable@dpdk.org>
Cc: dev@dpdk.org <dev@dpdk.org>; Abhishek Marathe <Abhishek.Marathe@microsoft.com>; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Raslan Darawsheh <rasland@nvidia.com>; NBU-Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>; Yanghang Liu <yanghliu@redhat.com>; benjamin.walker@intel.com <benjamin.walker@intel.com>; qian.q.xu@intel.com <qian.q.xu@intel.com>; yuan.peng@intel.com <yuan.peng@intel.com>; zhaoyan.chen@intel.com <zhaoyan.chen@intel.com>; Maayan Kashani <mkashani@nvidia.com>
Subject: RE: 23.11.1 patches review and test

> -----Original Message-----
> From: Xueming Li <xuemingl@nvidia.com>
> Sent: Tuesday, May 7, 2024 10:32 AM
> To: stable@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> Ali Alnubani <alialnu@nvidia.com>; David Christensen
> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
> Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John
> McNamara <john.mcnamara@intel.com>; Ju-Hyoung Lee
> <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca
> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Raslan
> Darawsheh <rasland@nvidia.com>; NBU-Contact-Thomas Monjalon
> (EXTERNAL) <thomas@monjalon.net>; Yanghang Liu <yanghliu@redhat.com>;
> benjamin.walker@intel.com; qian.q.xu@intel.com; yuan.peng@intel.com;
> zhaoyan.chen@intel.com
> Subject: 23.11.1 patches review and test
>
> Hi all,
>
> Here is a list of patches targeted for stable release 23.11.1.
>
> The planned date for the final release is 17th May.
>
> Please help with testing and validation of your use cases and report
> any issues/results with reply-all to this mail. For the final release
> the fixes and reported validations will be added to the release notes.
>
> A release candidate tarball can be found at:
>
>     https://dpdk.org/browse/dpdk-stable/tag/?id=v23.11.1-rc2
>
> These patches are located at branch 23.11 of dpdk-stable repo:
>     https://dpdk.org/browse/dpdk-stable/
>
> Thanks.
>
> Xueming Li <xuemingl@nvidia.com>
>
> ---

Hello Xueming,

We ran the following functional tests with Nvidia hardware on v23.11.1-rc2:
- Basic functionality:
  Send and receive multiple types of traffic.
- testpmd xstats counter test.
- testpmd timestamp test.
- Changing/checking link status through testpmd.
- rte_flow tests (https://doc.dpdk.org/guides/nics/mlx5.html#supported-hardware-offloads)
- RSS tests.
- VLAN filtering, stripping, and insertion tests.
- Checksum and TSO tests.
- ptype tests.
- link_status_interrupt example application tests.
- l3fwd-power example application tests.
- Multi-process example applications tests.
- Hardware LRO tests.
- Buffer Split tests.
- Tx scheduling tests.

Functional tests ran on:
- NIC: ConnectX-6 Dx / OS: Ubuntu 20.04 / Driver: MLNX_OFED_LINUX-24.04-0.6.6.0 / Firmware: 22.41.1000
- NIC: ConnectX-7 / OS: Ubuntu 20.04 / Driver: MLNX_OFED_LINUX-24.04-0.6.6.0 / Firmware: 28.41.1000
- DPU: BlueField-2 / DOCA SW version: 2.7.0 / Firmware: 24.41.1000

Additionally, we ran build tests with multiple configurations on the following OS/driver combinations (all passed):
- Debian 12 with MLNX_OFED_LINUX-24.01-0.3.3.1.
- Ubuntu 20.04.6 with MLNX_OFED_LINUX-24.01-0.3.3.1.
- Ubuntu 22.04.4 with MLNX_OFED_LINUX-24.04-0.6.6.0.
- Ubuntu 20.04.6 with rdma-core master (311c591).
- Ubuntu 20.04.6 with rdma-core v28.0.
- Fedora 40 with rdma-core v48.0.
- Fedora 41 (Rawhide) with rdma-core v51.0.
- OpenSUSE Leap 15.5 with rdma-core v42.0.
- Windows Server 2019 with Clang 16.0.6.

We don't see new issues caused by the changes in this release.

Thanks,
Ali

[-- Attachment #2: Type: text/html, Size: 6812 bytes --]

RE: 23.11.1 patches review and test

[Xu, HailinX]

> -----Original Message-----
> From: Xueming Li <xuemingl@nvidia.com>
> Sent: Tuesday, May 7, 2024 3:32 PM
> To: stable@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> Ali Alnubani <alialnu@nvidia.com>; David Christensen
> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>;
> Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee
> <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca
> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Raslan
> Darawsheh <rasland@nvidia.com>; Thomas Monjalon
> <thomas@monjalon.net>; Yanghang Liu <yanghliu@redhat.com>;
> benjamin.walker@intel.com; qian.q.xu@intel.com; yuan.peng@intel.com;
> zhaoyan.chen@intel.com
> Subject: 23.11.1 patches review and test
> 
> Hi all,
> 
> Here is a list of patches targeted for stable release 23.11.1.
> 
> The planned date for the final release is 17th May.
> 
> Please help with testing and validation of your use cases and report any
> issues/results with reply-all to this mail. For the final release the fixes and
> reported validations will be added to the release notes.
> 
> A release candidate tarball can be found at:
> 
>     https://dpdk.org/browse/dpdk-stable/tag/?id=v23.11.1-rc2
> 
> These patches are located at branch 23.11 of dpdk-stable repo:
>     https://dpdk.org/browse/dpdk-stable/
> 
> Thanks.

Update the test status for Intel part. dpdk23.11.1-rc2 all validation test done. no new issue is found.

known issue:
Start dpdk-pdump in VM with virtio-0.95 protocol failed: fix patches has been merged into main, but they not merged 23.11.1. so this issue still exists in 23.11.1-rc2
Patch link: 
  https://patchwork.dpdk.org/project/dpdk/patch/20231122102232.108299-2-mingjinx.ye@intel.com/
  https://patchwork.dpdk.org/project/dpdk/patch/20231122102232.108299-3-mingjinx.ye@intel.com/

# Basic Intel(R) NIC testing
* Build & CFLAG compile: cover the build test combination with latest GCC/Clang version and the popular OS revision such as
  Ubuntu23.10, Ubuntu22.04, Fedora39, RHEL8.9, RHEL9.2, FreeBSD14.0, SUSE15, CentOS7.9, openEuler22.03-SP2，OpenAnolis8.8 etc.
- All test done. No new dpdk issue is found.
* PF(i40e, ixgbe): test scenarios including RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc. 
- All test done. No new dpdk issue is found.
* VF(i40e, ixgbe): test scenarios including VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.		
- All test done. No new dpdk issue is found.
* PF/VF(ice): test scenarios including Switch features/Package Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc.
- All test done. No new dpdk issue is found.
* Intel NIC single core/NIC performance: test scenarios including PF/VF single core performance test, etc.
- All test done. No new dpdk issue is found.
* IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - QAT&SW/FIB library, etc.
- All test done. No new dpdk issue is found.
		
# Basic cryptodev and virtio testing
* Virtio: both function and performance test are covered. Such as PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing/VMAWARE ESXI 8.0, etc.
- All test done. No new dpdk issue is found.
* Cryptodev: 
  *Function test: test scenarios including Cryptodev API testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
    - All test done. No new dpdk issue is found.
  *Performance test: test scenarios including Thoughput Performance/Cryptodev Latency, etc.
    - All test done. No new dpdk issue is found.


Regards,
Xu, Hailin

Re: 23.11.1 patches review and test

[Xueming Li]

[-- Attachment #1: Type: text/plain, Size: 4757 bytes --]

Hi Hailin,

Thanks for the verficiation.
________________________________
From: Xu, HailinX <hailinx.xu@intel.com>
Sent: Thursday, May 16, 2024 6:01 PM
To: Xueming Li <xuemingl@nvidia.com>; stable@dpdk.org <stable@dpdk.org>
Cc: dev@dpdk.org <dev@dpdk.org>; Abhishek Marathe <Abhishek.Marathe@microsoft.com>; Ali Alnubani <alialnu@nvidia.com>; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Raslan Darawsheh <rasland@nvidia.com>; NBU-Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>; Yanghang Liu <yanghliu@redhat.com>; benjamin.walker@intel.com <benjamin.walker@intel.com>; qian.q.xu@intel.com <qian.q.xu@intel.com>; yuan.peng@intel.com <yuan.peng@intel.com>; zhaoyan.chen@intel.com <zhaoyan.chen@intel.com>
Subject: RE: 23.11.1 patches review and test

> -----Original Message-----
> From: Xueming Li <xuemingl@nvidia.com>
> Sent: Tuesday, May 7, 2024 3:32 PM
> To: stable@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> Ali Alnubani <alialnu@nvidia.com>; David Christensen
> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>;
> Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee
> <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca
> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Raslan
> Darawsheh <rasland@nvidia.com>; Thomas Monjalon
> <thomas@monjalon.net>; Yanghang Liu <yanghliu@redhat.com>;
> benjamin.walker@intel.com; qian.q.xu@intel.com; yuan.peng@intel.com;
> zhaoyan.chen@intel.com
> Subject: 23.11.1 patches review and test
>
> Hi all,
>
> Here is a list of patches targeted for stable release 23.11.1.
>
> The planned date for the final release is 17th May.
>
> Please help with testing and validation of your use cases and report any
> issues/results with reply-all to this mail. For the final release the fixes and
> reported validations will be added to the release notes.
>
> A release candidate tarball can be found at:
>
>     https://dpdk.org/browse/dpdk-stable/tag/?id=v23.11.1-rc2
>
> These patches are located at branch 23.11 of dpdk-stable repo:
>     https://dpdk.org/browse/dpdk-stable/
>
> Thanks.

Update the test status for Intel part. dpdk23.11.1-rc2 all validation test done. no new issue is found.

known issue:
Start dpdk-pdump in VM with virtio-0.95 protocol failed: fix patches has been merged into main, but they not merged 23.11.1. so this issue still exists in 23.11.1-rc2
Patch link:
  https://patchwork.dpdk.org/project/dpdk/patch/20231122102232.108299-2-mingjinx.ye@intel.com/
  https://patchwork.dpdk.org/project/dpdk/patch/20231122102232.108299-3-mingjinx.ye@intel.com/

# Basic Intel(R) NIC testing
* Build & CFLAG compile: cover the build test combination with latest GCC/Clang version and the popular OS revision such as
  Ubuntu23.10, Ubuntu22.04, Fedora39, RHEL8.9, RHEL9.2, FreeBSD14.0, SUSE15, CentOS7.9, openEuler22.03-SP2，OpenAnolis8.8 etc.
- All test done. No new dpdk issue is found.
* PF(i40e, ixgbe): test scenarios including RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
- All test done. No new dpdk issue is found.
* VF(i40e, ixgbe): test scenarios including VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
- All test done. No new dpdk issue is found.
* PF/VF(ice): test scenarios including Switch features/Package Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc.
- All test done. No new dpdk issue is found.
* Intel NIC single core/NIC performance: test scenarios including PF/VF single core performance test, etc.
- All test done. No new dpdk issue is found.
* IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - QAT&SW/FIB library, etc.
- All test done. No new dpdk issue is found.

# Basic cryptodev and virtio testing
* Virtio: both function and performance test are covered. Such as PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing/VMAWARE ESXI 8.0, etc.
- All test done. No new dpdk issue is found.
* Cryptodev:
  *Function test: test scenarios including Cryptodev API testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
    - All test done. No new dpdk issue is found.
  *Performance test: test scenarios including Thoughput Performance/Cryptodev Latency, etc.
    - All test done. No new dpdk issue is found.


Regards,
Xu, Hailin


[-- Attachment #2: Type: text/html, Size: 7142 bytes --]