From: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
To: <ferruh.yigit@amd.com>, <david.marchand@redhat.com>,
<aman.deep.singh@intel.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: [PATCH v3] app/testpmd: fix lcore ID restriction
Date: Thu, 6 Jun 2024 11:27:46 +0000 [thread overview]
Message-ID: <20240606112746.2643600-1-sivaprasad.tummala@amd.com> (raw)
In-Reply-To: <20240416095556.173787-1-sivaprasad.tummala@amd.com>
With modern CPUs, it is possible to have higher
CPU count thus we can have higher RTE_MAX_LCORES.
In testpmd application, the current config forwarding
cores option "--nb-cores" is hard limited to 255.
The patch fixes this constraint and also adjusts the lcore
data structure to 32-bit to align with rte lcore APIs.
Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org
Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
---
v3:
* Removed unnecessary cast
v2:
* Fixed type mistmatch in comparison
* Fixed incorrect format specifier
---
app/test-pmd/config.c | 4 ++--
app/test-pmd/parameters.c | 4 ++--
app/test-pmd/testpmd.h | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index ba1007ace6..a0c8bb8fe1 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -4785,9 +4785,9 @@ fwd_stream_on_other_lcores(uint16_t domain_id, lcoreid_t src_lc,
continue;
printf("Shared Rx queue group %u queue %hu can't be scheduled on different cores:\n",
share_group, share_rxq);
- printf(" lcore %hhu Port %hu queue %hu\n",
+ printf(" lcore %u Port %hu queue %hu\n",
src_lc, src_port, src_rxq);
- printf(" lcore %hhu Port %hu queue %hu\n",
+ printf(" lcore %u Port %hu queue %hu\n",
lc_id, fs->rx_port, fs->rx_queue);
printf("Please use --nb-cores=%hu to limit number of forwarding cores\n",
nb_rxq);
diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index c13f7564bf..22364e09ab 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -1071,8 +1071,8 @@ launch_args_parse(int argc, char** argv)
break;
case TESTPMD_OPT_NB_CORES_NUM:
n = atoi(optarg);
- if (n > 0 && n <= nb_lcores)
- nb_fwd_lcores = (uint8_t) n;
+ if (n > 0 && (lcoreid_t)n <= nb_lcores)
+ nb_fwd_lcores = (lcoreid_t) n;
else
rte_exit(EXIT_FAILURE,
"nb-cores should be > 0 and <= %d\n",
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index 0afae7d771..9facd7f281 100644
--- a/app/test-pmd/testpmd.h
+++ b/app/test-pmd/testpmd.h
@@ -84,7 +84,7 @@ extern volatile uint8_t f_quit;
/* Maximum number of pools supported per Rx queue */
#define MAX_MEMPOOL 8
-typedef uint8_t lcoreid_t;
+typedef uint32_t lcoreid_t;
typedef uint16_t portid_t;
typedef uint16_t queueid_t;
typedef uint16_t streamid_t;
--
2.34.1
next prev parent reply other threads:[~2024-06-06 11:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 19:46 [PATCH] " Sivaprasad Tummala
2024-04-15 21:54 ` Stephen Hemminger
2024-04-15 21:56 ` Stephen Hemminger
2024-04-16 9:55 ` [PATCH v2] " Sivaprasad Tummala
2024-04-19 8:24 ` Ferruh Yigit
2024-04-19 11:30 ` Ferruh Yigit
2024-06-06 9:56 ` Tummala, Sivaprasad
2024-06-13 16:51 ` Ferruh Yigit
2024-06-13 19:13 ` Stephen Hemminger
2024-06-14 9:01 ` Ferruh Yigit
2024-06-14 15:27 ` Stephen Hemminger
2024-06-14 15:39 ` Ferruh Yigit
2024-06-14 17:50 ` Morten Brørup
2024-06-14 18:11 ` Stephen Hemminger
2024-06-06 11:27 ` Sivaprasad Tummala [this message]
2024-06-11 23:37 ` [PATCH v3] " Ferruh Yigit
2024-06-13 16:36 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240606112746.2643600-1-sivaprasad.tummala@amd.com \
--to=sivaprasad.tummala@amd.com \
--cc=aman.deep.singh@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).