From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 807FA45489 for ; Tue, 18 Jun 2024 09:13:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A74A042799; Tue, 18 Jun 2024 09:12:51 +0200 (CEST) Received: from smtpbg150.qq.com (smtpbg150.qq.com [18.132.163.193]) by mails.dpdk.org (Postfix) with ESMTP id 7160440DFB; Tue, 18 Jun 2024 09:12:20 +0200 (CEST) X-QQ-mid: bizesmtpsz1t1718694738te1du7o X-QQ-Originating-IP: +30Xz4CBaDf3K22MKboavPkDRMV2R0h2dcDnAyD45rY= Received: from lap-jiawenwu.trustnetic.com ( [183.159.97.141]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 18 Jun 2024 15:12:17 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 6171117367589274429 From: Jiawen Wu To: dev@dpdk.org Cc: Jiawen Wu , stable@dpdk.org Subject: [PATCH 11/19] net/ngbe: fix hotplug remove Date: Tue, 18 Jun 2024 15:11:42 +0800 Message-Id: <20240618071150.21564-12-jiawenwu@trustnetic.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20240618071150.21564-1-jiawenwu@trustnetic.com> References: <20240618071150.21564-1-jiawenwu@trustnetic.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtpsz:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz8a-1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org This bug occurs in OpenvSwitch. After adding a port bound to vfio-pci to ovs, detach it from ovs and then unbind it from vfio-pci(that is hotplug) will cause operating system to get stuck. Fixes: 6ee7e574cd48 ("net/ngbe: support probe and remove") Cc: stable@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c index 2a858b76d0..9d75e222c3 100644 --- a/drivers/net/ngbe/ngbe_ethdev.c +++ b/drivers/net/ngbe/ngbe_ethdev.c @@ -547,7 +547,7 @@ static int eth_ngbe_pci_remove(struct rte_pci_device *pci_dev) if (ethdev == NULL) return 0; - return rte_eth_dev_destroy(ethdev, eth_ngbe_dev_uninit); + return rte_eth_dev_pci_generic_remove(pci_dev, eth_ngbe_dev_uninit); } static struct rte_pci_driver rte_ngbe_pmd = { -- 2.27.0