From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 14BA8454E8 for ; Tue, 25 Jun 2024 01:59:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E698C4026F; Tue, 25 Jun 2024 01:59:22 +0200 (CEST) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mails.dpdk.org (Postfix) with ESMTP id 2CBAD400EF for ; Tue, 25 Jun 2024 01:59:22 +0200 (CEST) Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-36226e98370so3090885f8f.3 for ; Mon, 24 Jun 2024 16:59:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719273562; x=1719878362; darn=dpdk.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=cY4E2twMfsNpibN9V4uMGXgYiqTD+FaXH5Y/FudAtKU=; b=IIfOqg43P/Q1BrMn27jqu0QaEY8LBgGCrFe0lSgsWwYDNYGa/Giofx0JN+fXiCv7v3 vC0nUr5n9CalSpk9w2aQlKmK+fx324z9loxFxgyvzIyvSwyKZB3rTyolKK4ekdoQuZco A56VJAyjda5Sg6jQZd0H4TnjTjcgJTSe2Yzp6s1hE7bqBM3jWjw1L5WVMWle5huvsLip nEa+ePEGuFWkKan67JTaRASowxMFq7wB0dSBEpa6EflN9/AVrN+QoLBEBbr6IuaeDely tMo64lO04Mv9kQM/4ImYJg4NtrOpMfL0rQ/24pDG/aa61m1Z+x1nEdb7wy1NVVUfwaLx o8aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719273562; x=1719878362; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cY4E2twMfsNpibN9V4uMGXgYiqTD+FaXH5Y/FudAtKU=; b=qiyYduxi/GSwCBE1lZ9uEmqen7PfIU/FnUZgyYSYvkX0XIS3mo0mjE+nI5M6W/JwWh 3371dbXTMdwJMDgbg9SChEnGywbbUEgyMaH4sM//m+9SCXiZG9zkDweJSrv745tejOgb ZXqDyvMD38cTSUku3QHVb9fOwZJGE8D9Qsv7m5cuCBD4s/fIR2z73FRd1lqPLb+tPPly VrnmLzHdcJ6S0Uxw5LKpkXaEzAzFkGhjp5H64ixgIMLojHZ+KVdh2h5S3gcW3vTxMxPn da1cLtid1P14bP3y4Qy9zlHq8+b61CIrP/ptNlIIdz5xH9oWYmq+8y4rLPPxNLmz4QWB Z0ww== X-Forwarded-Encrypted: i=1; AJvYcCVpzcnWWhSSLgytZGfdOyHiYpa63DfSAUI2q/uGkdBeRz/A5XuFFPL/17/A9Az+4rcq7ZH+chvvbBnqtYpDVqc= X-Gm-Message-State: AOJu0YwGUcfm4oms09DIZ9klZCv/Aanr1KFCg+4oOkxgicwIsPO/6wIy 2iK/41Te3dXhmPsCLH9UzZXiA3xDhoxlGo0sylIUVy+3vy5yFJE7owKPyw== X-Google-Smtp-Source: AGHT+IFVVWhDxPv58wdNSuiOD2kPEBLQ9maPtx6KN9J+YKblSvCrEhVu8FJVgvQY9vw6VZWtUhw2tg== X-Received: by 2002:a5d:64c6:0:b0:364:aafb:6068 with SMTP id ffacd0b85a97d-366e95eaee1mr4911149f8f.51.1719273561395; Mon, 24 Jun 2024 16:59:21 -0700 (PDT) Received: from localhost ([137.220.120.171]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4247fe1b5desm173355335e9.4.2024.06.24.16.59.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jun 2024 16:59:20 -0700 (PDT) From: luca.boccassi@gmail.com To: Christian Ehrhardt Cc: Luca Boccassi , dpdk stable Subject: patch 'test: force IOVA mode on PPC64 without huge pages' has been queued to stable release 22.11.6 Date: Tue, 25 Jun 2024 00:57:47 +0100 Message-Id: <20240624235907.885628-1-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/27/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/9dc3826a4a05b41de3325af68b61cb00599f4e90 Thanks. Luca Boccassi --- >From 9dc3826a4a05b41de3325af68b61cb00599f4e90 Mon Sep 17 00:00:00 2001 From: Christian Ehrhardt Date: Tue, 28 Nov 2023 15:40:45 +0100 Subject: [PATCH] test: force IOVA mode on PPC64 without huge pages [ upstream commit 6b07762e949036389030cf5a1a9bb8a1e4d6ee2d ] On ppc64, without huge pages, pa would be the default but fails like: EAL: Cannot use IOVA as 'PA' since physical addresses are not available On a normal system setup we'd expect an admin to set up huge pages and for the unlikely case that they do not do that set iova=va themselves. But the testing infrastructure does not have this conscious admin that will do that, so fix test execution that by adjusting the tests arguments accordingly if the conditions are met. Signed-off-by: Christian Ehrhardt Acked-by: Luca Boccassi --- app/test/meson.build | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/app/test/meson.build b/app/test/meson.build index 4e39c9e7cf..eee02cd8ff 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -474,15 +474,21 @@ dpdk_test = executable('dpdk-test', driver_install_path), install: true) -has_hugepage = run_command(py3, 'has_hugepage.py', check: true).stdout().strip() != '0' -message('hugepage availability: @0@'.format(has_hugepage)) - # some perf tests (eg: memcpy perf autotest)take very long # to complete, so timeout to 10 minutes timeout_seconds = 600 timeout_seconds_fast = 10 test_no_huge_args = ['--no-huge', '-m', '2048'] +has_hugepage = run_command(py3, 'has_hugepage.py', check: true).stdout().strip() != '0' +message('hugepage availability: @0@'.format(has_hugepage)) +if not has_hugepage + if arch_subdir == 'ppc' + # On ppc64, without huge pages, PA would be the default but fails like: + # EAL: Cannot use IOVA as 'PA' since physical addresses are not available + test_no_huge_args += '--iova-mode=va' + endif +endif foreach arg : fast_tests test_args = [] -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-06-25 00:22:13.345210209 +0100 +++ 0001-test-force-IOVA-mode-on-PPC64-without-huge-pages.patch 2024-06-25 00:22:13.053182958 +0100 @@ -1 +1 @@ -From 6b07762e949036389030cf5a1a9bb8a1e4d6ee2d Mon Sep 17 00:00:00 2001 +From 9dc3826a4a05b41de3325af68b61cb00599f4e90 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 6b07762e949036389030cf5a1a9bb8a1e4d6ee2d ] + @@ -18,2 +20,2 @@ - app/test/suites/meson.build | 7 +++++++ - 1 file changed, 7 insertions(+) + app/test/meson.build | 12 +++++++++--- + 1 file changed, 9 insertions(+), 3 deletions(-) @@ -21,5 +23,16 @@ -diff --git a/app/test/suites/meson.build b/app/test/suites/meson.build -index 478f245a54..191702cf76 100644 ---- a/app/test/suites/meson.build -+++ b/app/test/suites/meson.build -@@ -9,6 +9,13 @@ timeout_seconds_fast = 10 +diff --git a/app/test/meson.build b/app/test/meson.build +index 4e39c9e7cf..eee02cd8ff 100644 +--- a/app/test/meson.build ++++ b/app/test/meson.build +@@ -474,15 +474,21 @@ dpdk_test = executable('dpdk-test', + driver_install_path), + install: true) + +-has_hugepage = run_command(py3, 'has_hugepage.py', check: true).stdout().strip() != '0' +-message('hugepage availability: @0@'.format(has_hugepage)) +- + # some perf tests (eg: memcpy perf autotest)take very long + # to complete, so timeout to 10 minutes + timeout_seconds = 600 + timeout_seconds_fast = 10 + @@ -27,2 +40,2 @@ - has_hugepage = run_command(has_hugepages_cmd, check: true).stdout().strip() != '0' - message('hugepage availability: @0@'.format(has_hugepage)) ++has_hugepage = run_command(py3, 'has_hugepage.py', check: true).stdout().strip() != '0' ++message('hugepage availability: @0@'.format(has_hugepage)) @@ -37,2 +50,2 @@ - # process source files to determine the different unit test suites - # - fast_tests + foreach arg : fast_tests + test_args = []