From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E583E454E9 for ; Tue, 25 Jun 2024 02:00:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E1596410F2; Tue, 25 Jun 2024 02:00:58 +0200 (CEST) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mails.dpdk.org (Postfix) with ESMTP id 722C740EDD for ; Tue, 25 Jun 2024 02:00:57 +0200 (CEST) Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-366e70d0330so1701726f8f.1 for ; Mon, 24 Jun 2024 17:00:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719273657; x=1719878457; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=a9LMP46AevYBCdmbcX/q18CaPpgTM+aHD2f+bo23HbI=; b=cq9KBWZ1Be5OgjgAx+9vDsGarkxCu0quaBo0YiHlmEl+nQmlsjvYbXCh5LLxrNQz1e LgCl5OSIxxC9wEqRHjMSx2EkMxWlQqwQkRgYU1niVG9g77QV+CNNYPH1V7kIrvQxpv1s VK08sSXDsB25quKN2mQNENZ6oJ7Ducao/F7efLrvQtpiu7pzG3k9aRl4Ih63fcU+dre5 Vqspry1tLkzFKVUffAE090O7ydTTHNWuEUCv5z6Jk1UO9Lv35C8+UyXYQW+9mO4kjrQk DUuNib00MfVG7uTRkFpYDqILHJRHabMmklLWaP5qVxNlNoxoH+bpGIKGxrk1FQe5Oyni QdWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719273657; x=1719878457; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a9LMP46AevYBCdmbcX/q18CaPpgTM+aHD2f+bo23HbI=; b=mZlvlDoAJCtpk0PTOBvN3jKX1wfbZoYZQwwxVfzrZ9wNvUSn66Ki3/4VAnscq+Wqew f7k2zHqAfipbbUC9yiG+IxzGS2U/AFr9+4u7YzCS/4uUnb/aCfYTjlzhjXQtKbUTKsGG +QdOFWGn8EoWZzhfNrzo4Kyj+uDWJMpjFCVbSAIKGBj9yP4kEkC4L1nR34FrPNYq7In3 Z/hszt02SxHMBDjUSWNgZPQLiiuTP/bj4PUwI9iYBELDXygjMTK1Hx2OF/AElV35jm/N 9whd77pdv/EbICPY7vaqMNySL1bTGHKBaiBqOScSEoL0k7d56TFZH64VJLvlY/iDzkxW mG1g== X-Forwarded-Encrypted: i=1; AJvYcCXVBpJAUZbC6VIa9PN+ry/L54PgA9lrJbC/LXTmFaJdynXeMZYR9g5SRM5LuRqNN09EpSYE+89z/Yf19ZW4a5E= X-Gm-Message-State: AOJu0YzfsVQHTVbybBwa6kIRDCwdKRoLvqmTrXx/2IqA/meU5dMjNAnf diMKsTD8GCrvivcPsJqhqZZIj3vPOacLoGZsmK6/KcJEt5sTSD30AkvXyA== X-Google-Smtp-Source: AGHT+IED9YSzI8v265A8m2FIfgLKfX5+G742sD28IjhR6WBWFzSoPg8uamlwh5Pquu0yXvi3MBvKnQ== X-Received: by 2002:adf:e649:0:b0:35f:119a:14c7 with SMTP id ffacd0b85a97d-366e965ff49mr3745626f8f.69.1719273657015; Mon, 24 Jun 2024 17:00:57 -0700 (PDT) Received: from localhost ([137.220.120.171]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-366383f68d2sm11476645f8f.4.2024.06.24.17.00.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jun 2024 17:00:56 -0700 (PDT) From: luca.boccassi@gmail.com To: Venkat Kumar Ande Cc: Selwin Sebastian , dpdk stable Subject: patch 'net/axgbe: check only minimum speed for cables' has been queued to stable release 22.11.6 Date: Tue, 25 Jun 2024 00:58:17 +0100 Message-Id: <20240624235907.885628-31-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240624235907.885628-1-luca.boccassi@gmail.com> References: <20240624235907.885628-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/27/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/08c36b23fdd34beefd1421eb552b2c58c43ba52d Thanks. Luca Boccassi --- >From 08c36b23fdd34beefd1421eb552b2c58c43ba52d Mon Sep 17 00:00:00 2001 From: Venkat Kumar Ande Date: Tue, 4 Jun 2024 17:41:42 +0530 Subject: [PATCH] net/axgbe: check only minimum speed for cables [ upstream commit b5587a39dc94ee0bd055b515cc8c060923ed69b9 ] There are cables that exist that can support speeds in excess of 10GbE. The driver, however, restricts the EEPROM advertised nominal bitrate to a specific range, which can prevent usage of cables that can support, for example, up to 25GbE. Rather than checking that an active or passive cable supports a specific range, only check for a minimum supported speed. Fixes: a5c7273771e8 ("net/axgbe: add phy programming APIs") Signed-off-by: Venkat Kumar Ande Acked-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_phy_impl.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c index 85b01bfa10..12908d4e6f 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -117,9 +117,7 @@ enum axgbe_sfp_speed { #define AXGBE_SFP_BASE_BR 12 #define AXGBE_SFP_BASE_BR_1GBE_MIN 0x0a -#define AXGBE_SFP_BASE_BR_1GBE_MAX 0x0d #define AXGBE_SFP_BASE_BR_10GBE_MIN 0x64 -#define AXGBE_SFP_BASE_BR_10GBE_MAX 0x68 #define AXGBE_SFP_BASE_CU_CABLE_LEN 18 @@ -536,25 +534,22 @@ static void axgbe_phy_sfp_phy_settings(struct axgbe_port *pdata) static bool axgbe_phy_sfp_bit_rate(struct axgbe_sfp_eeprom *sfp_eeprom, enum axgbe_sfp_speed sfp_speed) { - u8 *sfp_base, min, max; + u8 *sfp_base, min; sfp_base = sfp_eeprom->base; switch (sfp_speed) { case AXGBE_SFP_SPEED_1000: min = AXGBE_SFP_BASE_BR_1GBE_MIN; - max = AXGBE_SFP_BASE_BR_1GBE_MAX; break; case AXGBE_SFP_SPEED_10000: min = AXGBE_SFP_BASE_BR_10GBE_MIN; - max = AXGBE_SFP_BASE_BR_10GBE_MAX; break; default: return false; } - return ((sfp_base[AXGBE_SFP_BASE_BR] >= min) && - (sfp_base[AXGBE_SFP_BASE_BR] <= max)); + return sfp_base[AXGBE_SFP_BASE_BR] >= min; } static void axgbe_phy_sfp_external_phy(struct axgbe_port *pdata) -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-06-25 00:22:15.492206733 +0100 +++ 0031-net-axgbe-check-only-minimum-speed-for-cables.patch 2024-06-25 00:22:13.125184426 +0100 @@ -1 +1 @@ -From b5587a39dc94ee0bd055b515cc8c060923ed69b9 Mon Sep 17 00:00:00 2001 +From 08c36b23fdd34beefd1421eb552b2c58c43ba52d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b5587a39dc94ee0bd055b515cc8c060923ed69b9 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index d9585a7404..b6a2a084aa 100644 +index 85b01bfa10..12908d4e6f 100644