From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4FA1454E9 for ; Tue, 25 Jun 2024 02:01:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA4A6410DC; Tue, 25 Jun 2024 02:01:14 +0200 (CEST) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mails.dpdk.org (Postfix) with ESMTP id 287DB40EDD for ; Tue, 25 Jun 2024 02:01:13 +0200 (CEST) Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-366e70d0330so1701834f8f.1 for ; Mon, 24 Jun 2024 17:01:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719273673; x=1719878473; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PEJ+HlKa5hCjkwHos7KN8JRAPmmO7iz/8pjPQ5iqskg=; b=nkQOAuKJccO34p1mAAVH8tsb+zM1QYTaz+zhaVJMgsHHH5bLIFiG2IyA2lcUIHYkiy Z8roFBf4qLD2LWqYB4j5QB7ZGqtEmyI9oygYQcrrCpL2PBk2HB/MqH/e9JNxaF91Ds7Z rLTkQ5nRlQ588ieb8XzkE5H7mALKVvsUd/Ubm6mbZs2V2QSCTnzcYuoJ9aaC27bsrtkH /KfiJDJsJZOpR7Pq5UDOrgGIsWliZqZf5r7aPY4MYdRbe+WqM1vQCICl6l0IyQbDz6FM EP5Sm0or07UXAd1Ijt6GG8H6amdit+aWL31i8rLbprLBhQmNpCK5aesGEnY4KQhzy0Yj 6kCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719273673; x=1719878473; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PEJ+HlKa5hCjkwHos7KN8JRAPmmO7iz/8pjPQ5iqskg=; b=VNsecwz2JB1G3jfY+kXNz/I9viPyrgrsaKQ5nOR8GhJB/ywtI0RNyicJ/5B8o/mDrM YD18/tAA9Ct3WB4j/BDt+3MCx6Gd2h3/ulvtNKUoaGcGWoMUrV8IwOGtzktoVaVj1ctp 33k7DyabiQ25a0ko6+kO+5gPbikiVkS1ytQJDd/2hHrbwvmUePHHIYSL+3EpAxUb1l6X 40LO0qhp2TfV0GL/jx11ltrj1dOZDygwGle44g1qWr/hryt4wVAydabwZn1cNbbS4geJ FN4uXx0AYlByg09rwe1qnZIOUGbUtSWdeuTIPuxnMj/dGNsVSTHWdWmaI3vYzE+gx3nH 1c8w== X-Forwarded-Encrypted: i=1; AJvYcCXMttll9JIH0qoIATxTjhltWeyAX/p8+rdvDmMesFvnJ1NEiy60awy8KtVIW+81MbfgyiUkMQKAlC13+mNml6U= X-Gm-Message-State: AOJu0YxMO6JNJ+4hiGHe2mQEKuTvkDJDgEpJuNO8Y/zOp7iyjoYxOncn TmF0Uw17l2BItKOCEIFeEbHVhvXLd7HqS4tdSow+acO0BSaeb4Hl X-Google-Smtp-Source: AGHT+IFd93pHUUekcqrDVN8ZQWsddKX/Dm7VQjaHwDN/J/LNIn/4AudJO4r9dkywtP9C2oojX+Q8IA== X-Received: by 2002:a5d:6985:0:b0:35f:2364:f1d9 with SMTP id ffacd0b85a97d-366e96567b8mr3611448f8f.61.1719273672768; Mon, 24 Jun 2024 17:01:12 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:7aef:1aaa:3dff:d546]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-366389b86bfsm11312698f8f.40.2024.06.24.17.01.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jun 2024 17:01:12 -0700 (PDT) From: luca.boccassi@gmail.com To: David Marchand Cc: Ferruh Yigit , Ali Alnubani , dpdk stable Subject: patch 'app/testpmd: fix outer IP checksum offload' has been queued to stable release 22.11.6 Date: Tue, 25 Jun 2024 00:58:22 +0100 Message-Id: <20240624235907.885628-36-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240624235907.885628-1-luca.boccassi@gmail.com> References: <20240624235907.885628-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/27/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/0c72bf4c1d8e1382545da4a2b55dfcaa632b0ce3 Thanks. Luca Boccassi --- >From 0c72bf4c1d8e1382545da4a2b55dfcaa632b0ce3 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 18 Apr 2024 10:20:17 +0200 Subject: [PATCH] app/testpmd: fix outer IP checksum offload [ upstream commit b9d859d8a671ec4516face2eba24434b955a9ac1 ] Resetting the outer IP checksum to 0 is not something mandated by the mbuf API and is done by rte_eth_tx_prepare(), or per driver if needed. Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation") Signed-off-by: David Marchand Acked-by: Ferruh Yigit Tested-by: Ali Alnubani --- app/test-pmd/csumonly.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 6170728221..bfe1fc3ddc 100644 --- a/app/test-pmd/csumonly.c +++ b/app/test-pmd/csumonly.c @@ -574,15 +574,17 @@ process_outer_cksums(void *outer_l3_hdr, struct testpmd_offload_info *info, uint64_t ol_flags = 0; if (info->outer_ethertype == _htons(RTE_ETHER_TYPE_IPV4)) { - ipv4_hdr->hdr_checksum = 0; ol_flags |= RTE_MBUF_F_TX_OUTER_IPV4; - if (tx_offloads & RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM) + if (tx_offloads & RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM) { ol_flags |= RTE_MBUF_F_TX_OUTER_IP_CKSUM; - else + } else { + ipv4_hdr->hdr_checksum = 0; ipv4_hdr->hdr_checksum = rte_ipv4_cksum(ipv4_hdr); - } else + } + } else { ol_flags |= RTE_MBUF_F_TX_OUTER_IPV6; + } if (info->outer_l4_proto != IPPROTO_UDP) return ol_flags; -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-06-25 00:22:15.769222946 +0100 +++ 0036-app-testpmd-fix-outer-IP-checksum-offload.patch 2024-06-25 00:22:13.129184507 +0100 @@ -1 +1 @@ -From b9d859d8a671ec4516face2eba24434b955a9ac1 Mon Sep 17 00:00:00 2001 +From 0c72bf4c1d8e1382545da4a2b55dfcaa632b0ce3 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b9d859d8a671ec4516face2eba24434b955a9ac1 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 6711dda42e..f5125c2788 100644 +index 6170728221..bfe1fc3ddc 100644 @@ -23 +24 @@ -@@ -583,15 +583,17 @@ process_outer_cksums(void *outer_l3_hdr, struct testpmd_offload_info *info, +@@ -574,15 +574,17 @@ process_outer_cksums(void *outer_l3_hdr, struct testpmd_offload_info *info,