From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6856D454E9 for ; Tue, 25 Jun 2024 02:01:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 640E641141; Tue, 25 Jun 2024 02:01:18 +0200 (CEST) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by mails.dpdk.org (Postfix) with ESMTP id A2AEC40EDD for ; Tue, 25 Jun 2024 02:01:16 +0200 (CEST) Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4249196a361so12218785e9.0 for ; Mon, 24 Jun 2024 17:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719273676; x=1719878476; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DNWvt3LaEGVQmGPNFpoQSxlynKUDS6SxFc3W5Xh3Ry4=; b=e2qQj7vzLy8bZPACsNiFHIaO8sFe10s7SxYq9F31rqX6o7RNrfip0SrkZRn61vtoNF laQMVwYt2xD3tBaBc9CDXw5iH//uZTV4gUHpG7tnJbd0ThkeJEivXVxFvgPXIdFsjN5T XiVaHQ5IMPfFff9Ioe3cGFe6JMmbgJDGvwdQXaFKVAkyEOlqRXQjIYD3qaWTm4rx4mpW 8ZJMI5jo4Px55cBly+GtfGMCmgOYTBCg+3ajOJiMVZF+69XNALP5V4BHd6ruwEHbJBuf acAj2yHAq+CjR9c/6yPPC+GIYI/RCLO3B3/S4hKbfk7AFR7jJNdjpUFqUHnxMgnrKYKh mvrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719273676; x=1719878476; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DNWvt3LaEGVQmGPNFpoQSxlynKUDS6SxFc3W5Xh3Ry4=; b=rAea5Yxb4Z1r40mRfiM6yG2FRNFck7vz96tHE7dk9cBpvWadfRNVTesqyXwioQkFDb TJek0kgJCUwSh8uQsfVLptVE6yYYJfF+QOaRdzPhbkQXCGZE12oj69Vc3OIEGjNOJSee XpDgBAC4dbP5yumJacUK+ht0GWdZPbqkkAPGdbg8K8sSPVLc5zs5F3Fq3TXYGvCSDCIu SGgEuxNYrn1qBL+T5eixVNnqObXaTFN5SVFwc26BPPhkemXz0nL7lSyMVXzqMHWP7pnV mYTtV9zRC3NZUAIgdBGOlSN6JzvGi2ePdYB7Eg+HQlPQgG9/+cDVKkeP8sm+uOMkF2uw T8cQ== X-Forwarded-Encrypted: i=1; AJvYcCUkYxbj75gOeYlor88KqmaWhI9JyPRG3a0hzCSpzNSd0nKy61nLuJz0gbYdfylnH9rvRa1zRhFBW4YqHlK/4ck= X-Gm-Message-State: AOJu0YzF6EslZ4ejq4qUeaguqClQ0Ysx1/SbhFoXvwClOweaywRsiPae /mPIctp++ao2n0robTbLLmlywtgQKYg3WpBcKHOjv5KsKm0276R6vGSfTA== X-Google-Smtp-Source: AGHT+IFybBP6cx+Q2f29go+fK+ODYONfZkwXUYJ6DwsrjRdVqxkmcsB1XNtntwDuZZ032D0CyP1ZSQ== X-Received: by 2002:a05:600c:3204:b0:421:7296:ba3f with SMTP id 5b1f17b1804b1-4248cc340e9mr38662885e9.22.1719273676229; Mon, 24 Jun 2024 17:01:16 -0700 (PDT) Received: from localhost ([137.220.120.171]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4247d0c54c9sm192688775e9.27.2024.06.24.17.01.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jun 2024 17:01:15 -0700 (PDT) From: luca.boccassi@gmail.com To: David Marchand Cc: Ali Alnubani , dpdk stable Subject: patch 'net/iavf: remove outer UDP checksum offload for X710 VF' has been queued to stable release 22.11.6 Date: Tue, 25 Jun 2024 00:58:25 +0100 Message-Id: <20240624235907.885628-39-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240624235907.885628-1-luca.boccassi@gmail.com> References: <20240624235907.885628-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/27/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/fe02a92fcc01da0abe0429e8c6e0168c0df2d238 Thanks. Luca Boccassi --- >From fe02a92fcc01da0abe0429e8c6e0168c0df2d238 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 18 Apr 2024 10:20:20 +0200 Subject: [PATCH] net/iavf: remove outer UDP checksum offload for X710 VF [ upstream commit 032ba1580bc36f31e431cf8d14dd3dec0079fa9c ] According to the X710 datasheet, X710 devices do not support outer checksum offload. """ 8.4.4.2 Transmit L3 and L4 Integrity Offload Tunneling UDP headers and GRE header are not offloaded while the X710/XXV710/XL710 leaves their checksum field as is. If a checksum is required, software should provide it as well as the inner checksum value(s) that are required for the outer checksum. """ Fix Tx offload capabilities depending on the VF type. Bugzilla ID: 1406 Fixes: f7c8c36fdeb7 ("net/iavf: enable inner and outer Tx checksum offload") Signed-off-by: David Marchand Tested-by: Ali Alnubani --- drivers/net/iavf/iavf_ethdev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index b244d45abb..b6c3cd425d 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -1140,7 +1140,6 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) RTE_ETH_TX_OFFLOAD_TCP_CKSUM | RTE_ETH_TX_OFFLOAD_SCTP_CKSUM | RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM | - RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM | RTE_ETH_TX_OFFLOAD_TCP_TSO | RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO | @@ -1149,6 +1148,10 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) RTE_ETH_TX_OFFLOAD_MULTI_SEGS | RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE; + /* X710 does not support outer udp checksum */ + if (adapter->hw.mac.type != IAVF_MAC_XL710) + dev_info->tx_offload_capa |= RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM; + if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_CRC) dev_info->rx_offload_capa |= RTE_ETH_RX_OFFLOAD_KEEP_CRC; -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-06-25 00:22:15.972408422 +0100 +++ 0039-net-iavf-remove-outer-UDP-checksum-offload-for-X710-.patch 2024-06-25 00:22:13.153184996 +0100 @@ -1 +1 @@ -From 032ba1580bc36f31e431cf8d14dd3dec0079fa9c Mon Sep 17 00:00:00 2001 +From fe02a92fcc01da0abe0429e8c6e0168c0df2d238 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 032ba1580bc36f31e431cf8d14dd3dec0079fa9c ] + @@ -22 +23,0 @@ -Cc: stable@dpdk.org @@ -27,17 +28,3 @@ - doc/guides/nics/features/iavf.ini | 2 +- - drivers/net/iavf/iavf_ethdev.c | 5 ++++- - 2 files changed, 5 insertions(+), 2 deletions(-) - -diff --git a/doc/guides/nics/features/iavf.ini b/doc/guides/nics/features/iavf.ini -index c59115ae15..ce9860e963 100644 ---- a/doc/guides/nics/features/iavf.ini -+++ b/doc/guides/nics/features/iavf.ini -@@ -33,7 +33,7 @@ L3 checksum offload = Y - L4 checksum offload = Y - Timestamp offload = Y - Inner L3 checksum = Y --Inner L4 checksum = Y -+Inner L4 checksum = P - Packet type parsing = Y - Rx descriptor status = Y - Tx descriptor status = Y + drivers/net/iavf/iavf_ethdev.c | 5 ++++- + 1 file changed, 4 insertions(+), 1 deletion(-) + @@ -45 +32 @@ -index 245b3cd854..bbf915097e 100644 +index b244d45abb..b6c3cd425d 100644 @@ -48 +35 @@ -@@ -1174,7 +1174,6 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) +@@ -1140,7 +1140,6 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) @@ -56 +43 @@ -@@ -1183,6 +1182,10 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) +@@ -1149,6 +1148,10 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)