From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9EF2454E9 for ; Tue, 25 Jun 2024 02:02:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B53CD42670; Tue, 25 Jun 2024 02:02:05 +0200 (CEST) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mails.dpdk.org (Postfix) with ESMTP id 4487B40EDD for ; Tue, 25 Jun 2024 02:02:04 +0200 (CEST) Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-42198492353so41516425e9.1 for ; Mon, 24 Jun 2024 17:02:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719273724; x=1719878524; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fV5QXmITGOqeKa+TmD2OpwHb8yqhKth9pfqLb1djmyo=; b=lVUNCx31bbpQYVN77P8I0pbwy+dP002qck64RZtVsatvU+/HqOYmjkkQ3/OD0h3dSM Dto/7Axs+jUhyvfOUE7KztivKmeYPefIjfhIeGvXFtjkg45+ywP/Em2A470n49Ang/xz TVoLrGdIseB0qpv08yXjeK+JRraprXC5bTFYcbJ/xcHTJjhkfDRFCumrnoyC1Sagcp8g ge12CKgKNObDShcCCqlVG7T2jPBHD7hWtM8E63ISO92CorkWRX07fHMNoje+d7c51sSl 2/f7yubCpSXm9eRf556jMqcq9zk+y+Np//3LLG4303VI8vnr6QC6RF283RQhkVNbBNam blVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719273724; x=1719878524; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fV5QXmITGOqeKa+TmD2OpwHb8yqhKth9pfqLb1djmyo=; b=XOgxi4uMqPiibsNy2/28KmomfD56xq3Q3UrwlPD6yGVo6+GzkqAtmFJAGzdrzq++g5 f0B5+dyg/uNwxCvxUzWOYRqrfVqPHiL8nPoNfg07LpFuKYmzl2jYnVRajpV6lZQFjS3y w4dtsYmPm7jYuarL9JR6eBmuv3aWpCJS1Cg93Aziu4INJkWAZ725+A++E79PUObv0LYv 2v96pHXS6gUIrqVpzy/ztCvGZF4NKLrhLgvTXj/Eg5HfDJ+/VfCC5EjD0TLuaYgKpYu4 hhXU07b02CfPmxQEDFmgPRELHtk4XcyjjYIHNfA+n6DxZKa34hTP/neFqkeBdUMJer0x sZkw== X-Forwarded-Encrypted: i=1; AJvYcCXeu/0Gqc19Zd3w8eCNpN4Whz2UN+sFlfU6RUill4VlmQC/NzTDu9VMRsscyPEpdrWmYjBnsHtatxHr+U3okdQ= X-Gm-Message-State: AOJu0Ywd2BP07SsGYZDQie1znHmPyCNtDBKUbkJMaHSWF16VvfHuKxhE 6H1TfuqsEhAzhwN70WII07AuB2QAwvGxzv0vl9b4In0c9SIICEUexs260w== X-Google-Smtp-Source: AGHT+IGHtRofS4hYDNFsOhzT+zCRQBnK6XtOylPtJynMiIXRIctiyMkXXjYlDwKN+fPk3FOeKkXPdA== X-Received: by 2002:a05:600c:1ca2:b0:424:8e12:9ef3 with SMTP id 5b1f17b1804b1-4248e129f6fmr38699625e9.0.1719273723823; Mon, 24 Jun 2024 17:02:03 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:7aef:1aaa:3dff:d546]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-424817b5ca0sm150305495e9.24.2024.06.24.17.02.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jun 2024 17:02:03 -0700 (PDT) From: luca.boccassi@gmail.com To: Anatoly Burakov Cc: Bruce Richardson , dpdk stable Subject: patch 'net/e1000/base: fix link power down' has been queued to stable release 22.11.6 Date: Tue, 25 Jun 2024 00:58:40 +0100 Message-Id: <20240624235907.885628-54-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240624235907.885628-1-luca.boccassi@gmail.com> References: <20240624235907.885628-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/27/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/229bdd77bb5a0b0740caca211792eaaa577bebd4 Thanks. Luca Boccassi --- >From 229bdd77bb5a0b0740caca211792eaaa577bebd4 Mon Sep 17 00:00:00 2001 From: Anatoly Burakov Date: Tue, 14 May 2024 16:17:16 +0100 Subject: [PATCH] net/e1000/base: fix link power down [ upstream commit a8218d09e3aaae5307325ff4b2f92ed4a3c37a8c ] Current code is a result of work to reduce duplication between various device models. However, the logic that was replaced did not exactly match the new logic, and as a result the link power down was not working correctly for some NICs, and the link remained up even when the interface is down. Fix it to correctly power down the link under all circumstances that were supported by old logic. Fixes: 44dddd14059f ("net/e1000/base: remove duplicated codes") Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/e1000/base/e1000_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/e1000/base/e1000_base.c b/drivers/net/e1000/base/e1000_base.c index ab73e1e59e..3ec32e7240 100644 --- a/drivers/net/e1000/base/e1000_base.c +++ b/drivers/net/e1000/base/e1000_base.c @@ -107,7 +107,7 @@ void e1000_power_down_phy_copper_base(struct e1000_hw *hw) return; /* If the management interface is not enabled, then power down */ - if (phy->ops.check_reset_block(hw)) + if (!(e1000_enable_mng_pass_thru(hw) || phy->ops.check_reset_block(hw))) e1000_power_down_phy_copper(hw); } -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-06-25 00:22:16.628461719 +0100 +++ 0054-net-e1000-base-fix-link-power-down.patch 2024-06-25 00:22:13.197185893 +0100 @@ -1 +1 @@ -From a8218d09e3aaae5307325ff4b2f92ed4a3c37a8c Mon Sep 17 00:00:00 2001 +From 229bdd77bb5a0b0740caca211792eaaa577bebd4 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a8218d09e3aaae5307325ff4b2f92ed4a3c37a8c ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org