From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A816454E9 for ; Tue, 25 Jun 2024 02:02:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 259B5427A2; Tue, 25 Jun 2024 02:02:39 +0200 (CEST) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by mails.dpdk.org (Postfix) with ESMTP id 9733940EDD for ; Tue, 25 Jun 2024 02:02:37 +0200 (CEST) Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-42172ed3597so29065705e9.0 for ; Mon, 24 Jun 2024 17:02:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719273757; x=1719878557; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KHxvmzfATjrBHHic3spJCjrxStiR31hP0UkREvhW820=; b=OaAIv7VNV9BiNv6glfpf7E6wq7dlkRpEWIH9oAlx5EoMsDA8FTc7IRhfs1cNj5Y5UH faFuIDLEslrKMlJrFjJ/slKY+cUlq8pMtXQCr2JnqWHNao+X7jEwq+LLZEeJSmv812ap +CqpgPNe1MNiISlUMxFs8ZMt0jfvkQoi3/dcKum9HBjp9900rhrXD2mdeu4Q/t893X+3 7oQRgrd+mH8pZ3b2oX/Rld6eU/zDzraq0yuv+2GTDWiR6mTyOlmJT7pWX3U5bG7k6+Cc +KeZdoqH3gNQHR52r0SfShFz93VtJKTRFKMdt3mkdOsvNDiRM09HJXqPWVa6aYcFIGsy R8rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719273757; x=1719878557; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KHxvmzfATjrBHHic3spJCjrxStiR31hP0UkREvhW820=; b=VblqDzSOZS/eZp1J5T/JPXz37LH2G4IrsZIsblpS+nUPx1VIQy4qFtFRxLJCIkWok9 ta6lcALYkl/QGsM0bNCLGGXs3rDveAcEMnIiiUtDDZ/LNSVbhvjsvrfqTxA4tOFydTON NzF1hveyFp8vsnGQ6SpZ8dupWEjovcnqWc0j2Xrexyrg4out9EELSLrE7XIrmjWn+NLb BUFohOkd5JtB5QLqirzqqWiRNQXFtFV0egdPZMyP9tiexCYEsygb0m210q7LAcfUaTru xWt3J5V7fSZPdSXDWRoKXAxSg8d01T1z9ueadvTFtDhAHFhcjvBySMIuxEnhZ/3O7g3c c7Qg== X-Forwarded-Encrypted: i=1; AJvYcCXsFRh711+KxGa7SbEunpOIy+N8p+iichWygtwwhU/8OSYSQPn8UVYMejrI6G3Nrpi15BhSmI+wlrGKXAJrOq4= X-Gm-Message-State: AOJu0YxNkMzNw1b3KGbutUHO7zRxlJGLm2FJyFFEfcovYX+bvqxc1t0g uP8Vf2fe0i2Jb36bQrtn6Cslrk1NBsCUtXHTsBw5AbPRMdCWIs0ShHBklwZ5 X-Google-Smtp-Source: AGHT+IH557HdBOB9rKdtU7N5UqELZK5VliMD5cveT0tE/1zy7gUhtZj1N/Yj7eVA7Ulv6Am17YsePQ== X-Received: by 2002:a05:600c:138e:b0:421:805f:ab3c with SMTP id 5b1f17b1804b1-42489533effmr68610235e9.14.1719273757163; Mon, 24 Jun 2024 17:02:37 -0700 (PDT) Received: from localhost ([137.220.120.171]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4248e63a897sm72643345e9.44.2024.06.24.17.02.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jun 2024 17:02:36 -0700 (PDT) From: luca.boccassi@gmail.com To: Erez Shitrit Cc: Matan Azrad , dpdk stable Subject: patch 'net/mlx5/hws: decrease log level for creation failure' has been queued to stable release 22.11.6 Date: Tue, 25 Jun 2024 00:58:51 +0100 Message-Id: <20240624235907.885628-65-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240624235907.885628-1-luca.boccassi@gmail.com> References: <20240624235907.885628-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/27/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/a05258399acb2c3262b612ab6e8e94f4363d93ca Thanks. Luca Boccassi --- >From a05258399acb2c3262b612ab6e8e94f4363d93ca Mon Sep 17 00:00:00 2001 From: Erez Shitrit Date: Mon, 6 May 2024 14:44:04 +0300 Subject: [PATCH] net/mlx5/hws: decrease log level for creation failure [ upstream commit e014d5e2e49994fbc504a49814ed480a60c85d63 ] When the user tries to create a matcher and if failed with specific errno (E2BIG) the message will be in debug level and not in warning. It is a part of a feature when the user re-try to insert a new matching depends on that errno, no need the annoying message. Fixes: c55c2bf35333 ("net/mlx5/hws: add definer layer") Signed-off-by: Erez Shitrit Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_definer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c index d81d66523a..bc1decbec9 100644 --- a/drivers/net/mlx5/hws/mlx5dr_definer.c +++ b/drivers/net/mlx5/hws/mlx5dr_definer.c @@ -1842,7 +1842,7 @@ mlx5dr_definer_find_best_hl_fit(struct mlx5dr_context *ctx, return 0; } - DR_LOG(ERR, "Unable to find supporting match/jumbo definer combination"); + DR_LOG(DEBUG, "Unable to find supporting match/jumbo definer combination"); rte_errno = ENOTSUP; return rte_errno; } @@ -1934,7 +1934,7 @@ int mlx5dr_definer_get(struct mlx5dr_context *ctx, /* Convert items to hl and allocate the field copy array (fc) */ ret = mlx5dr_definer_conv_items_to_hl(ctx, mt, hl); if (ret) { - DR_LOG(ERR, "Failed to convert items to hl"); + DR_LOG(DEBUG, "Failed to convert items to hl"); goto free_hl; } -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-06-25 00:22:17.020521867 +0100 +++ 0065-net-mlx5-hws-decrease-log-level-for-creation-failure.patch 2024-06-25 00:22:13.233186627 +0100 @@ -1 +1 @@ -From e014d5e2e49994fbc504a49814ed480a60c85d63 Mon Sep 17 00:00:00 2001 +From a05258399acb2c3262b612ab6e8e94f4363d93ca Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit e014d5e2e49994fbc504a49814ed480a60c85d63 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -17,3 +18,2 @@ - drivers/net/mlx5/hws/mlx5dr_definer.c | 6 +++--- - drivers/net/mlx5/hws/mlx5dr_matcher.c | 2 +- - 2 files changed, 4 insertions(+), 4 deletions(-) + drivers/net/mlx5/hws/mlx5dr_definer.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) @@ -22 +22 @@ -index a0f95c6923..88be27dcbb 100644 +index d81d66523a..bc1decbec9 100644 @@ -25 +25 @@ -@@ -3539,7 +3539,7 @@ mlx5dr_definer_find_best_match_fit(struct mlx5dr_context *ctx, +@@ -1842,7 +1842,7 @@ mlx5dr_definer_find_best_hl_fit(struct mlx5dr_context *ctx, @@ -31 +31 @@ - rte_errno = E2BIG; + rte_errno = ENOTSUP; @@ -34,25 +34,3 @@ -@@ -3694,7 +3694,7 @@ mlx5dr_definer_calc_layout(struct mlx5dr_matcher *matcher, - /* Find the match definer layout for header layout match union */ - ret = mlx5dr_definer_find_best_match_fit(ctx, match_definer, match_hl); - if (ret) { -- DR_LOG(ERR, "Failed to create match definer from header layout"); -+ DR_LOG(DEBUG, "Failed to create match definer from header layout"); - goto free_fc; - } - -@@ -4046,7 +4046,7 @@ int mlx5dr_definer_matcher_init(struct mlx5dr_context *ctx, - - ret = mlx5dr_definer_calc_layout(matcher, &match_layout, &range_layout); - if (ret) { -- DR_LOG(ERR, "Failed to calculate matcher definer layout"); -+ DR_LOG(DEBUG, "Failed to calculate matcher definer layout"); - return ret; - } - -diff --git a/drivers/net/mlx5/hws/mlx5dr_matcher.c b/drivers/net/mlx5/hws/mlx5dr_matcher.c -index aeff300467..c9f5e46d24 100644 ---- a/drivers/net/mlx5/hws/mlx5dr_matcher.c -+++ b/drivers/net/mlx5/hws/mlx5dr_matcher.c -@@ -877,7 +877,7 @@ static int mlx5dr_matcher_bind_mt(struct mlx5dr_matcher *matcher) - /* Calculate match, range and hash definers */ - ret = mlx5dr_definer_matcher_init(ctx, matcher); +@@ -1934,7 +1934,7 @@ int mlx5dr_definer_get(struct mlx5dr_context *ctx, + /* Convert items to hl and allocate the field copy array (fc) */ + ret = mlx5dr_definer_conv_items_to_hl(ctx, mt, hl); @@ -60,3 +38,3 @@ -- DR_LOG(ERR, "Failed to set matcher templates with match definers"); -+ DR_LOG(DEBUG, "Failed to set matcher templates with match definers"); - return ret; +- DR_LOG(ERR, "Failed to convert items to hl"); ++ DR_LOG(DEBUG, "Failed to convert items to hl"); + goto free_hl;