From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80DED454E9 for ; Tue, 25 Jun 2024 02:03:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7CD0240EDD; Tue, 25 Jun 2024 02:03:26 +0200 (CEST) Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by mails.dpdk.org (Postfix) with ESMTP id 2B53840EDD for ; Tue, 25 Jun 2024 02:03:25 +0200 (CEST) Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2ebec2f11b7so53343741fa.2 for ; Mon, 24 Jun 2024 17:03:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719273804; x=1719878604; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Uf+7wV1aj227TB/94pMNzYLmVbfMvJpht3EUR4coU4I=; b=LVamDEoyzGoiXqdtliFcI35MMcjJ0buh7KzKwpJaCRaxU28nalwfcx57U3oJpJsRyS t7nea9Q22QwAFkMF5P0YOKJR4GMTbtflIkGQwSd+d+bh03VLQNmC8P99+sWrFmKdI8KO E6d0zJkjGhJcPZLpBD4KX7dRUEMaCJRhy0VHTUB8fMN808BlQNcD1dKqvwOqHEAW2Ery j9YeQ3al26ERihdWmeAIxCbLA2qMU4fg7hadNRp/Ojll40d/zyu4jTaE7lL+uP+GTrz+ bMbsQPxAFNtKLXVcRDoysrJy4CpYeUgqt7jq5eVH/Zk/G/DogAdu02nl9bXWf4Z78/v4 n8Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719273804; x=1719878604; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Uf+7wV1aj227TB/94pMNzYLmVbfMvJpht3EUR4coU4I=; b=YkZZcX5lQGCHct1zpY4m3irwXP90YIxB/ew8oCoaq2w4WdcgCTdGbSvvLGkZPPQGTn c2mTELKaj8NTG1TUYKzAD4JPSNGGHmDyYy9owLIooRGtFP5VZWmHdtwzmMG4uz0rEug5 XLBtX3sQM37zypICvLipNiHQlT2+PWBSq9KvE5qRRX6gsA7KFR8/aRHFZwixaPm9dnY0 rvB1uIBxvfR2pG2BPN3ab+/LkkKcPanBTzUfAY2vcVZFF4R5zO1NUEpShOt4ozjMWGoE C43h5gCFika1bTfJ6Cdz1ldHzaWPFGokKy8epbxXdhIzqPMLntwRO74gQFkFuhy5CbQ1 U1+Q== X-Forwarded-Encrypted: i=1; AJvYcCU8rjz9IoZJy3gqK1lsKX3XOK8w4LIrrVblVdVlifDpVDBldFNbqp8ivAFXT5ndBUwmN0owmPJNk+2MHI1Vgkc= X-Gm-Message-State: AOJu0YwbaPG6l7q7nKG1O7hOerjH/ULhiMbYawpqv0aAWNleOTgQUf/y Nks6ia3EP/6JRDAQ3oXXI//VPmZC5eaC1LHvir5fkfkBSawZ8W+/NNa29/zV X-Google-Smtp-Source: AGHT+IH5nUBRkBXytX0dJ1QHGZM2/L8xVcxNuogPMhFAy+x8rEkU/+XqftKCtRsGrc76lzNPMIWczg== X-Received: by 2002:a2e:9811:0:b0:2ec:5019:8fa5 with SMTP id 38308e7fff4ca-2ec5b388425mr31464221fa.40.1719273804476; Mon, 24 Jun 2024 17:03:24 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:7aef:1aaa:3dff:d546]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4247d0b63a9sm191210025e9.9.2024.06.24.17.03.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jun 2024 17:03:24 -0700 (PDT) From: luca.boccassi@gmail.com To: David Marchand Cc: Christian Ehrhardt , Bruce Richardson , dpdk stable Subject: patch 'telemetry: lower log level on socket error' has been queued to stable release 22.11.6 Date: Tue, 25 Jun 2024 00:59:05 +0100 Message-Id: <20240624235907.885628-79-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240624235907.885628-1-luca.boccassi@gmail.com> References: <20240624235907.885628-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/27/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/1620b6d7177b48d01411482465939166026af214 Thanks. Luca Boccassi --- >From 1620b6d7177b48d01411482465939166026af214 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 6 Jun 2024 14:26:54 +0200 Subject: [PATCH] telemetry: lower log level on socket error [ upstream commit 80b7993ba1b45d8aad7c294a7aaf66f4cdf860a5 ] When starting two DPDK programs using the same DPDK prefix (like for example OVS and testpmd, both running as primary processes in --in-memory mode), the first DPDK process of the two spews some error log when the second starts: TELEMETRY: Socket write base info to client failed This is because telemetry init involves trying to connect on existing sockets to check if it can take over an existing socket file. On the other hand, this error log provides no helpful information. Lower this log to debug level. Fixes: e14bb5f10509 ("telemetry: fix connected clients count") Reported-by: Christian Ehrhardt Signed-off-by: David Marchand Acked-by: Bruce Richardson --- lib/telemetry/telemetry.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c index af5da11866..491c4d21dd 100644 --- a/lib/telemetry/telemetry.c +++ b/lib/telemetry/telemetry.c @@ -383,7 +383,7 @@ client_handler(void *sock_id) "{\"version\":\"%s\",\"pid\":%d,\"max_output_len\":%d}", telemetry_version, getpid(), MAX_OUTPUT_LEN); if (write(s, info_str, strlen(info_str)) < 0) { - TMTY_LOG(ERR, "Socket write base info to client failed"); + TMTY_LOG(DEBUG, "Socket write base info to client failed"); goto exit; } -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-06-25 00:22:17.574495288 +0100 +++ 0079-telemetry-lower-log-level-on-socket-error.patch 2024-06-25 00:22:13.309188176 +0100 @@ -1 +1 @@ -From 80b7993ba1b45d8aad7c294a7aaf66f4cdf860a5 Mon Sep 17 00:00:00 2001 +From 1620b6d7177b48d01411482465939166026af214 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 80b7993ba1b45d8aad7c294a7aaf66f4cdf860a5 ] + @@ -20 +21,0 @@ -Cc: stable@dpdk.org @@ -30 +31 @@ -index 1663bd8c68..509fae76ec 100644 +index af5da11866..491c4d21dd 100644 @@ -33 +34 @@ -@@ -382,7 +382,7 @@ client_handler(void *sock_id) +@@ -383,7 +383,7 @@ client_handler(void *sock_id) @@ -37,2 +38,2 @@ -- TMTY_LOG_LINE(ERR, "Socket write base info to client failed"); -+ TMTY_LOG_LINE(DEBUG, "Socket write base info to client failed"); +- TMTY_LOG(ERR, "Socket write base info to client failed"); ++ TMTY_LOG(DEBUG, "Socket write base info to client failed");