From: Gagandeep Singh <g.singh@nxp.com>
To: hemant.agrawal@nxp.com
Cc: Apeksha Gupta <apeksha.gupta@nxp.com>, stable@dpdk.org
Subject: [PATCH 7/9] common/dpaax: fix array overrun issue
Date: Wed, 3 Jul 2024 15:11:40 +0530 [thread overview]
Message-ID: <20240703094142.3021439-10-g.singh@nxp.com> (raw)
In-Reply-To: <20240703094142.3021439-1-g.singh@nxp.com>
From: Apeksha Gupta <apeksha.gupta@nxp.com>
Out-of-bounds read, Overrunning dynamic array nodes at offset corresponding
to index variable j.
Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table")
Cc: stable@dpdk.org
Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
drivers/common/dpaax/dpaax_iova_table.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/common/dpaax/dpaax_iova_table.c b/drivers/common/dpaax/dpaax_iova_table.c
index d2a78f4c19..860e702333 100644
--- a/drivers/common/dpaax/dpaax_iova_table.c
+++ b/drivers/common/dpaax/dpaax_iova_table.c
@@ -139,10 +139,12 @@ read_memory_node(unsigned int *count)
}
DPAAX_DEBUG("Device-tree memory node data:");
- do {
+
+ while (j > 0) {
+ --j;
DPAAX_DEBUG(" %08" PRIx64 " %08zu",
nodes[j].addr, nodes[j].len);
- } while (--j);
+ }
cleanup:
close(fd);
--
2.25.1
next prev parent reply other threads:[~2024-07-03 9:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240703094142.3021439-1-g.singh@nxp.com>
2024-07-03 9:41 ` [PATCH 4/9] bus/dpaa: fix bus scan for DMA devices Gagandeep Singh
2024-07-03 9:41 ` [PATCH 5/9] bus/dpaa: fix resource leak in variable dev Gagandeep Singh
2024-07-03 9:41 ` [PATCH 6/9] common/dpaax: fix IOVA table cleanup Gagandeep Singh
2024-07-03 9:41 ` Gagandeep Singh [this message]
2024-07-03 9:41 ` [PATCH 8/9] bus/dpaa: remove redundant file descriptor check Gagandeep Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240703094142.3021439-10-g.singh@nxp.com \
--to=g.singh@nxp.com \
--cc=apeksha.gupta@nxp.com \
--cc=hemant.agrawal@nxp.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).